Change in ...coreboot[master]: src/mainboard/pcengines/apu2/Kconfig: increase pre-CBMEM console size
Michał Żygowski has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/31419
Change subject: src/mainboard/pcengines/apu2/Kconfig: increase pre-CBMEM console size ......................................................................
src/mainboard/pcengines/apu2/Kconfig: increase pre-CBMEM console size
The default 0xc00 size of pre-CBMEM console is too small to fit whole console log from romstage. Increase the size in order to avoid log truncation when checking console with cbmem utility.
The size was adjusted by compiling and running the coreboot on apu2 with SPEW loglevel.
Additionally unset the SQUELCH_EARLY_SMP option to get console output between amdinitreset and amdinitearly.
Signed-off-by: Michał Żygowski michal.zygowski@3mdeb.com Change-Id: I0a21850e9dc9e9611b462e09b4190258e9bd0a04 --- M src/mainboard/pcengines/apu2/Kconfig 1 file changed, 12 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/19/31419/1
diff --git a/src/mainboard/pcengines/apu2/Kconfig b/src/mainboard/pcengines/apu2/Kconfig index 6e65a6e..3c04b05 100644 --- a/src/mainboard/pcengines/apu2/Kconfig +++ b/src/mainboard/pcengines/apu2/Kconfig @@ -113,4 +113,16 @@ int default 128
+config PRERAM_CBMEM_CONSOLE_SIZE + hex + default 0x3000 + help + Increase this value if preram cbmem console is getting truncated + +config SQUELCH_EARLY_SMP + bool + default n + help + When selected only the BSP CPU will output to early console. + endif # BOARD_PCENGINES_APU2
Kyösti Mälkki has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31419 )
Change subject: src/mainboard/pcengines/apu2/Kconfig: increase pre-CBMEM console size ......................................................................
Patch Set 1: Code-Review-1
(2 comments)
https://review.coreboot.org/#/c/31419/1/src/mainboard/pcengines/apu2/Kconfig File src/mainboard/pcengines/apu2/Kconfig:
https://review.coreboot.org/#/c/31419/1/src/mainboard/pcengines/apu2/Kconfig... PS1, Line 120: Increase this value if preram cbmem console is getting truncated We don't have good upper limit for this value. Therefore we/I are generally refusing to increase the default even for individual boards. Reasoning is this; if you have problems in pre-ram, it's not so likely that you even reach payload or OS to actually read CBMEM console at all. So the debugging would be done on serial console.
https://review.coreboot.org/#/c/31419/1/src/mainboard/pcengines/apu2/Kconfig... PS1, Line 126: When selected only the BSP CPU will output to early console. Probably all other console types than CBMEM console and serial will break with SQUELCH_EARLY_SMP=n. And with AGESA/binaryPI it actually (currently) makes log almos uncompherensible because lines are not tagged with APIC number.
I have some work coming up on review on this part...
Michał Żygowski has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31419 )
Change subject: src/mainboard/pcengines/apu2/Kconfig: increase pre-CBMEM console size ......................................................................
Patch Set 1:
(2 comments)
https://review.coreboot.org/#/c/31419/1/src/mainboard/pcengines/apu2/Kconfig File src/mainboard/pcengines/apu2/Kconfig:
https://review.coreboot.org/#/c/31419/1/src/mainboard/pcengines/apu2/Kconfig... PS1, Line 120: Increase this value if preram cbmem console is getting truncated
We don't have good upper limit for this value. […]
Yeah, I was a little bit afraid of unexpected/unwanted platform behaviour by increasing the pre-cbmem size. Thank You for clarification.
https://review.coreboot.org/#/c/31419/1/src/mainboard/pcengines/apu2/Kconfig... PS1, Line 126: When selected only the BSP CPU will output to early console.
Probably all other console types than CBMEM console and serial will break with SQUELCH_EARLY_SMP=n. […]
Since it is related to hardware access, how about spinlocks?
Michał Żygowski has abandoned this change. ( https://review.coreboot.org/c/coreboot/+/31419 )
Change subject: src/mainboard/pcengines/apu2/Kconfig: increase pre-CBMEM console size ......................................................................
Abandoned
-
Kyösti Mälkki (Code Review) -
Michał Żygowski (Code Review)