Attention is currently required from: Shelley Chen, mturney mturney, Ravi Kumar Bokka, Sudheer Amrabadi, Julius Werner, Angel Pons. Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/60805 )
Change subject: mb/google/herobrine: Fix board id ......................................................................
Patch Set 2:
(4 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/60805/comment/03320dc2_1c3cb756 PS2, Line 9: The board id assignment CL (CB:56642) Please mention the commit hash and commit message summary.
https://review.coreboot.org/c/coreboot/+/60805/comment/1c920f2e_cf047f70 PS2, Line 11: Fixing Maybe: Fix it
https://review.coreboot.org/c/coreboot/+/60805/comment/97de8237_91878431 PS2, Line 9: The board id assignment CL (CB:56642) landed after : BOARD_GOOGLE_HEROBRINE has been deprecated to : BOARD_GOOGLE_HEROBRINE_REV0 … in commit <hash> (<commit message summary>)
https://review.coreboot.org/c/coreboot/+/60805/comment/7c9045d9_21043eae PS2, Line 12: Also fixed a couple of variables : that were declared static when they didn't need to be (they are being : reinitialized at the beginning of each function anyway). Please make that a separate commit.
-
Paul Menzel (Code Review)