Attention is currently required from: Jakub Czapiga, Eric Lai.
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/69208 )
Change subject: vboot: Introduce handy vboot reboot functions
......................................................................
Patch Set 4: Code-Review+1
(4 comments)
File src/security/vboot/vboot_common.c:
https://review.coreboot.org/c/coreboot/+/69208/comment/cd1524bb_4cc8a169
PS3, Line 77: struct vb2_context *ctx = vboot_get_context();
LGTM, thanks :)
Thanks to you :)
File src/security/vboot/vboot_logic.c:
https://review.coreboot.org/c/coreboot/+/69208/comment/7f4790dc_242e7372
PS4, Line 375: rv
This was 0 before
File src/soc/amd/common/psp_verstage/psp_verstage.c:
https://review.coreboot.org/c/coreboot/+/69208/comment/8be667f0_80251748
PS4, Line 46: (int)
This cast looks wrong...
File src/soc/intel/common/block/cse/cse.c:
https://review.coreboot.org/c/coreboot/+/69208/comment/f1d1fc9a_8743bb8b
PS4, Line 935: vboot_get_context()
Apparently this can return NULL. It would be best to keep the NULL check.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/69208
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ie29410e8985e7cf19bd8d4cccc393b050ca1f1c5
Gerrit-Change-Number: 69208
Gerrit-PatchSet: 4
Gerrit-Owner: Jakub Czapiga
jacz@semihalf.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Eric Lai
eric_lai@quanta.corp-partner.google.com
Gerrit-Reviewer: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: Fred Reitberger
reitbergerfred@gmail.com
Gerrit-Reviewer: Jason Glenesk
jason.glenesk@gmail.com
Gerrit-Reviewer: Julius Werner
jwerner@chromium.org
Gerrit-Reviewer: Matt DeVillier
matt.devillier@amd.corp-partner.google.com
Gerrit-Reviewer: Raul Rangel
rrangel@chromium.org
Gerrit-Reviewer: Yu-Ping Wu
yupingso@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Jakub Czapiga
jacz@semihalf.com
Gerrit-Attention: Eric Lai
eric_lai@quanta.corp-partner.google.com
Gerrit-Comment-Date: Sun, 06 Nov 2022 12:41:28 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: Jakub Czapiga
jacz@semihalf.com
Comment-In-Reply-To: Angel Pons
th3fanbus@gmail.com
Gerrit-MessageType: comment