Attention is currently required from: Maximilian Brune.
Maxim Polyakov has posted comments on this change by Maxim Polyakov. ( https://review.coreboot.org/c/coreboot/+/70307?usp=email )
Change subject: util/intelp2m: Drop multi-template support ......................................................................
Patch Set 17:
(1 comment)
Patchset:
PS17: Hi! Thanks for the review!
80% of all changes in each patch are just about formatting
I think you're exaggerating =) (unless, of course, we are talking about all patches)
This is auto-formatting from vscode. Unfortunately, I started using the IDE in "halfway through".
but it is really hard to review
I understand. This adds additional inconvenience to review. But I suggest keeping it as it is. Instead of new changes, I suggest thinking about the linter config and adding it in a separate patch, along with formatting fixes in the code. Otherwise, formatting fixes will be needed after each contributor.
-
Maxim Polyakov (Code Review)