Change in ...coreboot[master]: G505S AtomBIOS ROMs: known good binaries with a script to check their...

List overview All Threads
Download

newer

older

Change in ...coreboot[master]:...

mikeb mikeb (Code Review)

17 Mar 2019 17 Mar '19

5:17 a.m.

Hello Mike Banon,

I'd like you to do a code review. Please visit

https://review.coreboot.org/c/coreboot/+/31944

to review the following change.

Change subject: G505S AtomBIOS ROMs: known good binaries with a script to check their SHA256 ......................................................................

G505S AtomBIOS ROMs: known good binaries with a script to check their SHA256

This change is a mirror for the known good AMD Lenovo G505S AtomBIOS ROMs from this repository - https://github.com/g505s-opensource-researcher/g505s-atombios

AtomBIOS ROMs are required to enable the integrated and discrete VGA adapters, however to add the discrete GPU support you will also need to apply these patches: https://review.coreboot.org/c/coreboot/+/31929 G505S dGPU support: scripts for applying the unofficial (not-merged-yet) patches

Here are the SHA256 checksums for these AtomBIOS ROMs:

6104e6989ea3f494d7bfa30573bf38e830f1068bab9980caec5e890e0ccbfced ./pci1002,990b.rom - for integrated GPU (iGPU) HD-8650G 6052b5def3fda2a93f6c4d55ec91b819429e212e26cdb8e0fcca54599c9c92ed ./pci1002,6663.rom - for discrete GPU (dGPU) HD-8570M 15d74515332bc512de66e0dc910d8600aeb134bf715bbc34a4faac0257f4a0dc ./pci1002,6665.rom - for discrete GPU (dGPU) R5-M230

Save to ./coreboot/ then run ./extract_atombios_roms.sh and ./check... . Could analyze these ROMs with AtomDis - https://cgit.freedesktop.org/~mhopf/AtomDis/

pci1002,990b.rom (for iGPU HD-8650G) has been taken from G505S with R5-M230, and despite the tiny voltage difference - it's working great for all G505S versions. https://mail.coreboot.org/hyperkitty/list/coreboot@coreboot.org/thread/ GZNWISLFHUTYN6C7RTWSQUMJIFOUHMED/

Signed-off-by: Mike Banon mikebdp2@gmail.com Change-Id: I0cb38927e3f5ae0f0850ca8bc79be791c51ae503 --- A check_atombios_roms.sh A extract_atombios_roms.sh A pci1002,6663.rom.txt A pci1002,6665.rom.txt A pci1002,990b.rom.txt A sha256sums_atombios_correct.txt 6 files changed, 8,082 insertions(+), 0 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/44/31944/1

Attachments:

attachment.htm (text/html — 3.3 KB)

Show replies by date

build bot (Jenkins) (Code Review)

17 Mar 17 Mar

5:17 a.m.

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31944 )

Change subject: G505S AtomBIOS ROMs: known good binaries with a script to check their SHA256 ......................................................................

Patch Set 1:

(57 comments)

https://review.coreboot.org/#/c/31944/1/check_atombios_roms.sh File check_atombios_roms.sh:

https://review.coreboot.org/#/c/31944/1/check_atombios_roms.sh@8 PS1, Line 8: echo "SHA256 checksums are correct. Use these AtomBIOS ROMs at your coreboot .config :" line over 80 characters

https://review.coreboot.org/#/c/31944/1/check_atombios_roms.sh@9 PS1, Line 9: echo "*990b.rom = iGPU HD-8650G | *6663.rom = dGPU HD-8570M / *6665.rom = dGPU R5-M230" line over 80 characters

https://review.coreboot.org/#/c/31944/1/check_atombios_roms.sh@12 PS1, Line 12: echo "! MISMATCH ! See ./sha256sums_atombios_my.txt and ./sha256sums_atombios_correct.txt" line over 80 characters

https://review.coreboot.org/#/c/31944/1/pci1002%2C6663.rom.txt File pci1002,6663.rom.txt:

https://review.coreboot.org/#/c/31944/1/pci1002%2C6663.rom.txt@10 PS1, Line 10: 00000090: 1e3e 7800 80b8 5840 2c0d a500 00c6 cc20 .>x...X@,...... trailing whitespace

https://review.coreboot.org/#/c/31944/1/pci1002%2C6663.rom.txt@19 PS1, Line 19: 00000120: 6368 6c61 6e64 2020 2020 2020 2020 2020 chland trailing whitespace

https://review.coreboot.org/#/c/31944/1/pci1002%2C6663.rom.txt@20 PS1, Line 20: 00000130: 2020 2020 2020 2020 2020 2020 2020 2020 trailing whitespace

https://review.coreboot.org/#/c/31944/1/pci1002%2C6663.rom.txt@332 PS1, Line 332: 000014b0: 2366 25ff ff00 0066 3bc8 7321 32db eb20 #f%....f;.s!2.. trailing whitespace

https://review.coreboot.org/#/c/31944/1/pci1002%2C6663.rom.txt@372 PS1, Line 372: 00001730: 8acd b502 e801 1db1 028d 9c48 01e8 b520 ...........H... trailing whitespace

https://review.coreboot.org/#/c/31944/1/pci1002%2C6663.rom.txt@418 PS1, Line 418: 00001a10: 1e24 70c0 e804 8ae8 e85b ff59 5f5d c320 .$p......[.Y_]. trailing whitespace

https://review.coreboot.org/#/c/31944/1/pci1002%2C6663.rom.txt@457 PS1, Line 457: 00001c80: 0ac0 7526 8d9c 4c01 66b8 c409 0000 e820 ..u&..L.f...... trailing whitespace

https://review.coreboot.org/#/c/31944/1/pci1002%2C6663.rom.txt@621 PS1, Line 621: 000026c0: 032a fbc0 e303 8aeb 80fb 1872 0380 cd20 .*.........r... trailing whitespace

https://review.coreboot.org/#/c/31944/1/pci1002%2C6663.rom.txt@872 PS1, Line 872: 00003670: 015e c332 c0c3 6650 532e 8b1e 1602 b220 .^.2..fPS...... trailing whitespace

https://review.coreboot.org/#/c/31944/1/pci1002%2C6663.rom.txt@1271 PS1, Line 1271: 00004f60: 1f8c 4f08 8c47 108c 4f18 8c4f 1c8c 4f20 ..O..G..O..O..O trailing whitespace

https://review.coreboot.org/#/c/31944/1/pci1002%2C6663.rom.txt@1544 PS1, Line 1544: 00006070: ff00 0002 0000 0000 0030 7500 3075 0020 .........0u.0u. trailing whitespace

https://review.coreboot.org/#/c/31944/1/pci1002%2C6663.rom.txt@1549 PS1, Line 1549: 000060c0: 0300 0000 0000 0000 0030 7500 3075 0020 .........0u.0u. trailing whitespace

https://review.coreboot.org/#/c/31944/1/pci1002%2C6663.rom.txt@1571 PS1, Line 1571: 00006220: 910a 0820 0000 0392 0a09 2600 0103 0420 ... ......&.... trailing whitespace

https://review.coreboot.org/#/c/31944/1/pci1002%2C6663.rom.txt@1658 PS1, Line 1658: 00006790: 8c04 0100 cdd0 3010 0000 0000 0821 4420 ......0......!D trailing whitespace

https://review.coreboot.org/#/c/31944/1/pci1002%2C6663.rom.txt@1686 PS1, Line 1686: 00006950: 141e 0640 2080 00c0 0000 0000 0d0d 2020 ...@ ......... trailing whitespace

https://review.coreboot.org/#/c/31944/1/pci1002%2C6663.rom.txt@1729 PS1, Line 1729: 00006c00: 4080 1020 9d03 4000 1020 b603 4080 0020 @.. ..@.. ..@.. trailing whitespace

https://review.coreboot.org/#/c/31944/1/pci1002%2C6663.rom.txt@2010 PS1, Line 2010: 00007d90: ffff ff00 2105 410a 0000 0056 0041 0320 ....!.A....V.A. trailing whitespace

https://review.coreboot.org/#/c/31944/1/pci1002%2C6663.rom.txt@2094 PS1, Line 2094: 000082d0: 6480 0a1c 0001 2480 0a1d 000d 2580 0a20 d.....$.....%.. trailing whitespace

https://review.coreboot.org/#/c/31944/1/pci1002%2C6665.rom.txt File pci1002,6665.rom.txt:

https://review.coreboot.org/#/c/31944/1/pci1002%2C6665.rom.txt@10 PS1, Line 10: 00000090: 1e3e 7800 80b8 5840 2c0d a501 00c6 cc20 .>x...X@,...... trailing whitespace

https://review.coreboot.org/#/c/31944/1/pci1002%2C6665.rom.txt@19 PS1, Line 19: 00000120: 6e64 2020 2020 2020 2020 2020 2020 2020 nd trailing whitespace

https://review.coreboot.org/#/c/31944/1/pci1002%2C6665.rom.txt@20 PS1, Line 20: 00000130: 2020 2020 2020 2020 2020 2020 2020 2020 trailing whitespace

https://review.coreboot.org/#/c/31944/1/pci1002%2C6665.rom.txt@36 PS1, Line 36: 00000230: 0000 8003 4000 290f 0080 0000 414d 4420 ....@.).....AMD trailing whitespace

https://review.coreboot.org/#/c/31944/1/pci1002%2C6665.rom.txt@542 PS1, Line 542: 000021d0: b822 06e8 eeff c3b8 3f06 e8e7 ffc3 b820 ."......?...... trailing whitespace

https://review.coreboot.org/#/c/31944/1/pci1002%2C6665.rom.txt@756 PS1, Line 756: 00002f30: fa15 7507 b501 bb18 00eb 0b80 fa14 7520 ..u...........u trailing whitespace

https://review.coreboot.org/#/c/31944/1/pci1002%2C6665.rom.txt@1487 PS1, Line 1487: 00005ce0: 0000 0000 00c3 0100 0000 0006 3075 0020 ............0u. trailing whitespace

https://review.coreboot.org/#/c/31944/1/pci1002%2C6665.rom.txt@1659 PS1, Line 1659: 000067a0: 4000 1020 b603 4080 0020 cf03 4000 0020 @.. ..@.. ..@.. trailing whitespace

https://review.coreboot.org/#/c/31944/1/pci1002%2C6665.rom.txt@1702 PS1, Line 1702: 00006a50: 0324 4114 0015 0541 0601 0a0a 1541 0320 .$A....A.....A. trailing whitespace

https://review.coreboot.org/#/c/31944/1/pci1002%2C6665.rom.txt@1726 PS1, Line 1726: 00006bd0: 5044 0828 0040 3071 0920 0800 0075 0920 PD.(.@0q. ...u. trailing whitespace

https://review.coreboot.org/#/c/31944/1/pci1002%2C6665.rom.txt@1780 PS1, Line 1780: 00006f30: 1f49 0e00 0725 eb09 fe01 252b 0801 5420 .I...%....%+..T trailing whitespace

https://review.coreboot.org/#/c/31944/1/pci1002%2C6665.rom.txt@1823 PS1, Line 1823: 000071e0: 0125 f705 015b 7a28 0025 0000 0049 2020 .%...[z(.%...I trailing whitespace

https://review.coreboot.org/#/c/31944/1/pci1002%2C6665.rom.txt@2025 PS1, Line 2025: 00007e80: 6480 0a1c 0001 2480 0a1d 000d 2580 0a20 d.....$.....%.. trailing whitespace

https://review.coreboot.org/#/c/31944/1/pci1002%2C990b.rom.txt File pci1002,990b.rom.txt:

https://review.coreboot.org/#/c/31944/1/pci1002%2C990b.rom.txt@13 PS1, Line 13: 000000c0: 2f20 2020 2020 2020 2020 2020 2020 2020 / trailing whitespace

https://review.coreboot.org/#/c/31944/1/pci1002%2C990b.rom.txt@14 PS1, Line 14: 000000d0: 2020 2020 2020 2020 2020 2020 2020 2020 trailing whitespace

https://review.coreboot.org/#/c/31944/1/pci1002%2C990b.rom.txt@15 PS1, Line 15: 000000e0: 2020 2020 2020 2020 2020 2020 2020 2020 trailing whitespace

https://review.coreboot.org/#/c/31944/1/pci1002%2C990b.rom.txt@23 PS1, Line 23: 00000160: 3636 2e31 0032 3532 3735 3620 2000 2020 66.1.252756 . trailing whitespace

https://review.coreboot.org/#/c/31944/1/pci1002%2C990b.rom.txt@29 PS1, Line 29: 000001c0: 0000 0003 7900 1f0f 0080 0000 414d 4420 ....y.......AMD trailing whitespace

https://review.coreboot.org/#/c/31944/1/pci1002%2C990b.rom.txt@434 PS1, Line 434: 00001b10: 2224 70c0 e804 8ae8 e85b ff59 5f5d c320 "$p......[.Y_]. trailing whitespace

https://review.coreboot.org/#/c/31944/1/pci1002%2C990b.rom.txt@638 PS1, Line 638: 000027d0: 032a fbc0 e303 8aeb 80fb 1872 0380 cd20 .*.........r... trailing whitespace

https://review.coreboot.org/#/c/31944/1/pci1002%2C990b.rom.txt@713 PS1, Line 713: 00002c80: ca40 8d9c 5803 e840 11a8 0274 0380 ca20 .@..X..@...t... trailing whitespace

https://review.coreboot.org/#/c/31944/1/pci1002%2C990b.rom.txt@907 PS1, Line 907: 000038a0: 0a66 83e8 20e8 effd 6689 4404 c744 0820 .f.. ...f.D..D. trailing whitespace

https://review.coreboot.org/#/c/31944/1/pci1002%2C990b.rom.txt@930 PS1, Line 930: 00003a10: 10eb 0480 4c28 20f6 4534 0175 05c7 4420 ....L( .E4.u..D trailing whitespace

https://review.coreboot.org/#/c/31944/1/pci1002%2C990b.rom.txt@945 PS1, Line 945: 00003b00: 0175 0333 ffc3 5653 33ff e86c fb8b 5c20 .u.3..VS3..l..\ trailing whitespace

https://review.coreboot.org/#/c/31944/1/pci1002%2C990b.rom.txt@1359 PS1, Line 1359: 000054e0: 1f8c 4f08 8c47 108c 4f18 8c4f 1c8c 4f20 ..O..G..O..O..O trailing whitespace

https://review.coreboot.org/#/c/31944/1/pci1002%2C990b.rom.txt@1514 PS1, Line 1514: 00005e90: 268a 6737 b540 6633 c0eb 0666 b820 0720 &.g7.@f3...f. . trailing whitespace

https://review.coreboot.org/#/c/31944/1/pci1002%2C990b.rom.txt@1607 PS1, Line 1607: 00006460: 282c 0c11 252a 141e 3236 0f13 272c 1b20 (,..%*..26..',. trailing whitespace

https://review.coreboot.org/#/c/31944/1/pci1002%2C990b.rom.txt@2230 PS1, Line 2230: 00008b50: f3a5 13c9 f3a4 8aca 2bf1 2bf9 81c6 0020 ........+.+.... trailing whitespace

https://review.coreboot.org/#/c/31944/1/pci1002%2C990b.rom.txt@2254 PS1, Line 2254: 00008cd0: 80d2 ecc3 e8f0 fcec c3e8 f8ff b2c0 b020 ............... trailing whitespace

https://review.coreboot.org/#/c/31944/1/pci1002%2C990b.rom.txt@2515 PS1, Line 2515: 00009d20: c580 7401 468b cbf3 a483 fb20 7407 b920 ..t.F...... t.. trailing whitespace

https://review.coreboot.org/#/c/31944/1/pci1002%2C990b.rom.txt@3339 PS1, Line 3339: 0000d0a0: ffff ff08 2000 0024 3088 8303 0406 0020 .... ..$0...... trailing whitespace

https://review.coreboot.org/#/c/31944/1/pci1002%2C990b.rom.txt@3474 PS1, Line 3474: 0000d910: ffff ff1e 2100 001e 2200 0320 2100 2620 ....!...".. !.& trailing whitespace

https://review.coreboot.org/#/c/31944/1/pci1002%2C990b.rom.txt@3522 PS1, Line 3522: 0000dc10: 3418 0251 0154 0034 1854 003b 185b 7a20 4..Q.T.4.T.;.[z trailing whitespace

https://review.coreboot.org/#/c/31944/1/pci1002%2C990b.rom.txt@3723 PS1, Line 3723: 0000e8a0: 0f62 4041 3703 0001 0a05 2040 0d25 0820 .b@A7..... @.%. trailing whitespace

https://review.coreboot.org/#/c/31944/1/pci1002%2C990b.rom.txt@3819 PS1, Line 3819: 0000eea0: 0840 1540 1540 1540 1509 2020 2020 2020 .@.@.@.@.. trailing whitespace

https://review.coreboot.org/#/c/31944/1/pci1002%2C990b.rom.txt@3825 PS1, Line 3825: 0000ef00: 0008 4015 4015 4015 4015 0920 2020 2020 ..@.@.@.@.. trailing whitespace

-- To view, visit https://review.coreboot.org/c/coreboot/+/31944 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I0cb38927e3f5ae0f0850ca8bc79be791c51ae503 Gerrit-Change-Number: 31944 Gerrit-PatchSet: 1 Gerrit-Owner: mikeb mikeb mikebdp2@gmail.com Gerrit-Reviewer: Mike Banon mikebdp2@gmail.com Gerrit-CC: build bot (Jenkins) no-reply@coreboot.org Gerrit-Comment-Date: Sun, 17 Mar 2019 12:17:56 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

mikeb mikeb (Code Review)

5:22 a.m.

Hello Mike Banon, build bot (Jenkins),

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/31944

to look at the new patch set (#2).

Change subject: G505S AtomBIOS ROMs: known good binaries with a script to check their SHA256 ......................................................................

G505S AtomBIOS ROMs: known good binaries with a script to check their SHA256

This change is a mirror for the known good AMD Lenovo G505S AtomBIOS ROMs from this repository - https://github.com/g505s-opensource-researcher/g505s-atombios

Save to ./coreboot/ then run ./extract_atombios_roms.sh and ./check... . Could analyze these ROMs with AtomDis - https://cgit.freedesktop.org/~mhopf/AtomDis/

Here are the SHA256 checksums for these AtomBIOS ROMs:

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/44/31944/2

-- To view, visit https://review.coreboot.org/c/coreboot/+/31944 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I0cb38927e3f5ae0f0850ca8bc79be791c51ae503 Gerrit-Change-Number: 31944 Gerrit-PatchSet: 2 Gerrit-Owner: mikeb mikeb mikebdp2@gmail.com Gerrit-Reviewer: Mike Banon mikebdp2@gmail.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-MessageType: newpatchset

mikeb mikeb (Code Review)

5:33 a.m.

mikeb mikeb has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31944 )

Change subject: G505S AtomBIOS ROMs: known good binaries with a script to check their SHA256 ......................................................................

Patch Set 2: Code-Review+1

Everything is fine :) Jenkins just did not like the commas at ROM filenames: lint-stable-023-filenames failed because its' regexp check is [^A-Za-z0-9/_.-] , that's why "X Verified". Please ignore this error and use this change if it could be useful for you.

You will also need CB:31929 - https://review.coreboot.org/c/coreboot/+/31929

...

G505S dGPU support: scripts for applying the unofficial (not-merged-yet) patches

Don't look at their "X Code-Review" status, everything is fine with them as well.

-- To view, visit https://review.coreboot.org/c/coreboot/+/31944 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I0cb38927e3f5ae0f0850ca8bc79be791c51ae503 Gerrit-Change-Number: 31944 Gerrit-PatchSet: 2 Gerrit-Owner: mikeb mikeb mikebdp2@gmail.com Gerrit-Reviewer: Mike Banon mikebdp2@gmail.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-Reviewer: mikeb mikeb mikebdp2@gmail.com Gerrit-Comment-Date: Sun, 17 Mar 2019 12:33:20 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

mikeb mikeb (Code Review)

6:18 a.m.

mikeb mikeb has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31944 )

Change subject: G505S AtomBIOS ROMs: known good binaries with a script to check their SHA256 ......................................................................

Patch Set 2:

Repost of the important README.md parts from https://github.com/g505s-opensource-researcher/g505s-atombios :

# g505s-atombios AMD AtomBIOS video bios releases for G505S Integrated HD-8650G and discrete HD-8570M / R5-M230 GPUs

## Description

coreboot wiki describes 5 different ways of extracting the VGABIOS ROMs: https://www.coreboot.org/VGA_support#How_to_retrieve_a_good_video_bios And all these ways have been tried and found unsuitable for Lenovo G505S: https://mail.coreboot.org/pipermail/coreboot/2017-July/084660.html This message above - also describes a new method which really works!

Sadly this new method is Windows-only, but we believe it is a fine approach, because: two ROMs for integrated GPU, while got at these very different OS, are exactly the same - and most likely it is the same situation for discrete ROM Aside from purely ethical concerns, in practice it should not matter if you are using closed-source Windows instead of open-source Linux to extract the ROMs

But, to ensure that Windows could not receive the instructions from evil server to stealthily modify the extracted ROMs, these conditions should be fulfilled:

1) OS: clean install of Windows 7 Ultimate SP1 x64 without any spying updates (WiFi card removed before installation and OS never connected to the Internet) on a hard drive that has been securely formatted or never used by Windows before ^ same requirement for a media which you are using to bring the drivers/software

2) Proprietary UEFI/BIOS and KB9012 firmware: clean binaries flashed, (part of g505s-proprietary repository)* without any IDs or serial numbers

3)** After the extraction, the ROMs should be directly brought to Linux OS

All these conditions, as well as some others, have been fulfilled by us before the extraction of these ROMs. Please use Linux OS to download and make sure that their SHA-256 checksums are correct before using them

Turning ON/OFF the Dual Graphics before the extraction - does not affect any of these ROMs.

## coreboot.rom operations

Run ./cbfstool.sh script to download and build cbfstool, https://mail.coreboot.org/pipermail/coreboot/2017-July/084671.html [NOTE]: fix this script by adding a single '/' character after "--execute robots=off" at some lines, ===> "--execute robots=off "

Then use one of these commands:

1) Adding VGABIOS to coreboot.rom

./util/cbfstool/cbfstool $COREBOOT_ROM_PATH add -f $VGABIOS_PATH -n pci****,****.rom -t optionrom

2) Removing VGABIOS from coreboot.rom

./util/cbfstool/cbfstool $COREBOOT_ROM_PATH remove -n pci****,****.rom

3) Printing coreboot.rom memory map

./util/cbfstool/cbfstool $COREBOOT_ROM_PATH print

-- To view, visit https://review.coreboot.org/c/coreboot/+/31944 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I0cb38927e3f5ae0f0850ca8bc79be791c51ae503 Gerrit-Change-Number: 31944 Gerrit-PatchSet: 2 Gerrit-Owner: mikeb mikeb mikebdp2@gmail.com Gerrit-Reviewer: Mike Banon mikebdp2@gmail.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-Reviewer: mikeb mikeb mikebdp2@gmail.com Gerrit-Comment-Date: Sun, 17 Mar 2019 13:18:20 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment

mikeb mikeb (Code Review)

3 May 3 May

12:12 p.m.

Hello Mike Banon, build bot (Jenkins),

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/31944

to look at the new patch set (#3).

Change subject: G505S AtomBIOS ROMs: known good binaries with a script to check their SHA256 ......................................................................

G505S AtomBIOS ROMs: known good binaries with a script to check their SHA256

This change is a mirror for the known good AMD Lenovo G505S AtomBIOS ROMs from this repository - https://github.com/g505s-opensource-researcher/g505s-atombios - with the addition of two ROMs for ASUS AM1I-A and A88XM-E boards that I have.

Save to ./coreboot/ then run ./extract_atombios_roms.sh and ./check... . Could analyze these ROMs with AtomDis - https://cgit.freedesktop.org/~mhopf/AtomDis/ Three ROMs are suitable for Lenovo G505S with A10-5750M APU installed, and two as a bonus: for ASUS AM1I-A with Athlon-5370 APU (iGPU HD-8400 / R3-Series) and for ASUS A88XM-E with A10-6700 APU installed (iGPU HD-8670D).

Here are the SHA256 checksums for these AtomBIOS ROMs:

6104e6989ea3f494d7bfa30573bf38e830f1068bab9980caec5e890e0ccbfced ./pci1002,990b.rom - G505S (A10-5750M APU): for integrated GPU (iGPU) HD-8650G 6052b5def3fda2a93f6c4d55ec91b819429e212e26cdb8e0fcca54599c9c92ed ./pci1002,6663.rom - G505S (A10-5750M APU): for discrete GPU (dGPU) HD-8570M 15d74515332bc512de66e0dc910d8600aeb134bf715bbc34a4faac0257f4a0dc ./pci1002,6665.rom - G505S (A10-5750M APU): for discrete GPU (dGPU) R5-M230 cf5ad6f562cda07c8455a5fd33aae49ee6f451561a758e9761d1788767348115 ./pci1002,9830.rom - ASUS AM1I-A (Athlon-5370 APU): for iGPU HD-8400 / R3-Series 73d52887c5c0797a00c38ff1d26528f32620efe41b47c592aa295f008712d0e5 ./pci1002,990c.rom - ASUS A88XM-E (A10-6700 APU): for iGPU HD-8670D

Signed-off-by: Mike Banon mikebdp2@gmail.com Change-Id: I0cb38927e3f5ae0f0850ca8bc79be791c51ae503 --- A check_atombios_roms.sh A extract_atombios_roms.sh A pci1002,6663.rom.txt A pci1002,6665.rom.txt A pci1002,9830.rom.txt A pci1002,990b.rom.txt A pci1002,990c.rom.txt A sha256sums_atombios_correct.txt 8 files changed, 15,717 insertions(+), 0 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/44/31944/3

-- To view, visit https://review.coreboot.org/c/coreboot/+/31944 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I0cb38927e3f5ae0f0850ca8bc79be791c51ae503 Gerrit-Change-Number: 31944 Gerrit-PatchSet: 3 Gerrit-Owner: mikeb mikeb mikebdp2@gmail.com Gerrit-Reviewer: Mike Banon mikebdp2@gmail.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-Reviewer: mikeb mikeb mikebdp2@gmail.com Gerrit-MessageType: newpatchset

build bot (Jenkins) (Code Review)

12:13 p.m.

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31944 )

Change subject: G505S AtomBIOS ROMs: known good binaries with a script to check their SHA256 ......................................................................

Patch Set 3:

(96 comments)

https://review.coreboot.org/#/c/31944/3/check_atombios_roms.sh File check_atombios_roms.sh:

https://review.coreboot.org/#/c/31944/3/check_atombios_roms.sh@10 PS3, Line 10: echo "SHA256 checksums are correct. Use these AtomBIOS ROMs at your coreboot .config :" line over 80 characters

https://review.coreboot.org/#/c/31944/3/check_atombios_roms.sh@12 PS3, Line 12: echo "*990b.rom = iGPU HD-8650G | *6663.rom = dGPU HD-8570M / *6665.rom = dGPU R5-M230" line over 80 characters

https://review.coreboot.org/#/c/31944/3/check_atombios_roms.sh@13 PS3, Line 13: echo "ASUS AM1I-A with Athlon-5370 APU installed: *9830.rom = iGPU HD-8400 / R3-Series" line over 80 characters

https://review.coreboot.org/#/c/31944/3/check_atombios_roms.sh@17 PS3, Line 17: echo "! MISMATCH ! See ./sha256sums_atombios_my.txt and ./sha256sums_atombios_correct.txt" line over 80 characters

https://review.coreboot.org/#/c/31944/3/pci1002%2C6663.rom.txt File pci1002,6663.rom.txt:

https://review.coreboot.org/#/c/31944/3/pci1002%2C6663.rom.txt@10 PS3, Line 10: 00000090: 1e3e 7800 80b8 5840 2c0d a500 00c6 cc20 .>x...X@,...... trailing whitespace

https://review.coreboot.org/#/c/31944/3/pci1002%2C6663.rom.txt@19 PS3, Line 19: 00000120: 6368 6c61 6e64 2020 2020 2020 2020 2020 chland trailing whitespace

https://review.coreboot.org/#/c/31944/3/pci1002%2C6663.rom.txt@20 PS3, Line 20: 00000130: 2020 2020 2020 2020 2020 2020 2020 2020 trailing whitespace

https://review.coreboot.org/#/c/31944/3/pci1002%2C6663.rom.txt@332 PS3, Line 332: 000014b0: 2366 25ff ff00 0066 3bc8 7321 32db eb20 #f%....f;.s!2.. trailing whitespace

https://review.coreboot.org/#/c/31944/3/pci1002%2C6663.rom.txt@372 PS3, Line 372: 00001730: 8acd b502 e801 1db1 028d 9c48 01e8 b520 ...........H... trailing whitespace

https://review.coreboot.org/#/c/31944/3/pci1002%2C6663.rom.txt@418 PS3, Line 418: 00001a10: 1e24 70c0 e804 8ae8 e85b ff59 5f5d c320 .$p......[.Y_]. trailing whitespace

https://review.coreboot.org/#/c/31944/3/pci1002%2C6663.rom.txt@457 PS3, Line 457: 00001c80: 0ac0 7526 8d9c 4c01 66b8 c409 0000 e820 ..u&..L.f...... trailing whitespace

https://review.coreboot.org/#/c/31944/3/pci1002%2C6663.rom.txt@621 PS3, Line 621: 000026c0: 032a fbc0 e303 8aeb 80fb 1872 0380 cd20 .*.........r... trailing whitespace

https://review.coreboot.org/#/c/31944/3/pci1002%2C6663.rom.txt@872 PS3, Line 872: 00003670: 015e c332 c0c3 6650 532e 8b1e 1602 b220 .^.2..fPS...... trailing whitespace

https://review.coreboot.org/#/c/31944/3/pci1002%2C6663.rom.txt@1271 PS3, Line 1271: 00004f60: 1f8c 4f08 8c47 108c 4f18 8c4f 1c8c 4f20 ..O..G..O..O..O trailing whitespace

https://review.coreboot.org/#/c/31944/3/pci1002%2C6663.rom.txt@1544 PS3, Line 1544: 00006070: ff00 0002 0000 0000 0030 7500 3075 0020 .........0u.0u. trailing whitespace

https://review.coreboot.org/#/c/31944/3/pci1002%2C6663.rom.txt@1549 PS3, Line 1549: 000060c0: 0300 0000 0000 0000 0030 7500 3075 0020 .........0u.0u. trailing whitespace

https://review.coreboot.org/#/c/31944/3/pci1002%2C6663.rom.txt@1571 PS3, Line 1571: 00006220: 910a 0820 0000 0392 0a09 2600 0103 0420 ... ......&.... trailing whitespace

https://review.coreboot.org/#/c/31944/3/pci1002%2C6663.rom.txt@1658 PS3, Line 1658: 00006790: 8c04 0100 cdd0 3010 0000 0000 0821 4420 ......0......!D trailing whitespace

https://review.coreboot.org/#/c/31944/3/pci1002%2C6663.rom.txt@1686 PS3, Line 1686: 00006950: 141e 0640 2080 00c0 0000 0000 0d0d 2020 ...@ ......... trailing whitespace

https://review.coreboot.org/#/c/31944/3/pci1002%2C6663.rom.txt@1729 PS3, Line 1729: 00006c00: 4080 1020 9d03 4000 1020 b603 4080 0020 @.. ..@.. ..@.. trailing whitespace

https://review.coreboot.org/#/c/31944/3/pci1002%2C6663.rom.txt@2010 PS3, Line 2010: 00007d90: ffff ff00 2105 410a 0000 0056 0041 0320 ....!.A....V.A. trailing whitespace

https://review.coreboot.org/#/c/31944/3/pci1002%2C6663.rom.txt@2094 PS3, Line 2094: 000082d0: 6480 0a1c 0001 2480 0a1d 000d 2580 0a20 d.....$.....%.. trailing whitespace

https://review.coreboot.org/#/c/31944/3/pci1002%2C6665.rom.txt File pci1002,6665.rom.txt:

https://review.coreboot.org/#/c/31944/3/pci1002%2C6665.rom.txt@10 PS3, Line 10: 00000090: 1e3e 7800 80b8 5840 2c0d a501 00c6 cc20 .>x...X@,...... trailing whitespace

https://review.coreboot.org/#/c/31944/3/pci1002%2C6665.rom.txt@19 PS3, Line 19: 00000120: 6e64 2020 2020 2020 2020 2020 2020 2020 nd trailing whitespace

https://review.coreboot.org/#/c/31944/3/pci1002%2C6665.rom.txt@20 PS3, Line 20: 00000130: 2020 2020 2020 2020 2020 2020 2020 2020 trailing whitespace

https://review.coreboot.org/#/c/31944/3/pci1002%2C6665.rom.txt@36 PS3, Line 36: 00000230: 0000 8003 4000 290f 0080 0000 414d 4420 ....@.).....AMD trailing whitespace

https://review.coreboot.org/#/c/31944/3/pci1002%2C6665.rom.txt@542 PS3, Line 542: 000021d0: b822 06e8 eeff c3b8 3f06 e8e7 ffc3 b820 ."......?...... trailing whitespace

https://review.coreboot.org/#/c/31944/3/pci1002%2C6665.rom.txt@756 PS3, Line 756: 00002f30: fa15 7507 b501 bb18 00eb 0b80 fa14 7520 ..u...........u trailing whitespace

https://review.coreboot.org/#/c/31944/3/pci1002%2C6665.rom.txt@1487 PS3, Line 1487: 00005ce0: 0000 0000 00c3 0100 0000 0006 3075 0020 ............0u. trailing whitespace

https://review.coreboot.org/#/c/31944/3/pci1002%2C6665.rom.txt@1659 PS3, Line 1659: 000067a0: 4000 1020 b603 4080 0020 cf03 4000 0020 @.. ..@.. ..@.. trailing whitespace

https://review.coreboot.org/#/c/31944/3/pci1002%2C6665.rom.txt@1702 PS3, Line 1702: 00006a50: 0324 4114 0015 0541 0601 0a0a 1541 0320 .$A....A.....A. trailing whitespace

https://review.coreboot.org/#/c/31944/3/pci1002%2C6665.rom.txt@1726 PS3, Line 1726: 00006bd0: 5044 0828 0040 3071 0920 0800 0075 0920 PD.(.@0q. ...u. trailing whitespace

https://review.coreboot.org/#/c/31944/3/pci1002%2C6665.rom.txt@1780 PS3, Line 1780: 00006f30: 1f49 0e00 0725 eb09 fe01 252b 0801 5420 .I...%....%+..T trailing whitespace

https://review.coreboot.org/#/c/31944/3/pci1002%2C6665.rom.txt@1823 PS3, Line 1823: 000071e0: 0125 f705 015b 7a28 0025 0000 0049 2020 .%...[z(.%...I trailing whitespace

https://review.coreboot.org/#/c/31944/3/pci1002%2C6665.rom.txt@2025 PS3, Line 2025: 00007e80: 6480 0a1c 0001 2480 0a1d 000d 2580 0a20 d.....$.....%.. trailing whitespace

https://review.coreboot.org/#/c/31944/3/pci1002%2C9830.rom.txt File pci1002,9830.rom.txt:

https://review.coreboot.org/#/c/31944/3/pci1002%2C9830.rom.txt@13 PS3, Line 13: 000000c0: 6572 6963 2056 4249 4f53 2020 2020 2020 eric VBIOS trailing whitespace

https://review.coreboot.org/#/c/31944/3/pci1002%2C9830.rom.txt@14 PS3, Line 14: 000000d0: 2020 2020 2020 2020 2020 2020 2020 2020 trailing whitespace

https://review.coreboot.org/#/c/31944/3/pci1002%2C9830.rom.txt@15 PS3, Line 15: 000000e0: 2020 2020 2020 2020 2020 2020 2020 2020 trailing whitespace

https://review.coreboot.org/#/c/31944/3/pci1002%2C9830.rom.txt@125 PS3, Line 125: 000007c0: 0a2c 46fe c975 f48a c559 c302 0104 0820 .,F..u...Y..... trailing whitespace

https://review.coreboot.org/#/c/31944/3/pci1002%2C9830.rom.txt@229 PS3, Line 229: 00000e40: c3bb 0600 e87d 248a c880 e110 d0e9 a820 .....}$........ trailing whitespace

https://review.coreboot.org/#/c/31944/3/pci1002%2C9830.rom.txt@292 PS3, Line 292: 00001230: 741b e8fb 04e8 1b20 7408 8b56 04e8 1320 t...... t..V... trailing whitespace

https://review.coreboot.org/#/c/31944/3/pci1002%2C9830.rom.txt@773 PS3, Line 773: 00003040: 7d32 c080 ee21 80fa 1e74 15b0 0280 fa20 }2...!...t..... trailing whitespace

https://review.coreboot.org/#/c/31944/3/pci1002%2C9830.rom.txt@1010 PS3, Line 1010: 00003f10: fe8c d08e c026 8b7c 268a 4501 32e4 b920 .....&.|&.E.2.. trailing whitespace

https://review.coreboot.org/#/c/31944/3/pci1002%2C9830.rom.txt@1483 PS3, Line 1483: 00005ca0: 1f53 66bb 401c 001c e8f0 c4be 001c b020 .Sf.@.......... trailing whitespace

https://review.coreboot.org/#/c/31944/3/pci1002%2C9830.rom.txt@2270 PS3, Line 2270: 00008dd0: c32e 8e1e 1503 890e 6004 8ac5 2460 a820 ........`...$`. trailing whitespace

https://review.coreboot.org/#/c/31944/3/pci1002%2C9830.rom.txt@2918 PS3, Line 2918: 0000b650: 0002 0000 f03f 1040 0001 0411 1101 0020 .....?.@....... trailing whitespace

https://review.coreboot.org/#/c/31944/3/pci1002%2C9830.rom.txt@2966 PS3, Line 2966: 0000b950: 013a c900 4115 0541 0801 02c4 0041 5420 .:..A..A.....AT trailing whitespace

https://review.coreboot.org/#/c/31944/3/pci1002%2C9830.rom.txt@3199 PS3, Line 3199: 0000c7e0: 001a 010d e5b3 1b10 5ca2 b31b ef40 5420 ............@T trailing whitespace

https://review.coreboot.org/#/c/31944/3/pci1002%2C9830.rom.txt@3329 PS3, Line 3329: 0000d000: 0046 4ce5 4110 497f 0404 a500 4a3b 0520 .FL.A.I.....J;. trailing whitespace

https://review.coreboot.org/#/c/31944/3/pci1002%2C9830.rom.txt@3365 PS3, Line 3365: 0000d240: 0001 b400 0000 dc00 0000 dd00 0001 9120 ............... trailing whitespace

https://review.coreboot.org/#/c/31944/3/pci1002%2C990b.rom.txt File pci1002,990b.rom.txt:

https://review.coreboot.org/#/c/31944/3/pci1002%2C990b.rom.txt@13 PS3, Line 13: 000000c0: 2f20 2020 2020 2020 2020 2020 2020 2020 / trailing whitespace

https://review.coreboot.org/#/c/31944/3/pci1002%2C990b.rom.txt@14 PS3, Line 14: 000000d0: 2020 2020 2020 2020 2020 2020 2020 2020 trailing whitespace

https://review.coreboot.org/#/c/31944/3/pci1002%2C990b.rom.txt@15 PS3, Line 15: 000000e0: 2020 2020 2020 2020 2020 2020 2020 2020 trailing whitespace

https://review.coreboot.org/#/c/31944/3/pci1002%2C990b.rom.txt@23 PS3, Line 23: 00000160: 3636 2e31 0032 3532 3735 3620 2000 2020 66.1.252756 . trailing whitespace

https://review.coreboot.org/#/c/31944/3/pci1002%2C990b.rom.txt@29 PS3, Line 29: 000001c0: 0000 0003 7900 1f0f 0080 0000 414d 4420 ....y.......AMD trailing whitespace

https://review.coreboot.org/#/c/31944/3/pci1002%2C990b.rom.txt@434 PS3, Line 434: 00001b10: 2224 70c0 e804 8ae8 e85b ff59 5f5d c320 "$p......[.Y_]. trailing whitespace

https://review.coreboot.org/#/c/31944/3/pci1002%2C990b.rom.txt@638 PS3, Line 638: 000027d0: 032a fbc0 e303 8aeb 80fb 1872 0380 cd20 .*.........r... trailing whitespace

https://review.coreboot.org/#/c/31944/3/pci1002%2C990b.rom.txt@713 PS3, Line 713: 00002c80: ca40 8d9c 5803 e840 11a8 0274 0380 ca20 .@..X..@...t... trailing whitespace

https://review.coreboot.org/#/c/31944/3/pci1002%2C990b.rom.txt@907 PS3, Line 907: 000038a0: 0a66 83e8 20e8 effd 6689 4404 c744 0820 .f.. ...f.D..D. trailing whitespace

https://review.coreboot.org/#/c/31944/3/pci1002%2C990b.rom.txt@930 PS3, Line 930: 00003a10: 10eb 0480 4c28 20f6 4534 0175 05c7 4420 ....L( .E4.u..D trailing whitespace

https://review.coreboot.org/#/c/31944/3/pci1002%2C990b.rom.txt@945 PS3, Line 945: 00003b00: 0175 0333 ffc3 5653 33ff e86c fb8b 5c20 .u.3..VS3..l..\ trailing whitespace

https://review.coreboot.org/#/c/31944/3/pci1002%2C990b.rom.txt@1359 PS3, Line 1359: 000054e0: 1f8c 4f08 8c47 108c 4f18 8c4f 1c8c 4f20 ..O..G..O..O..O trailing whitespace

https://review.coreboot.org/#/c/31944/3/pci1002%2C990b.rom.txt@1514 PS3, Line 1514: 00005e90: 268a 6737 b540 6633 c0eb 0666 b820 0720 &.g7.@f3...f. . trailing whitespace

https://review.coreboot.org/#/c/31944/3/pci1002%2C990b.rom.txt@1607 PS3, Line 1607: 00006460: 282c 0c11 252a 141e 3236 0f13 272c 1b20 (,..%*..26..',. trailing whitespace

https://review.coreboot.org/#/c/31944/3/pci1002%2C990b.rom.txt@2230 PS3, Line 2230: 00008b50: f3a5 13c9 f3a4 8aca 2bf1 2bf9 81c6 0020 ........+.+.... trailing whitespace

https://review.coreboot.org/#/c/31944/3/pci1002%2C990b.rom.txt@2254 PS3, Line 2254: 00008cd0: 80d2 ecc3 e8f0 fcec c3e8 f8ff b2c0 b020 ............... trailing whitespace

https://review.coreboot.org/#/c/31944/3/pci1002%2C990b.rom.txt@2515 PS3, Line 2515: 00009d20: c580 7401 468b cbf3 a483 fb20 7407 b920 ..t.F...... t.. trailing whitespace

https://review.coreboot.org/#/c/31944/3/pci1002%2C990b.rom.txt@3339 PS3, Line 3339: 0000d0a0: ffff ff08 2000 0024 3088 8303 0406 0020 .... ..$0...... trailing whitespace

https://review.coreboot.org/#/c/31944/3/pci1002%2C990b.rom.txt@3474 PS3, Line 3474: 0000d910: ffff ff1e 2100 001e 2200 0320 2100 2620 ....!...".. !.& trailing whitespace

https://review.coreboot.org/#/c/31944/3/pci1002%2C990b.rom.txt@3522 PS3, Line 3522: 0000dc10: 3418 0251 0154 0034 1854 003b 185b 7a20 4..Q.T.4.T.;.[z trailing whitespace

https://review.coreboot.org/#/c/31944/3/pci1002%2C990b.rom.txt@3723 PS3, Line 3723: 0000e8a0: 0f62 4041 3703 0001 0a05 2040 0d25 0820 .b@A7..... @.%. trailing whitespace

https://review.coreboot.org/#/c/31944/3/pci1002%2C990b.rom.txt@3819 PS3, Line 3819: 0000eea0: 0840 1540 1540 1540 1509 2020 2020 2020 .@.@.@.@.. trailing whitespace

https://review.coreboot.org/#/c/31944/3/pci1002%2C990b.rom.txt@3825 PS3, Line 3825: 0000ef00: 0008 4015 4015 4015 4015 0920 2020 2020 ..@.@.@.@.. trailing whitespace

https://review.coreboot.org/#/c/31944/3/pci1002%2C990c.rom.txt File pci1002,990c.rom.txt:

https://review.coreboot.org/#/c/31944/3/pci1002%2C990c.rom.txt@13 PS3, Line 13: 000000c0: 2f20 2020 2020 2020 2020 2020 2020 2020 / trailing whitespace

https://review.coreboot.org/#/c/31944/3/pci1002%2C990c.rom.txt@14 PS3, Line 14: 000000d0: 2020 2020 2020 2020 2020 2020 2020 2020 trailing whitespace

https://review.coreboot.org/#/c/31944/3/pci1002%2C990c.rom.txt@15 PS3, Line 15: 000000e0: 2020 2020 2020 2020 2020 2020 2020 2020 trailing whitespace

https://review.coreboot.org/#/c/31944/3/pci1002%2C990c.rom.txt@23 PS3, Line 23: 00000160: 3636 2e31 0032 3532 3735 3620 2000 2020 66.1.252756 . trailing whitespace

https://review.coreboot.org/#/c/31944/3/pci1002%2C990c.rom.txt@29 PS3, Line 29: 000001c0: 0000 0003 7900 1f0f 0080 0000 414d 4420 ....y.......AMD trailing whitespace

https://review.coreboot.org/#/c/31944/3/pci1002%2C990c.rom.txt@434 PS3, Line 434: 00001b10: 2224 70c0 e804 8ae8 e85b ff59 5f5d c320 "$p......[.Y_]. trailing whitespace

https://review.coreboot.org/#/c/31944/3/pci1002%2C990c.rom.txt@638 PS3, Line 638: 000027d0: 032a fbc0 e303 8aeb 80fb 1872 0380 cd20 .*.........r... trailing whitespace

https://review.coreboot.org/#/c/31944/3/pci1002%2C990c.rom.txt@713 PS3, Line 713: 00002c80: ca40 8d9c 5803 e840 11a8 0274 0380 ca20 .@..X..@...t... trailing whitespace

https://review.coreboot.org/#/c/31944/3/pci1002%2C990c.rom.txt@907 PS3, Line 907: 000038a0: 0a66 83e8 20e8 effd 6689 4404 c744 0820 .f.. ...f.D..D. trailing whitespace

https://review.coreboot.org/#/c/31944/3/pci1002%2C990c.rom.txt@930 PS3, Line 930: 00003a10: 10eb 0480 4c28 20f6 4534 0175 05c7 4420 ....L( .E4.u..D trailing whitespace

https://review.coreboot.org/#/c/31944/3/pci1002%2C990c.rom.txt@945 PS3, Line 945: 00003b00: 0175 0333 ffc3 5653 33ff e86c fb8b 5c20 .u.3..VS3..l..\ trailing whitespace

https://review.coreboot.org/#/c/31944/3/pci1002%2C990c.rom.txt@1359 PS3, Line 1359: 000054e0: 1f8c 4f08 8c47 108c 4f18 8c4f 1c8c 4f20 ..O..G..O..O..O trailing whitespace

https://review.coreboot.org/#/c/31944/3/pci1002%2C990c.rom.txt@1514 PS3, Line 1514: 00005e90: 268a 6737 b540 6633 c0eb 0666 b820 0720 &.g7.@f3...f. . trailing whitespace

https://review.coreboot.org/#/c/31944/3/pci1002%2C990c.rom.txt@1607 PS3, Line 1607: 00006460: 282c 0c11 252a 141e 3236 0f13 272c 1b20 (,..%*..26..',. trailing whitespace

https://review.coreboot.org/#/c/31944/3/pci1002%2C990c.rom.txt@2230 PS3, Line 2230: 00008b50: f3a5 13c9 f3a4 8aca 2bf1 2bf9 81c6 0020 ........+.+.... trailing whitespace

https://review.coreboot.org/#/c/31944/3/pci1002%2C990c.rom.txt@2254 PS3, Line 2254: 00008cd0: 80d2 ecc3 e8f0 fcec c3e8 f8ff b2c0 b020 ............... trailing whitespace

https://review.coreboot.org/#/c/31944/3/pci1002%2C990c.rom.txt@2515 PS3, Line 2515: 00009d20: c580 7401 468b cbf3 a483 fb20 7407 b920 ..t.F...... t.. trailing whitespace

https://review.coreboot.org/#/c/31944/3/pci1002%2C990c.rom.txt@3339 PS3, Line 3339: 0000d0a0: ffff ff08 2000 0024 3088 8303 0406 0020 .... ..$0...... trailing whitespace

https://review.coreboot.org/#/c/31944/3/pci1002%2C990c.rom.txt@3474 PS3, Line 3474: 0000d910: ffff ff1e 2100 001e 2200 0320 2100 2620 ....!...".. !.& trailing whitespace

https://review.coreboot.org/#/c/31944/3/pci1002%2C990c.rom.txt@3522 PS3, Line 3522: 0000dc10: 3418 0251 0154 0034 1854 003b 185b 7a20 4..Q.T.4.T.;.[z trailing whitespace

https://review.coreboot.org/#/c/31944/3/pci1002%2C990c.rom.txt@3723 PS3, Line 3723: 0000e8a0: 0f62 4041 3703 0001 0a05 2040 0d25 0820 .b@A7..... @.%. trailing whitespace

https://review.coreboot.org/#/c/31944/3/pci1002%2C990c.rom.txt@3819 PS3, Line 3819: 0000eea0: 0840 1540 1540 1540 1509 2020 2020 2020 .@.@.@.@.. trailing whitespace

https://review.coreboot.org/#/c/31944/3/pci1002%2C990c.rom.txt@3825 PS3, Line 3825: 0000ef00: 0008 4015 4015 4015 4015 0920 2020 2020 ..@.@.@.@.. trailing whitespace

-- To view, visit https://review.coreboot.org/c/coreboot/+/31944 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I0cb38927e3f5ae0f0850ca8bc79be791c51ae503 Gerrit-Change-Number: 31944 Gerrit-PatchSet: 3 Gerrit-Owner: mikeb mikeb mikebdp2@gmail.com Gerrit-Reviewer: Mike Banon mikebdp2@gmail.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-Reviewer: mikeb mikeb mikebdp2@gmail.com Gerrit-Comment-Date: Fri, 03 May 2019 19:13:10 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

build bot (Jenkins) (Code Review)

12:16 p.m.

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31944 )

Change subject: G505S AtomBIOS ROMs: known good binaries with a script to check their SHA256 ......................................................................

Patch Set 4:

(96 comments)

https://review.coreboot.org/#/c/31944/4/check_atombios_roms.sh File check_atombios_roms.sh:

https://review.coreboot.org/#/c/31944/4/check_atombios_roms.sh@10 PS4, Line 10: echo "SHA256 checksums are correct. Use these AtomBIOS ROMs at your coreboot .config :" line over 80 characters

https://review.coreboot.org/#/c/31944/4/check_atombios_roms.sh@12 PS4, Line 12: echo "*990b.rom = iGPU HD-8650G | *6663.rom = dGPU HD-8570M / *6665.rom = dGPU R5-M230" line over 80 characters

https://review.coreboot.org/#/c/31944/4/check_atombios_roms.sh@13 PS4, Line 13: echo "ASUS AM1I-A with Athlon-5370 APU installed: *9830.rom = iGPU HD-8400 / R3-Series" line over 80 characters

https://review.coreboot.org/#/c/31944/4/check_atombios_roms.sh@17 PS4, Line 17: echo "! MISMATCH ! See ./sha256sums_atombios_my.txt and ./sha256sums_atombios_correct.txt" line over 80 characters

https://review.coreboot.org/#/c/31944/4/pci1002%2C6663.rom.txt File pci1002,6663.rom.txt:

https://review.coreboot.org/#/c/31944/4/pci1002%2C6663.rom.txt@10 PS4, Line 10: 00000090: 1e3e 7800 80b8 5840 2c0d a500 00c6 cc20 .>x...X@,...... trailing whitespace

https://review.coreboot.org/#/c/31944/4/pci1002%2C6663.rom.txt@19 PS4, Line 19: 00000120: 6368 6c61 6e64 2020 2020 2020 2020 2020 chland trailing whitespace

https://review.coreboot.org/#/c/31944/4/pci1002%2C6663.rom.txt@20 PS4, Line 20: 00000130: 2020 2020 2020 2020 2020 2020 2020 2020 trailing whitespace

https://review.coreboot.org/#/c/31944/4/pci1002%2C6663.rom.txt@332 PS4, Line 332: 000014b0: 2366 25ff ff00 0066 3bc8 7321 32db eb20 #f%....f;.s!2.. trailing whitespace

https://review.coreboot.org/#/c/31944/4/pci1002%2C6663.rom.txt@372 PS4, Line 372: 00001730: 8acd b502 e801 1db1 028d 9c48 01e8 b520 ...........H... trailing whitespace

https://review.coreboot.org/#/c/31944/4/pci1002%2C6663.rom.txt@418 PS4, Line 418: 00001a10: 1e24 70c0 e804 8ae8 e85b ff59 5f5d c320 .$p......[.Y_]. trailing whitespace

https://review.coreboot.org/#/c/31944/4/pci1002%2C6663.rom.txt@457 PS4, Line 457: 00001c80: 0ac0 7526 8d9c 4c01 66b8 c409 0000 e820 ..u&..L.f...... trailing whitespace

https://review.coreboot.org/#/c/31944/4/pci1002%2C6663.rom.txt@621 PS4, Line 621: 000026c0: 032a fbc0 e303 8aeb 80fb 1872 0380 cd20 .*.........r... trailing whitespace

https://review.coreboot.org/#/c/31944/4/pci1002%2C6663.rom.txt@872 PS4, Line 872: 00003670: 015e c332 c0c3 6650 532e 8b1e 1602 b220 .^.2..fPS...... trailing whitespace

https://review.coreboot.org/#/c/31944/4/pci1002%2C6663.rom.txt@1271 PS4, Line 1271: 00004f60: 1f8c 4f08 8c47 108c 4f18 8c4f 1c8c 4f20 ..O..G..O..O..O trailing whitespace

https://review.coreboot.org/#/c/31944/4/pci1002%2C6663.rom.txt@1544 PS4, Line 1544: 00006070: ff00 0002 0000 0000 0030 7500 3075 0020 .........0u.0u. trailing whitespace

https://review.coreboot.org/#/c/31944/4/pci1002%2C6663.rom.txt@1549 PS4, Line 1549: 000060c0: 0300 0000 0000 0000 0030 7500 3075 0020 .........0u.0u. trailing whitespace

https://review.coreboot.org/#/c/31944/4/pci1002%2C6663.rom.txt@1571 PS4, Line 1571: 00006220: 910a 0820 0000 0392 0a09 2600 0103 0420 ... ......&.... trailing whitespace

https://review.coreboot.org/#/c/31944/4/pci1002%2C6663.rom.txt@1658 PS4, Line 1658: 00006790: 8c04 0100 cdd0 3010 0000 0000 0821 4420 ......0......!D trailing whitespace

https://review.coreboot.org/#/c/31944/4/pci1002%2C6663.rom.txt@1686 PS4, Line 1686: 00006950: 141e 0640 2080 00c0 0000 0000 0d0d 2020 ...@ ......... trailing whitespace

https://review.coreboot.org/#/c/31944/4/pci1002%2C6663.rom.txt@1729 PS4, Line 1729: 00006c00: 4080 1020 9d03 4000 1020 b603 4080 0020 @.. ..@.. ..@.. trailing whitespace

https://review.coreboot.org/#/c/31944/4/pci1002%2C6663.rom.txt@2010 PS4, Line 2010: 00007d90: ffff ff00 2105 410a 0000 0056 0041 0320 ....!.A....V.A. trailing whitespace

https://review.coreboot.org/#/c/31944/4/pci1002%2C6663.rom.txt@2094 PS4, Line 2094: 000082d0: 6480 0a1c 0001 2480 0a1d 000d 2580 0a20 d.....$.....%.. trailing whitespace

https://review.coreboot.org/#/c/31944/4/pci1002%2C6665.rom.txt File pci1002,6665.rom.txt:

https://review.coreboot.org/#/c/31944/4/pci1002%2C6665.rom.txt@10 PS4, Line 10: 00000090: 1e3e 7800 80b8 5840 2c0d a501 00c6 cc20 .>x...X@,...... trailing whitespace

https://review.coreboot.org/#/c/31944/4/pci1002%2C6665.rom.txt@19 PS4, Line 19: 00000120: 6e64 2020 2020 2020 2020 2020 2020 2020 nd trailing whitespace

https://review.coreboot.org/#/c/31944/4/pci1002%2C6665.rom.txt@20 PS4, Line 20: 00000130: 2020 2020 2020 2020 2020 2020 2020 2020 trailing whitespace

https://review.coreboot.org/#/c/31944/4/pci1002%2C6665.rom.txt@36 PS4, Line 36: 00000230: 0000 8003 4000 290f 0080 0000 414d 4420 ....@.).....AMD trailing whitespace

https://review.coreboot.org/#/c/31944/4/pci1002%2C6665.rom.txt@542 PS4, Line 542: 000021d0: b822 06e8 eeff c3b8 3f06 e8e7 ffc3 b820 ."......?...... trailing whitespace

https://review.coreboot.org/#/c/31944/4/pci1002%2C6665.rom.txt@756 PS4, Line 756: 00002f30: fa15 7507 b501 bb18 00eb 0b80 fa14 7520 ..u...........u trailing whitespace

https://review.coreboot.org/#/c/31944/4/pci1002%2C6665.rom.txt@1487 PS4, Line 1487: 00005ce0: 0000 0000 00c3 0100 0000 0006 3075 0020 ............0u. trailing whitespace

https://review.coreboot.org/#/c/31944/4/pci1002%2C6665.rom.txt@1659 PS4, Line 1659: 000067a0: 4000 1020 b603 4080 0020 cf03 4000 0020 @.. ..@.. ..@.. trailing whitespace

https://review.coreboot.org/#/c/31944/4/pci1002%2C6665.rom.txt@1702 PS4, Line 1702: 00006a50: 0324 4114 0015 0541 0601 0a0a 1541 0320 .$A....A.....A. trailing whitespace

https://review.coreboot.org/#/c/31944/4/pci1002%2C6665.rom.txt@1726 PS4, Line 1726: 00006bd0: 5044 0828 0040 3071 0920 0800 0075 0920 PD.(.@0q. ...u. trailing whitespace

https://review.coreboot.org/#/c/31944/4/pci1002%2C6665.rom.txt@1780 PS4, Line 1780: 00006f30: 1f49 0e00 0725 eb09 fe01 252b 0801 5420 .I...%....%+..T trailing whitespace

https://review.coreboot.org/#/c/31944/4/pci1002%2C6665.rom.txt@1823 PS4, Line 1823: 000071e0: 0125 f705 015b 7a28 0025 0000 0049 2020 .%...[z(.%...I trailing whitespace

https://review.coreboot.org/#/c/31944/4/pci1002%2C6665.rom.txt@2025 PS4, Line 2025: 00007e80: 6480 0a1c 0001 2480 0a1d 000d 2580 0a20 d.....$.....%.. trailing whitespace

https://review.coreboot.org/#/c/31944/4/pci1002%2C9830.rom.txt File pci1002,9830.rom.txt:

https://review.coreboot.org/#/c/31944/4/pci1002%2C9830.rom.txt@13 PS4, Line 13: 000000c0: 6572 6963 2056 4249 4f53 2020 2020 2020 eric VBIOS trailing whitespace

https://review.coreboot.org/#/c/31944/4/pci1002%2C9830.rom.txt@14 PS4, Line 14: 000000d0: 2020 2020 2020 2020 2020 2020 2020 2020 trailing whitespace

https://review.coreboot.org/#/c/31944/4/pci1002%2C9830.rom.txt@15 PS4, Line 15: 000000e0: 2020 2020 2020 2020 2020 2020 2020 2020 trailing whitespace

https://review.coreboot.org/#/c/31944/4/pci1002%2C9830.rom.txt@125 PS4, Line 125: 000007c0: 0a2c 46fe c975 f48a c559 c302 0104 0820 .,F..u...Y..... trailing whitespace

https://review.coreboot.org/#/c/31944/4/pci1002%2C9830.rom.txt@229 PS4, Line 229: 00000e40: c3bb 0600 e87d 248a c880 e110 d0e9 a820 .....}$........ trailing whitespace

https://review.coreboot.org/#/c/31944/4/pci1002%2C9830.rom.txt@292 PS4, Line 292: 00001230: 741b e8fb 04e8 1b20 7408 8b56 04e8 1320 t...... t..V... trailing whitespace

https://review.coreboot.org/#/c/31944/4/pci1002%2C9830.rom.txt@773 PS4, Line 773: 00003040: 7d32 c080 ee21 80fa 1e74 15b0 0280 fa20 }2...!...t..... trailing whitespace

https://review.coreboot.org/#/c/31944/4/pci1002%2C9830.rom.txt@1010 PS4, Line 1010: 00003f10: fe8c d08e c026 8b7c 268a 4501 32e4 b920 .....&.|&.E.2.. trailing whitespace

https://review.coreboot.org/#/c/31944/4/pci1002%2C9830.rom.txt@1483 PS4, Line 1483: 00005ca0: 1f53 66bb 401c 001c e8f0 c4be 001c b020 .Sf.@.......... trailing whitespace

https://review.coreboot.org/#/c/31944/4/pci1002%2C9830.rom.txt@2270 PS4, Line 2270: 00008dd0: c32e 8e1e 1503 890e 6004 8ac5 2460 a820 ........`...$`. trailing whitespace

https://review.coreboot.org/#/c/31944/4/pci1002%2C9830.rom.txt@2918 PS4, Line 2918: 0000b650: 0002 0000 f03f 1040 0001 0411 1101 0020 .....?.@....... trailing whitespace

https://review.coreboot.org/#/c/31944/4/pci1002%2C9830.rom.txt@2966 PS4, Line 2966: 0000b950: 013a c900 4115 0541 0801 02c4 0041 5420 .:..A..A.....AT trailing whitespace

https://review.coreboot.org/#/c/31944/4/pci1002%2C9830.rom.txt@3199 PS4, Line 3199: 0000c7e0: 001a 010d e5b3 1b10 5ca2 b31b ef40 5420 ............@T trailing whitespace

https://review.coreboot.org/#/c/31944/4/pci1002%2C9830.rom.txt@3329 PS4, Line 3329: 0000d000: 0046 4ce5 4110 497f 0404 a500 4a3b 0520 .FL.A.I.....J;. trailing whitespace

https://review.coreboot.org/#/c/31944/4/pci1002%2C9830.rom.txt@3365 PS4, Line 3365: 0000d240: 0001 b400 0000 dc00 0000 dd00 0001 9120 ............... trailing whitespace

https://review.coreboot.org/#/c/31944/4/pci1002%2C990b.rom.txt File pci1002,990b.rom.txt:

https://review.coreboot.org/#/c/31944/4/pci1002%2C990b.rom.txt@13 PS4, Line 13: 000000c0: 2f20 2020 2020 2020 2020 2020 2020 2020 / trailing whitespace

https://review.coreboot.org/#/c/31944/4/pci1002%2C990b.rom.txt@14 PS4, Line 14: 000000d0: 2020 2020 2020 2020 2020 2020 2020 2020 trailing whitespace

https://review.coreboot.org/#/c/31944/4/pci1002%2C990b.rom.txt@15 PS4, Line 15: 000000e0: 2020 2020 2020 2020 2020 2020 2020 2020 trailing whitespace

https://review.coreboot.org/#/c/31944/4/pci1002%2C990b.rom.txt@23 PS4, Line 23: 00000160: 3636 2e31 0032 3532 3735 3620 2000 2020 66.1.252756 . trailing whitespace

https://review.coreboot.org/#/c/31944/4/pci1002%2C990b.rom.txt@29 PS4, Line 29: 000001c0: 0000 0003 7900 1f0f 0080 0000 414d 4420 ....y.......AMD trailing whitespace

https://review.coreboot.org/#/c/31944/4/pci1002%2C990b.rom.txt@434 PS4, Line 434: 00001b10: 2224 70c0 e804 8ae8 e85b ff59 5f5d c320 "$p......[.Y_]. trailing whitespace

https://review.coreboot.org/#/c/31944/4/pci1002%2C990b.rom.txt@638 PS4, Line 638: 000027d0: 032a fbc0 e303 8aeb 80fb 1872 0380 cd20 .*.........r... trailing whitespace

https://review.coreboot.org/#/c/31944/4/pci1002%2C990b.rom.txt@713 PS4, Line 713: 00002c80: ca40 8d9c 5803 e840 11a8 0274 0380 ca20 .@..X..@...t... trailing whitespace

https://review.coreboot.org/#/c/31944/4/pci1002%2C990b.rom.txt@907 PS4, Line 907: 000038a0: 0a66 83e8 20e8 effd 6689 4404 c744 0820 .f.. ...f.D..D. trailing whitespace

https://review.coreboot.org/#/c/31944/4/pci1002%2C990b.rom.txt@930 PS4, Line 930: 00003a10: 10eb 0480 4c28 20f6 4534 0175 05c7 4420 ....L( .E4.u..D trailing whitespace

https://review.coreboot.org/#/c/31944/4/pci1002%2C990b.rom.txt@945 PS4, Line 945: 00003b00: 0175 0333 ffc3 5653 33ff e86c fb8b 5c20 .u.3..VS3..l..\ trailing whitespace

https://review.coreboot.org/#/c/31944/4/pci1002%2C990b.rom.txt@1359 PS4, Line 1359: 000054e0: 1f8c 4f08 8c47 108c 4f18 8c4f 1c8c 4f20 ..O..G..O..O..O trailing whitespace

https://review.coreboot.org/#/c/31944/4/pci1002%2C990b.rom.txt@1514 PS4, Line 1514: 00005e90: 268a 6737 b540 6633 c0eb 0666 b820 0720 &.g7.@f3...f. . trailing whitespace

https://review.coreboot.org/#/c/31944/4/pci1002%2C990b.rom.txt@1607 PS4, Line 1607: 00006460: 282c 0c11 252a 141e 3236 0f13 272c 1b20 (,..%*..26..',. trailing whitespace

https://review.coreboot.org/#/c/31944/4/pci1002%2C990b.rom.txt@2230 PS4, Line 2230: 00008b50: f3a5 13c9 f3a4 8aca 2bf1 2bf9 81c6 0020 ........+.+.... trailing whitespace

https://review.coreboot.org/#/c/31944/4/pci1002%2C990b.rom.txt@2254 PS4, Line 2254: 00008cd0: 80d2 ecc3 e8f0 fcec c3e8 f8ff b2c0 b020 ............... trailing whitespace

https://review.coreboot.org/#/c/31944/4/pci1002%2C990b.rom.txt@2515 PS4, Line 2515: 00009d20: c580 7401 468b cbf3 a483 fb20 7407 b920 ..t.F...... t.. trailing whitespace

https://review.coreboot.org/#/c/31944/4/pci1002%2C990b.rom.txt@3339 PS4, Line 3339: 0000d0a0: ffff ff08 2000 0024 3088 8303 0406 0020 .... ..$0...... trailing whitespace

https://review.coreboot.org/#/c/31944/4/pci1002%2C990b.rom.txt@3474 PS4, Line 3474: 0000d910: ffff ff1e 2100 001e 2200 0320 2100 2620 ....!...".. !.& trailing whitespace

https://review.coreboot.org/#/c/31944/4/pci1002%2C990b.rom.txt@3522 PS4, Line 3522: 0000dc10: 3418 0251 0154 0034 1854 003b 185b 7a20 4..Q.T.4.T.;.[z trailing whitespace

https://review.coreboot.org/#/c/31944/4/pci1002%2C990b.rom.txt@3723 PS4, Line 3723: 0000e8a0: 0f62 4041 3703 0001 0a05 2040 0d25 0820 .b@A7..... @.%. trailing whitespace

https://review.coreboot.org/#/c/31944/4/pci1002%2C990b.rom.txt@3819 PS4, Line 3819: 0000eea0: 0840 1540 1540 1540 1509 2020 2020 2020 .@.@.@.@.. trailing whitespace

https://review.coreboot.org/#/c/31944/4/pci1002%2C990b.rom.txt@3825 PS4, Line 3825: 0000ef00: 0008 4015 4015 4015 4015 0920 2020 2020 ..@.@.@.@.. trailing whitespace

https://review.coreboot.org/#/c/31944/4/pci1002%2C990c.rom.txt File pci1002,990c.rom.txt:

https://review.coreboot.org/#/c/31944/4/pci1002%2C990c.rom.txt@13 PS4, Line 13: 000000c0: 2f20 2020 2020 2020 2020 2020 2020 2020 / trailing whitespace

https://review.coreboot.org/#/c/31944/4/pci1002%2C990c.rom.txt@14 PS4, Line 14: 000000d0: 2020 2020 2020 2020 2020 2020 2020 2020 trailing whitespace

https://review.coreboot.org/#/c/31944/4/pci1002%2C990c.rom.txt@15 PS4, Line 15: 000000e0: 2020 2020 2020 2020 2020 2020 2020 2020 trailing whitespace

https://review.coreboot.org/#/c/31944/4/pci1002%2C990c.rom.txt@23 PS4, Line 23: 00000160: 3636 2e31 0032 3532 3735 3620 2000 2020 66.1.252756 . trailing whitespace

https://review.coreboot.org/#/c/31944/4/pci1002%2C990c.rom.txt@29 PS4, Line 29: 000001c0: 0000 0003 7900 1f0f 0080 0000 414d 4420 ....y.......AMD trailing whitespace

https://review.coreboot.org/#/c/31944/4/pci1002%2C990c.rom.txt@434 PS4, Line 434: 00001b10: 2224 70c0 e804 8ae8 e85b ff59 5f5d c320 "$p......[.Y_]. trailing whitespace

https://review.coreboot.org/#/c/31944/4/pci1002%2C990c.rom.txt@638 PS4, Line 638: 000027d0: 032a fbc0 e303 8aeb 80fb 1872 0380 cd20 .*.........r... trailing whitespace

https://review.coreboot.org/#/c/31944/4/pci1002%2C990c.rom.txt@713 PS4, Line 713: 00002c80: ca40 8d9c 5803 e840 11a8 0274 0380 ca20 .@..X..@...t... trailing whitespace

https://review.coreboot.org/#/c/31944/4/pci1002%2C990c.rom.txt@907 PS4, Line 907: 000038a0: 0a66 83e8 20e8 effd 6689 4404 c744 0820 .f.. ...f.D..D. trailing whitespace

https://review.coreboot.org/#/c/31944/4/pci1002%2C990c.rom.txt@930 PS4, Line 930: 00003a10: 10eb 0480 4c28 20f6 4534 0175 05c7 4420 ....L( .E4.u..D trailing whitespace

https://review.coreboot.org/#/c/31944/4/pci1002%2C990c.rom.txt@945 PS4, Line 945: 00003b00: 0175 0333 ffc3 5653 33ff e86c fb8b 5c20 .u.3..VS3..l..\ trailing whitespace

https://review.coreboot.org/#/c/31944/4/pci1002%2C990c.rom.txt@1359 PS4, Line 1359: 000054e0: 1f8c 4f08 8c47 108c 4f18 8c4f 1c8c 4f20 ..O..G..O..O..O trailing whitespace

https://review.coreboot.org/#/c/31944/4/pci1002%2C990c.rom.txt@1514 PS4, Line 1514: 00005e90: 268a 6737 b540 6633 c0eb 0666 b820 0720 &.g7.@f3...f. . trailing whitespace

https://review.coreboot.org/#/c/31944/4/pci1002%2C990c.rom.txt@1607 PS4, Line 1607: 00006460: 282c 0c11 252a 141e 3236 0f13 272c 1b20 (,..%*..26..',. trailing whitespace

https://review.coreboot.org/#/c/31944/4/pci1002%2C990c.rom.txt@2230 PS4, Line 2230: 00008b50: f3a5 13c9 f3a4 8aca 2bf1 2bf9 81c6 0020 ........+.+.... trailing whitespace

https://review.coreboot.org/#/c/31944/4/pci1002%2C990c.rom.txt@2254 PS4, Line 2254: 00008cd0: 80d2 ecc3 e8f0 fcec c3e8 f8ff b2c0 b020 ............... trailing whitespace

https://review.coreboot.org/#/c/31944/4/pci1002%2C990c.rom.txt@2515 PS4, Line 2515: 00009d20: c580 7401 468b cbf3 a483 fb20 7407 b920 ..t.F...... t.. trailing whitespace

https://review.coreboot.org/#/c/31944/4/pci1002%2C990c.rom.txt@3339 PS4, Line 3339: 0000d0a0: ffff ff08 2000 0024 3088 8303 0406 0020 .... ..$0...... trailing whitespace

https://review.coreboot.org/#/c/31944/4/pci1002%2C990c.rom.txt@3474 PS4, Line 3474: 0000d910: ffff ff1e 2100 001e 2200 0320 2100 2620 ....!...".. !.& trailing whitespace

https://review.coreboot.org/#/c/31944/4/pci1002%2C990c.rom.txt@3522 PS4, Line 3522: 0000dc10: 3418 0251 0154 0034 1854 003b 185b 7a20 4..Q.T.4.T.;.[z trailing whitespace

https://review.coreboot.org/#/c/31944/4/pci1002%2C990c.rom.txt@3723 PS4, Line 3723: 0000e8a0: 0f62 4041 3703 0001 0a05 2040 0d25 0820 .b@A7..... @.%. trailing whitespace

https://review.coreboot.org/#/c/31944/4/pci1002%2C990c.rom.txt@3819 PS4, Line 3819: 0000eea0: 0840 1540 1540 1540 1509 2020 2020 2020 .@.@.@.@.. trailing whitespace

https://review.coreboot.org/#/c/31944/4/pci1002%2C990c.rom.txt@3825 PS4, Line 3825: 0000ef00: 0008 4015 4015 4015 4015 0920 2020 2020 ..@.@.@.@.. trailing whitespace

-- To view, visit https://review.coreboot.org/c/coreboot/+/31944 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I0cb38927e3f5ae0f0850ca8bc79be791c51ae503 Gerrit-Change-Number: 31944 Gerrit-PatchSet: 4 Gerrit-Owner: mikeb mikeb mikebdp2@gmail.com Gerrit-Reviewer: Mike Banon mikebdp2@gmail.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-Reviewer: mikeb mikeb mikebdp2@gmail.com Gerrit-Comment-Date: Fri, 03 May 2019 19:16:15 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

mikeb mikeb (Code Review)

10:27 p.m.

mikeb mikeb has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31944 )

Change subject: G505S AtomBIOS ROMs: known good binaries with a script to check their SHA256 ......................................................................

Patch Set 4: Code-Review+1

Added two ROMs as a bonus: for ASUS AM1I-A with Athlon-5370 APU (iGPU HD-8400 / R3-Series) and for ASUS A88XM-E with A10-6700 APU installed (iGPU HD-8670D). Just in case, I have obtained each of them via two very different methods: 1) Retrieval via Linux kernel - https://www.coreboot.org/VGA_support#Retrieval_via_Linux_kernel 2) "Windows 7 + Belkasoft RAM Capturer" method described at https://github.com/g505s-opensource-researcher/g505s-atombios and https://mail.coreboot.org/pipermail/coreboot/2017-July/084660.html And their checksums matched between those methods :-) I have a great confidence in the submitted new ROMs, so marking +1 although I don't expect this patch to ever get merged.

-- To view, visit https://review.coreboot.org/c/coreboot/+/31944 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I0cb38927e3f5ae0f0850ca8bc79be791c51ae503 Gerrit-Change-Number: 31944 Gerrit-PatchSet: 4 Gerrit-Owner: mikeb mikeb mikebdp2@gmail.com Gerrit-Reviewer: Mike Banon mikebdp2@gmail.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-Reviewer: mikeb mikeb mikebdp2@gmail.com Gerrit-Comment-Date: Sat, 04 May 2019 05:27:25 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

build bot (Jenkins) (Code Review)

19 May 19 May

4:24 a.m.

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31944 )

Change subject: G505S AtomBIOS ROMs: known good binaries with a script to check their SHA256 ......................................................................

Patch Set 5:

(96 comments)

https://review.coreboot.org/#/c/31944/5/check_atombios_roms.sh File check_atombios_roms.sh:

https://review.coreboot.org/#/c/31944/5/check_atombios_roms.sh@10 PS5, Line 10: echo "SHA256 checksums are correct. Use these AtomBIOS ROMs at your coreboot .config :" line over 80 characters

https://review.coreboot.org/#/c/31944/5/check_atombios_roms.sh@12 PS5, Line 12: echo "*990b.rom = iGPU HD-8650G | *6663.rom = dGPU HD-8570M / *6665.rom = dGPU R5-M230" line over 80 characters

https://review.coreboot.org/#/c/31944/5/check_atombios_roms.sh@13 PS5, Line 13: echo "ASUS AM1I-A with Athlon-5370 APU installed: *9830.rom = iGPU HD-8400 / R3-Series" line over 80 characters

https://review.coreboot.org/#/c/31944/5/check_atombios_roms.sh@17 PS5, Line 17: echo "! MISMATCH ! See ./sha256sums_atombios_my.txt and ./sha256sums_atombios_correct.txt" line over 80 characters

https://review.coreboot.org/#/c/31944/5/pci1002%2C6663.rom.txt File pci1002,6663.rom.txt:

https://review.coreboot.org/#/c/31944/5/pci1002%2C6663.rom.txt@10 PS5, Line 10: 00000090: 1e3e 7800 80b8 5840 2c0d a500 00c6 cc20 .>x...X@,...... trailing whitespace

https://review.coreboot.org/#/c/31944/5/pci1002%2C6663.rom.txt@19 PS5, Line 19: 00000120: 6368 6c61 6e64 2020 2020 2020 2020 2020 chland trailing whitespace

https://review.coreboot.org/#/c/31944/5/pci1002%2C6663.rom.txt@20 PS5, Line 20: 00000130: 2020 2020 2020 2020 2020 2020 2020 2020 trailing whitespace

https://review.coreboot.org/#/c/31944/5/pci1002%2C6663.rom.txt@332 PS5, Line 332: 000014b0: 2366 25ff ff00 0066 3bc8 7321 32db eb20 #f%....f;.s!2.. trailing whitespace

https://review.coreboot.org/#/c/31944/5/pci1002%2C6663.rom.txt@372 PS5, Line 372: 00001730: 8acd b502 e801 1db1 028d 9c48 01e8 b520 ...........H... trailing whitespace

https://review.coreboot.org/#/c/31944/5/pci1002%2C6663.rom.txt@418 PS5, Line 418: 00001a10: 1e24 70c0 e804 8ae8 e85b ff59 5f5d c320 .$p......[.Y_]. trailing whitespace

https://review.coreboot.org/#/c/31944/5/pci1002%2C6663.rom.txt@457 PS5, Line 457: 00001c80: 0ac0 7526 8d9c 4c01 66b8 c409 0000 e820 ..u&..L.f...... trailing whitespace

https://review.coreboot.org/#/c/31944/5/pci1002%2C6663.rom.txt@621 PS5, Line 621: 000026c0: 032a fbc0 e303 8aeb 80fb 1872 0380 cd20 .*.........r... trailing whitespace

https://review.coreboot.org/#/c/31944/5/pci1002%2C6663.rom.txt@872 PS5, Line 872: 00003670: 015e c332 c0c3 6650 532e 8b1e 1602 b220 .^.2..fPS...... trailing whitespace

https://review.coreboot.org/#/c/31944/5/pci1002%2C6663.rom.txt@1271 PS5, Line 1271: 00004f60: 1f8c 4f08 8c47 108c 4f18 8c4f 1c8c 4f20 ..O..G..O..O..O trailing whitespace

https://review.coreboot.org/#/c/31944/5/pci1002%2C6663.rom.txt@1544 PS5, Line 1544: 00006070: ff00 0002 0000 0000 0030 7500 3075 0020 .........0u.0u. trailing whitespace

https://review.coreboot.org/#/c/31944/5/pci1002%2C6663.rom.txt@1549 PS5, Line 1549: 000060c0: 0300 0000 0000 0000 0030 7500 3075 0020 .........0u.0u. trailing whitespace

https://review.coreboot.org/#/c/31944/5/pci1002%2C6663.rom.txt@1571 PS5, Line 1571: 00006220: 910a 0820 0000 0392 0a09 2600 0103 0420 ... ......&.... trailing whitespace

https://review.coreboot.org/#/c/31944/5/pci1002%2C6663.rom.txt@1658 PS5, Line 1658: 00006790: 8c04 0100 cdd0 3010 0000 0000 0821 4420 ......0......!D trailing whitespace

https://review.coreboot.org/#/c/31944/5/pci1002%2C6663.rom.txt@1686 PS5, Line 1686: 00006950: 141e 0640 2080 00c0 0000 0000 0d0d 2020 ...@ ......... trailing whitespace

https://review.coreboot.org/#/c/31944/5/pci1002%2C6663.rom.txt@1729 PS5, Line 1729: 00006c00: 4080 1020 9d03 4000 1020 b603 4080 0020 @.. ..@.. ..@.. trailing whitespace

https://review.coreboot.org/#/c/31944/5/pci1002%2C6663.rom.txt@2010 PS5, Line 2010: 00007d90: ffff ff00 2105 410a 0000 0056 0041 0320 ....!.A....V.A. trailing whitespace

https://review.coreboot.org/#/c/31944/5/pci1002%2C6663.rom.txt@2094 PS5, Line 2094: 000082d0: 6480 0a1c 0001 2480 0a1d 000d 2580 0a20 d.....$.....%.. trailing whitespace

https://review.coreboot.org/#/c/31944/5/pci1002%2C6665.rom.txt File pci1002,6665.rom.txt:

https://review.coreboot.org/#/c/31944/5/pci1002%2C6665.rom.txt@10 PS5, Line 10: 00000090: 1e3e 7800 80b8 5840 2c0d a501 00c6 cc20 .>x...X@,...... trailing whitespace

https://review.coreboot.org/#/c/31944/5/pci1002%2C6665.rom.txt@19 PS5, Line 19: 00000120: 6e64 2020 2020 2020 2020 2020 2020 2020 nd trailing whitespace

https://review.coreboot.org/#/c/31944/5/pci1002%2C6665.rom.txt@20 PS5, Line 20: 00000130: 2020 2020 2020 2020 2020 2020 2020 2020 trailing whitespace

https://review.coreboot.org/#/c/31944/5/pci1002%2C6665.rom.txt@36 PS5, Line 36: 00000230: 0000 8003 4000 290f 0080 0000 414d 4420 ....@.).....AMD trailing whitespace

https://review.coreboot.org/#/c/31944/5/pci1002%2C6665.rom.txt@542 PS5, Line 542: 000021d0: b822 06e8 eeff c3b8 3f06 e8e7 ffc3 b820 ."......?...... trailing whitespace

https://review.coreboot.org/#/c/31944/5/pci1002%2C6665.rom.txt@756 PS5, Line 756: 00002f30: fa15 7507 b501 bb18 00eb 0b80 fa14 7520 ..u...........u trailing whitespace

https://review.coreboot.org/#/c/31944/5/pci1002%2C6665.rom.txt@1487 PS5, Line 1487: 00005ce0: 0000 0000 00c3 0100 0000 0006 3075 0020 ............0u. trailing whitespace

https://review.coreboot.org/#/c/31944/5/pci1002%2C6665.rom.txt@1659 PS5, Line 1659: 000067a0: 4000 1020 b603 4080 0020 cf03 4000 0020 @.. ..@.. ..@.. trailing whitespace

https://review.coreboot.org/#/c/31944/5/pci1002%2C6665.rom.txt@1702 PS5, Line 1702: 00006a50: 0324 4114 0015 0541 0601 0a0a 1541 0320 .$A....A.....A. trailing whitespace

https://review.coreboot.org/#/c/31944/5/pci1002%2C6665.rom.txt@1726 PS5, Line 1726: 00006bd0: 5044 0828 0040 3071 0920 0800 0075 0920 PD.(.@0q. ...u. trailing whitespace

https://review.coreboot.org/#/c/31944/5/pci1002%2C6665.rom.txt@1780 PS5, Line 1780: 00006f30: 1f49 0e00 0725 eb09 fe01 252b 0801 5420 .I...%....%+..T trailing whitespace

https://review.coreboot.org/#/c/31944/5/pci1002%2C6665.rom.txt@1823 PS5, Line 1823: 000071e0: 0125 f705 015b 7a28 0025 0000 0049 2020 .%...[z(.%...I trailing whitespace

https://review.coreboot.org/#/c/31944/5/pci1002%2C6665.rom.txt@2025 PS5, Line 2025: 00007e80: 6480 0a1c 0001 2480 0a1d 000d 2580 0a20 d.....$.....%.. trailing whitespace

https://review.coreboot.org/#/c/31944/5/pci1002%2C9830.rom.txt File pci1002,9830.rom.txt:

https://review.coreboot.org/#/c/31944/5/pci1002%2C9830.rom.txt@13 PS5, Line 13: 000000c0: 6572 6963 2056 4249 4f53 2020 2020 2020 eric VBIOS trailing whitespace

https://review.coreboot.org/#/c/31944/5/pci1002%2C9830.rom.txt@14 PS5, Line 14: 000000d0: 2020 2020 2020 2020 2020 2020 2020 2020 trailing whitespace

https://review.coreboot.org/#/c/31944/5/pci1002%2C9830.rom.txt@15 PS5, Line 15: 000000e0: 2020 2020 2020 2020 2020 2020 2020 2020 trailing whitespace

https://review.coreboot.org/#/c/31944/5/pci1002%2C9830.rom.txt@125 PS5, Line 125: 000007c0: 0a2c 46fe c975 f48a c559 c302 0104 0820 .,F..u...Y..... trailing whitespace

https://review.coreboot.org/#/c/31944/5/pci1002%2C9830.rom.txt@229 PS5, Line 229: 00000e40: c3bb 0600 e87d 248a c880 e110 d0e9 a820 .....}$........ trailing whitespace

https://review.coreboot.org/#/c/31944/5/pci1002%2C9830.rom.txt@292 PS5, Line 292: 00001230: 741b e8fb 04e8 1b20 7408 8b56 04e8 1320 t...... t..V... trailing whitespace

https://review.coreboot.org/#/c/31944/5/pci1002%2C9830.rom.txt@773 PS5, Line 773: 00003040: 7d32 c080 ee21 80fa 1e74 15b0 0280 fa20 }2...!...t..... trailing whitespace

https://review.coreboot.org/#/c/31944/5/pci1002%2C9830.rom.txt@1010 PS5, Line 1010: 00003f10: fe8c d08e c026 8b7c 268a 4501 32e4 b920 .....&.|&.E.2.. trailing whitespace

https://review.coreboot.org/#/c/31944/5/pci1002%2C9830.rom.txt@1483 PS5, Line 1483: 00005ca0: 1f53 66bb 401c 001c e8f0 c4be 001c b020 .Sf.@.......... trailing whitespace

https://review.coreboot.org/#/c/31944/5/pci1002%2C9830.rom.txt@2270 PS5, Line 2270: 00008dd0: c32e 8e1e 1503 890e 6004 8ac5 2460 a820 ........`...$`. trailing whitespace

https://review.coreboot.org/#/c/31944/5/pci1002%2C9830.rom.txt@2918 PS5, Line 2918: 0000b650: 0002 0000 f03f 1040 0001 0411 1101 0020 .....?.@....... trailing whitespace

https://review.coreboot.org/#/c/31944/5/pci1002%2C9830.rom.txt@2966 PS5, Line 2966: 0000b950: 013a c900 4115 0541 0801 02c4 0041 5420 .:..A..A.....AT trailing whitespace

https://review.coreboot.org/#/c/31944/5/pci1002%2C9830.rom.txt@3199 PS5, Line 3199: 0000c7e0: 001a 010d e5b3 1b10 5ca2 b31b ef40 5420 ............@T trailing whitespace

https://review.coreboot.org/#/c/31944/5/pci1002%2C9830.rom.txt@3329 PS5, Line 3329: 0000d000: 0046 4ce5 4110 497f 0404 a500 4a3b 0520 .FL.A.I.....J;. trailing whitespace

https://review.coreboot.org/#/c/31944/5/pci1002%2C9830.rom.txt@3365 PS5, Line 3365: 0000d240: 0001 b400 0000 dc00 0000 dd00 0001 9120 ............... trailing whitespace

https://review.coreboot.org/#/c/31944/5/pci1002%2C990b.rom.txt File pci1002,990b.rom.txt:

https://review.coreboot.org/#/c/31944/5/pci1002%2C990b.rom.txt@13 PS5, Line 13: 000000c0: 2f20 2020 2020 2020 2020 2020 2020 2020 / trailing whitespace

https://review.coreboot.org/#/c/31944/5/pci1002%2C990b.rom.txt@14 PS5, Line 14: 000000d0: 2020 2020 2020 2020 2020 2020 2020 2020 trailing whitespace

https://review.coreboot.org/#/c/31944/5/pci1002%2C990b.rom.txt@15 PS5, Line 15: 000000e0: 2020 2020 2020 2020 2020 2020 2020 2020 trailing whitespace

https://review.coreboot.org/#/c/31944/5/pci1002%2C990b.rom.txt@23 PS5, Line 23: 00000160: 3636 2e31 0032 3532 3735 3620 2000 2020 66.1.252756 . trailing whitespace

https://review.coreboot.org/#/c/31944/5/pci1002%2C990b.rom.txt@29 PS5, Line 29: 000001c0: 0000 0003 7900 1f0f 0080 0000 414d 4420 ....y.......AMD trailing whitespace

https://review.coreboot.org/#/c/31944/5/pci1002%2C990b.rom.txt@434 PS5, Line 434: 00001b10: 2224 70c0 e804 8ae8 e85b ff59 5f5d c320 "$p......[.Y_]. trailing whitespace

https://review.coreboot.org/#/c/31944/5/pci1002%2C990b.rom.txt@638 PS5, Line 638: 000027d0: 032a fbc0 e303 8aeb 80fb 1872 0380 cd20 .*.........r... trailing whitespace

https://review.coreboot.org/#/c/31944/5/pci1002%2C990b.rom.txt@713 PS5, Line 713: 00002c80: ca40 8d9c 5803 e840 11a8 0274 0380 ca20 .@..X..@...t... trailing whitespace

https://review.coreboot.org/#/c/31944/5/pci1002%2C990b.rom.txt@907 PS5, Line 907: 000038a0: 0a66 83e8 20e8 effd 6689 4404 c744 0820 .f.. ...f.D..D. trailing whitespace

https://review.coreboot.org/#/c/31944/5/pci1002%2C990b.rom.txt@930 PS5, Line 930: 00003a10: 10eb 0480 4c28 20f6 4534 0175 05c7 4420 ....L( .E4.u..D trailing whitespace

https://review.coreboot.org/#/c/31944/5/pci1002%2C990b.rom.txt@945 PS5, Line 945: 00003b00: 0175 0333 ffc3 5653 33ff e86c fb8b 5c20 .u.3..VS3..l..\ trailing whitespace

https://review.coreboot.org/#/c/31944/5/pci1002%2C990b.rom.txt@1359 PS5, Line 1359: 000054e0: 1f8c 4f08 8c47 108c 4f18 8c4f 1c8c 4f20 ..O..G..O..O..O trailing whitespace

https://review.coreboot.org/#/c/31944/5/pci1002%2C990b.rom.txt@1514 PS5, Line 1514: 00005e90: 268a 6737 b540 6633 c0eb 0666 b820 0720 &.g7.@f3...f. . trailing whitespace

https://review.coreboot.org/#/c/31944/5/pci1002%2C990b.rom.txt@1607 PS5, Line 1607: 00006460: 282c 0c11 252a 141e 3236 0f13 272c 1b20 (,..%*..26..',. trailing whitespace

https://review.coreboot.org/#/c/31944/5/pci1002%2C990b.rom.txt@2230 PS5, Line 2230: 00008b50: f3a5 13c9 f3a4 8aca 2bf1 2bf9 81c6 0020 ........+.+.... trailing whitespace

https://review.coreboot.org/#/c/31944/5/pci1002%2C990b.rom.txt@2254 PS5, Line 2254: 00008cd0: 80d2 ecc3 e8f0 fcec c3e8 f8ff b2c0 b020 ............... trailing whitespace

https://review.coreboot.org/#/c/31944/5/pci1002%2C990b.rom.txt@2515 PS5, Line 2515: 00009d20: c580 7401 468b cbf3 a483 fb20 7407 b920 ..t.F...... t.. trailing whitespace

https://review.coreboot.org/#/c/31944/5/pci1002%2C990b.rom.txt@3339 PS5, Line 3339: 0000d0a0: ffff ff08 2000 0024 3088 8303 0406 0020 .... ..$0...... trailing whitespace

https://review.coreboot.org/#/c/31944/5/pci1002%2C990b.rom.txt@3474 PS5, Line 3474: 0000d910: ffff ff1e 2100 001e 2200 0320 2100 2620 ....!...".. !.& trailing whitespace

https://review.coreboot.org/#/c/31944/5/pci1002%2C990b.rom.txt@3522 PS5, Line 3522: 0000dc10: 3418 0251 0154 0034 1854 003b 185b 7a20 4..Q.T.4.T.;.[z trailing whitespace

https://review.coreboot.org/#/c/31944/5/pci1002%2C990b.rom.txt@3723 PS5, Line 3723: 0000e8a0: 0f62 4041 3703 0001 0a05 2040 0d25 0820 .b@A7..... @.%. trailing whitespace

https://review.coreboot.org/#/c/31944/5/pci1002%2C990b.rom.txt@3819 PS5, Line 3819: 0000eea0: 0840 1540 1540 1540 1509 2020 2020 2020 .@.@.@.@.. trailing whitespace

https://review.coreboot.org/#/c/31944/5/pci1002%2C990b.rom.txt@3825 PS5, Line 3825: 0000ef00: 0008 4015 4015 4015 4015 0920 2020 2020 ..@.@.@.@.. trailing whitespace

https://review.coreboot.org/#/c/31944/5/pci1002%2C990c.rom.txt File pci1002,990c.rom.txt:

https://review.coreboot.org/#/c/31944/5/pci1002%2C990c.rom.txt@13 PS5, Line 13: 000000c0: 2f20 2020 2020 2020 2020 2020 2020 2020 / trailing whitespace

https://review.coreboot.org/#/c/31944/5/pci1002%2C990c.rom.txt@14 PS5, Line 14: 000000d0: 2020 2020 2020 2020 2020 2020 2020 2020 trailing whitespace

https://review.coreboot.org/#/c/31944/5/pci1002%2C990c.rom.txt@15 PS5, Line 15: 000000e0: 2020 2020 2020 2020 2020 2020 2020 2020 trailing whitespace

https://review.coreboot.org/#/c/31944/5/pci1002%2C990c.rom.txt@23 PS5, Line 23: 00000160: 3636 2e31 0032 3532 3735 3620 2000 2020 66.1.252756 . trailing whitespace

https://review.coreboot.org/#/c/31944/5/pci1002%2C990c.rom.txt@29 PS5, Line 29: 000001c0: 0000 0003 7900 1f0f 0080 0000 414d 4420 ....y.......AMD trailing whitespace

https://review.coreboot.org/#/c/31944/5/pci1002%2C990c.rom.txt@434 PS5, Line 434: 00001b10: 2224 70c0 e804 8ae8 e85b ff59 5f5d c320 "$p......[.Y_]. trailing whitespace

https://review.coreboot.org/#/c/31944/5/pci1002%2C990c.rom.txt@638 PS5, Line 638: 000027d0: 032a fbc0 e303 8aeb 80fb 1872 0380 cd20 .*.........r... trailing whitespace

https://review.coreboot.org/#/c/31944/5/pci1002%2C990c.rom.txt@713 PS5, Line 713: 00002c80: ca40 8d9c 5803 e840 11a8 0274 0380 ca20 .@..X..@...t... trailing whitespace

https://review.coreboot.org/#/c/31944/5/pci1002%2C990c.rom.txt@907 PS5, Line 907: 000038a0: 0a66 83e8 20e8 effd 6689 4404 c744 0820 .f.. ...f.D..D. trailing whitespace

https://review.coreboot.org/#/c/31944/5/pci1002%2C990c.rom.txt@930 PS5, Line 930: 00003a10: 10eb 0480 4c28 20f6 4534 0175 05c7 4420 ....L( .E4.u..D trailing whitespace

https://review.coreboot.org/#/c/31944/5/pci1002%2C990c.rom.txt@945 PS5, Line 945: 00003b00: 0175 0333 ffc3 5653 33ff e86c fb8b 5c20 .u.3..VS3..l..\ trailing whitespace

https://review.coreboot.org/#/c/31944/5/pci1002%2C990c.rom.txt@1359 PS5, Line 1359: 000054e0: 1f8c 4f08 8c47 108c 4f18 8c4f 1c8c 4f20 ..O..G..O..O..O trailing whitespace

https://review.coreboot.org/#/c/31944/5/pci1002%2C990c.rom.txt@1514 PS5, Line 1514: 00005e90: 268a 6737 b540 6633 c0eb 0666 b820 0720 &.g7.@f3...f. . trailing whitespace

https://review.coreboot.org/#/c/31944/5/pci1002%2C990c.rom.txt@1607 PS5, Line 1607: 00006460: 282c 0c11 252a 141e 3236 0f13 272c 1b20 (,..%*..26..',. trailing whitespace

https://review.coreboot.org/#/c/31944/5/pci1002%2C990c.rom.txt@2230 PS5, Line 2230: 00008b50: f3a5 13c9 f3a4 8aca 2bf1 2bf9 81c6 0020 ........+.+.... trailing whitespace

https://review.coreboot.org/#/c/31944/5/pci1002%2C990c.rom.txt@2254 PS5, Line 2254: 00008cd0: 80d2 ecc3 e8f0 fcec c3e8 f8ff b2c0 b020 ............... trailing whitespace

https://review.coreboot.org/#/c/31944/5/pci1002%2C990c.rom.txt@2515 PS5, Line 2515: 00009d20: c580 7401 468b cbf3 a483 fb20 7407 b920 ..t.F...... t.. trailing whitespace

https://review.coreboot.org/#/c/31944/5/pci1002%2C990c.rom.txt@3339 PS5, Line 3339: 0000d0a0: ffff ff08 2000 0024 3088 8303 0406 0020 .... ..$0...... trailing whitespace

https://review.coreboot.org/#/c/31944/5/pci1002%2C990c.rom.txt@3474 PS5, Line 3474: 0000d910: ffff ff1e 2100 001e 2200 0320 2100 2620 ....!...".. !.& trailing whitespace

https://review.coreboot.org/#/c/31944/5/pci1002%2C990c.rom.txt@3522 PS5, Line 3522: 0000dc10: 3418 0251 0154 0034 1854 003b 185b 7a20 4..Q.T.4.T.;.[z trailing whitespace

https://review.coreboot.org/#/c/31944/5/pci1002%2C990c.rom.txt@3723 PS5, Line 3723: 0000e8a0: 0f62 4041 3703 0001 0a05 2040 0d25 0820 .b@A7..... @.%. trailing whitespace

https://review.coreboot.org/#/c/31944/5/pci1002%2C990c.rom.txt@3819 PS5, Line 3819: 0000eea0: 0840 1540 1540 1540 1509 2020 2020 2020 .@.@.@.@.. trailing whitespace

https://review.coreboot.org/#/c/31944/5/pci1002%2C990c.rom.txt@3825 PS5, Line 3825: 0000ef00: 0008 4015 4015 4015 4015 0920 2020 2020 ..@.@.@.@.. trailing whitespace

-- To view, visit https://review.coreboot.org/c/coreboot/+/31944 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I0cb38927e3f5ae0f0850ca8bc79be791c51ae503 Gerrit-Change-Number: 31944 Gerrit-PatchSet: 5 Gerrit-Owner: Mike Banon mikebdp2@gmail.com Gerrit-Reviewer: Mike Banon mikebdp2@gmail.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-Comment-Date: Sun, 19 May 2019 11:24:10 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

Patrick Rudolph (Code Review)

4:49 a.m.

Patrick Rudolph has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31944 )

Change subject: G505S AtomBIOS ROMs: known good binaries with a script to check their SHA256 ......................................................................

Patch Set 5: Code-Review-2

As that those might violate Copyright. Please proof that they don't.

-- To view, visit https://review.coreboot.org/c/coreboot/+/31944 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I0cb38927e3f5ae0f0850ca8bc79be791c51ae503 Gerrit-Change-Number: 31944 Gerrit-PatchSet: 5 Gerrit-Owner: Mike Banon mikebdp2@gmail.com Gerrit-Reviewer: Mike Banon mikebdp2@gmail.com Gerrit-Reviewer: Patrick Rudolph siro@das-labor.org Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-Comment-Date: Sun, 19 May 2019 11:49:36 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

Mike Banon (Code Review)

5:39 a.m.

Mike Banon has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31944 )

Change subject: G505S AtomBIOS ROMs: known good binaries with a script to check their SHA256 ......................................................................

Patch Set 5:

Like with the new AMD microcodes (CB:28273 and CB:28370), these AtomBIOS binaries haven't been released officially yet and waiting here for the official release by AMD to get them merged to coreboot master. Currently we are in the talks with AMD, using these patches as the references, and hopefully this will happen soon: there is already a real progress regarding the microcodes, although these matters are advancing slowly... We have also submitted them to Techpowerup's huge Video BIOS collection here - https://www.techpowerup.com/vgabios/ , although it will take some time for them to appear at their database.

-- To view, visit https://review.coreboot.org/c/coreboot/+/31944 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I0cb38927e3f5ae0f0850ca8bc79be791c51ae503 Gerrit-Change-Number: 31944 Gerrit-PatchSet: 5 Gerrit-Owner: Mike Banon mikebdp2@gmail.com Gerrit-Reviewer: Mike Banon mikebdp2@gmail.com Gerrit-Reviewer: Patrick Rudolph siro@das-labor.org Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-Comment-Date: Sun, 19 May 2019 12:39:27 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment

build bot (Jenkins) (Code Review)

9 Jun 9 Jun

11:52 p.m.

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31944 )

Change subject: G505S AtomBIOS ROMs: known good binaries with a script to check their SHA256 ......................................................................

Patch Set 6:

(96 comments)

https://review.coreboot.org/#/c/31944/6/check_atombios_roms.sh File check_atombios_roms.sh:

https://review.coreboot.org/#/c/31944/6/check_atombios_roms.sh@10 PS6, Line 10: echo "SHA256 checksums are correct. Use these AtomBIOS ROMs at your coreboot .config :" line over 80 characters

https://review.coreboot.org/#/c/31944/6/check_atombios_roms.sh@12 PS6, Line 12: echo "*990b.rom = iGPU HD-8650G | *6663.rom = dGPU HD-8570M / *6665.rom = dGPU R5-M230" line over 80 characters

https://review.coreboot.org/#/c/31944/6/check_atombios_roms.sh@13 PS6, Line 13: echo "ASUS AM1I-A with Athlon-5370 APU installed: *9830.rom = iGPU HD-8400 / R3-Series" line over 80 characters

https://review.coreboot.org/#/c/31944/6/check_atombios_roms.sh@17 PS6, Line 17: echo "! MISMATCH ! See ./sha256sums_atombios_my.txt and ./sha256sums_atombios_correct.txt" line over 80 characters

https://review.coreboot.org/#/c/31944/6/pci1002%2C6663.rom.txt File pci1002,6663.rom.txt:

https://review.coreboot.org/#/c/31944/6/pci1002%2C6663.rom.txt@10 PS6, Line 10: 00000090: 1e3e 7800 80b8 5840 2c0d a500 00c6 cc20 .>x...X@,...... trailing whitespace

https://review.coreboot.org/#/c/31944/6/pci1002%2C6663.rom.txt@19 PS6, Line 19: 00000120: 6368 6c61 6e64 2020 2020 2020 2020 2020 chland trailing whitespace

https://review.coreboot.org/#/c/31944/6/pci1002%2C6663.rom.txt@20 PS6, Line 20: 00000130: 2020 2020 2020 2020 2020 2020 2020 2020 trailing whitespace

https://review.coreboot.org/#/c/31944/6/pci1002%2C6663.rom.txt@332 PS6, Line 332: 000014b0: 2366 25ff ff00 0066 3bc8 7321 32db eb20 #f%....f;.s!2.. trailing whitespace

https://review.coreboot.org/#/c/31944/6/pci1002%2C6663.rom.txt@372 PS6, Line 372: 00001730: 8acd b502 e801 1db1 028d 9c48 01e8 b520 ...........H... trailing whitespace

https://review.coreboot.org/#/c/31944/6/pci1002%2C6663.rom.txt@418 PS6, Line 418: 00001a10: 1e24 70c0 e804 8ae8 e85b ff59 5f5d c320 .$p......[.Y_]. trailing whitespace

https://review.coreboot.org/#/c/31944/6/pci1002%2C6663.rom.txt@457 PS6, Line 457: 00001c80: 0ac0 7526 8d9c 4c01 66b8 c409 0000 e820 ..u&..L.f...... trailing whitespace

https://review.coreboot.org/#/c/31944/6/pci1002%2C6663.rom.txt@621 PS6, Line 621: 000026c0: 032a fbc0 e303 8aeb 80fb 1872 0380 cd20 .*.........r... trailing whitespace

https://review.coreboot.org/#/c/31944/6/pci1002%2C6663.rom.txt@872 PS6, Line 872: 00003670: 015e c332 c0c3 6650 532e 8b1e 1602 b220 .^.2..fPS...... trailing whitespace

https://review.coreboot.org/#/c/31944/6/pci1002%2C6663.rom.txt@1271 PS6, Line 1271: 00004f60: 1f8c 4f08 8c47 108c 4f18 8c4f 1c8c 4f20 ..O..G..O..O..O trailing whitespace

https://review.coreboot.org/#/c/31944/6/pci1002%2C6663.rom.txt@1544 PS6, Line 1544: 00006070: ff00 0002 0000 0000 0030 7500 3075 0020 .........0u.0u. trailing whitespace

https://review.coreboot.org/#/c/31944/6/pci1002%2C6663.rom.txt@1549 PS6, Line 1549: 000060c0: 0300 0000 0000 0000 0030 7500 3075 0020 .........0u.0u. trailing whitespace

https://review.coreboot.org/#/c/31944/6/pci1002%2C6663.rom.txt@1571 PS6, Line 1571: 00006220: 910a 0820 0000 0392 0a09 2600 0103 0420 ... ......&.... trailing whitespace

https://review.coreboot.org/#/c/31944/6/pci1002%2C6663.rom.txt@1658 PS6, Line 1658: 00006790: 8c04 0100 cdd0 3010 0000 0000 0821 4420 ......0......!D trailing whitespace

https://review.coreboot.org/#/c/31944/6/pci1002%2C6663.rom.txt@1686 PS6, Line 1686: 00006950: 141e 0640 2080 00c0 0000 0000 0d0d 2020 ...@ ......... trailing whitespace

https://review.coreboot.org/#/c/31944/6/pci1002%2C6663.rom.txt@1729 PS6, Line 1729: 00006c00: 4080 1020 9d03 4000 1020 b603 4080 0020 @.. ..@.. ..@.. trailing whitespace

https://review.coreboot.org/#/c/31944/6/pci1002%2C6663.rom.txt@2010 PS6, Line 2010: 00007d90: ffff ff00 2105 410a 0000 0056 0041 0320 ....!.A....V.A. trailing whitespace

https://review.coreboot.org/#/c/31944/6/pci1002%2C6663.rom.txt@2094 PS6, Line 2094: 000082d0: 6480 0a1c 0001 2480 0a1d 000d 2580 0a20 d.....$.....%.. trailing whitespace

https://review.coreboot.org/#/c/31944/6/pci1002%2C6665.rom.txt File pci1002,6665.rom.txt:

https://review.coreboot.org/#/c/31944/6/pci1002%2C6665.rom.txt@10 PS6, Line 10: 00000090: 1e3e 7800 80b8 5840 2c0d a501 00c6 cc20 .>x...X@,...... trailing whitespace

https://review.coreboot.org/#/c/31944/6/pci1002%2C6665.rom.txt@19 PS6, Line 19: 00000120: 6e64 2020 2020 2020 2020 2020 2020 2020 nd trailing whitespace

https://review.coreboot.org/#/c/31944/6/pci1002%2C6665.rom.txt@20 PS6, Line 20: 00000130: 2020 2020 2020 2020 2020 2020 2020 2020 trailing whitespace

https://review.coreboot.org/#/c/31944/6/pci1002%2C6665.rom.txt@36 PS6, Line 36: 00000230: 0000 8003 4000 290f 0080 0000 414d 4420 ....@.).....AMD trailing whitespace

https://review.coreboot.org/#/c/31944/6/pci1002%2C6665.rom.txt@542 PS6, Line 542: 000021d0: b822 06e8 eeff c3b8 3f06 e8e7 ffc3 b820 ."......?...... trailing whitespace

https://review.coreboot.org/#/c/31944/6/pci1002%2C6665.rom.txt@756 PS6, Line 756: 00002f30: fa15 7507 b501 bb18 00eb 0b80 fa14 7520 ..u...........u trailing whitespace

https://review.coreboot.org/#/c/31944/6/pci1002%2C6665.rom.txt@1487 PS6, Line 1487: 00005ce0: 0000 0000 00c3 0100 0000 0006 3075 0020 ............0u. trailing whitespace

https://review.coreboot.org/#/c/31944/6/pci1002%2C6665.rom.txt@1659 PS6, Line 1659: 000067a0: 4000 1020 b603 4080 0020 cf03 4000 0020 @.. ..@.. ..@.. trailing whitespace

https://review.coreboot.org/#/c/31944/6/pci1002%2C6665.rom.txt@1702 PS6, Line 1702: 00006a50: 0324 4114 0015 0541 0601 0a0a 1541 0320 .$A....A.....A. trailing whitespace

https://review.coreboot.org/#/c/31944/6/pci1002%2C6665.rom.txt@1726 PS6, Line 1726: 00006bd0: 5044 0828 0040 3071 0920 0800 0075 0920 PD.(.@0q. ...u. trailing whitespace

https://review.coreboot.org/#/c/31944/6/pci1002%2C6665.rom.txt@1780 PS6, Line 1780: 00006f30: 1f49 0e00 0725 eb09 fe01 252b 0801 5420 .I...%....%+..T trailing whitespace

https://review.coreboot.org/#/c/31944/6/pci1002%2C6665.rom.txt@1823 PS6, Line 1823: 000071e0: 0125 f705 015b 7a28 0025 0000 0049 2020 .%...[z(.%...I trailing whitespace

https://review.coreboot.org/#/c/31944/6/pci1002%2C6665.rom.txt@2025 PS6, Line 2025: 00007e80: 6480 0a1c 0001 2480 0a1d 000d 2580 0a20 d.....$.....%.. trailing whitespace

https://review.coreboot.org/#/c/31944/6/pci1002%2C9830.rom.txt File pci1002,9830.rom.txt:

https://review.coreboot.org/#/c/31944/6/pci1002%2C9830.rom.txt@13 PS6, Line 13: 000000c0: 6572 6963 2056 4249 4f53 2020 2020 2020 eric VBIOS trailing whitespace

https://review.coreboot.org/#/c/31944/6/pci1002%2C9830.rom.txt@14 PS6, Line 14: 000000d0: 2020 2020 2020 2020 2020 2020 2020 2020 trailing whitespace

https://review.coreboot.org/#/c/31944/6/pci1002%2C9830.rom.txt@15 PS6, Line 15: 000000e0: 2020 2020 2020 2020 2020 2020 2020 2020 trailing whitespace

https://review.coreboot.org/#/c/31944/6/pci1002%2C9830.rom.txt@125 PS6, Line 125: 000007c0: 0a2c 46fe c975 f48a c559 c302 0104 0820 .,F..u...Y..... trailing whitespace

https://review.coreboot.org/#/c/31944/6/pci1002%2C9830.rom.txt@229 PS6, Line 229: 00000e40: c3bb 0600 e87d 248a c880 e110 d0e9 a820 .....}$........ trailing whitespace

https://review.coreboot.org/#/c/31944/6/pci1002%2C9830.rom.txt@292 PS6, Line 292: 00001230: 741b e8fb 04e8 1b20 7408 8b56 04e8 1320 t...... t..V... trailing whitespace

https://review.coreboot.org/#/c/31944/6/pci1002%2C9830.rom.txt@773 PS6, Line 773: 00003040: 7d32 c080 ee21 80fa 1e74 15b0 0280 fa20 }2...!...t..... trailing whitespace

https://review.coreboot.org/#/c/31944/6/pci1002%2C9830.rom.txt@1010 PS6, Line 1010: 00003f10: fe8c d08e c026 8b7c 268a 4501 32e4 b920 .....&.|&.E.2.. trailing whitespace

https://review.coreboot.org/#/c/31944/6/pci1002%2C9830.rom.txt@1483 PS6, Line 1483: 00005ca0: 1f53 66bb 401c 001c e8f0 c4be 001c b020 .Sf.@.......... trailing whitespace

https://review.coreboot.org/#/c/31944/6/pci1002%2C9830.rom.txt@2270 PS6, Line 2270: 00008dd0: c32e 8e1e 1503 890e 6004 8ac5 2460 a820 ........`...$`. trailing whitespace

https://review.coreboot.org/#/c/31944/6/pci1002%2C9830.rom.txt@2918 PS6, Line 2918: 0000b650: 0002 0000 f03f 1040 0001 0411 1101 0020 .....?.@....... trailing whitespace

https://review.coreboot.org/#/c/31944/6/pci1002%2C9830.rom.txt@2966 PS6, Line 2966: 0000b950: 013a c900 4115 0541 0801 02c4 0041 5420 .:..A..A.....AT trailing whitespace

https://review.coreboot.org/#/c/31944/6/pci1002%2C9830.rom.txt@3199 PS6, Line 3199: 0000c7e0: 001a 010d e5b3 1b10 5ca2 b31b ef40 5420 ............@T trailing whitespace

https://review.coreboot.org/#/c/31944/6/pci1002%2C9830.rom.txt@3329 PS6, Line 3329: 0000d000: 0046 4ce5 4110 497f 0404 a500 4a3b 0520 .FL.A.I.....J;. trailing whitespace

https://review.coreboot.org/#/c/31944/6/pci1002%2C9830.rom.txt@3365 PS6, Line 3365: 0000d240: 0001 b400 0000 dc00 0000 dd00 0001 9120 ............... trailing whitespace

https://review.coreboot.org/#/c/31944/6/pci1002%2C990b.rom.txt File pci1002,990b.rom.txt:

https://review.coreboot.org/#/c/31944/6/pci1002%2C990b.rom.txt@13 PS6, Line 13: 000000c0: 2f20 2020 2020 2020 2020 2020 2020 2020 / trailing whitespace

https://review.coreboot.org/#/c/31944/6/pci1002%2C990b.rom.txt@14 PS6, Line 14: 000000d0: 2020 2020 2020 2020 2020 2020 2020 2020 trailing whitespace

https://review.coreboot.org/#/c/31944/6/pci1002%2C990b.rom.txt@15 PS6, Line 15: 000000e0: 2020 2020 2020 2020 2020 2020 2020 2020 trailing whitespace

https://review.coreboot.org/#/c/31944/6/pci1002%2C990b.rom.txt@23 PS6, Line 23: 00000160: 3636 2e31 0032 3532 3735 3620 2000 2020 66.1.252756 . trailing whitespace

https://review.coreboot.org/#/c/31944/6/pci1002%2C990b.rom.txt@29 PS6, Line 29: 000001c0: 0000 0003 7900 1f0f 0080 0000 414d 4420 ....y.......AMD trailing whitespace

https://review.coreboot.org/#/c/31944/6/pci1002%2C990b.rom.txt@434 PS6, Line 434: 00001b10: 2224 70c0 e804 8ae8 e85b ff59 5f5d c320 "$p......[.Y_]. trailing whitespace

https://review.coreboot.org/#/c/31944/6/pci1002%2C990b.rom.txt@638 PS6, Line 638: 000027d0: 032a fbc0 e303 8aeb 80fb 1872 0380 cd20 .*.........r... trailing whitespace

https://review.coreboot.org/#/c/31944/6/pci1002%2C990b.rom.txt@713 PS6, Line 713: 00002c80: ca40 8d9c 5803 e840 11a8 0274 0380 ca20 .@..X..@...t... trailing whitespace

https://review.coreboot.org/#/c/31944/6/pci1002%2C990b.rom.txt@907 PS6, Line 907: 000038a0: 0a66 83e8 20e8 effd 6689 4404 c744 0820 .f.. ...f.D..D. trailing whitespace

https://review.coreboot.org/#/c/31944/6/pci1002%2C990b.rom.txt@930 PS6, Line 930: 00003a10: 10eb 0480 4c28 20f6 4534 0175 05c7 4420 ....L( .E4.u..D trailing whitespace

https://review.coreboot.org/#/c/31944/6/pci1002%2C990b.rom.txt@945 PS6, Line 945: 00003b00: 0175 0333 ffc3 5653 33ff e86c fb8b 5c20 .u.3..VS3..l..\ trailing whitespace

https://review.coreboot.org/#/c/31944/6/pci1002%2C990b.rom.txt@1359 PS6, Line 1359: 000054e0: 1f8c 4f08 8c47 108c 4f18 8c4f 1c8c 4f20 ..O..G..O..O..O trailing whitespace

https://review.coreboot.org/#/c/31944/6/pci1002%2C990b.rom.txt@1514 PS6, Line 1514: 00005e90: 268a 6737 b540 6633 c0eb 0666 b820 0720 &.g7.@f3...f. . trailing whitespace

https://review.coreboot.org/#/c/31944/6/pci1002%2C990b.rom.txt@1607 PS6, Line 1607: 00006460: 282c 0c11 252a 141e 3236 0f13 272c 1b20 (,..%*..26..',. trailing whitespace

https://review.coreboot.org/#/c/31944/6/pci1002%2C990b.rom.txt@2230 PS6, Line 2230: 00008b50: f3a5 13c9 f3a4 8aca 2bf1 2bf9 81c6 0020 ........+.+.... trailing whitespace

https://review.coreboot.org/#/c/31944/6/pci1002%2C990b.rom.txt@2254 PS6, Line 2254: 00008cd0: 80d2 ecc3 e8f0 fcec c3e8 f8ff b2c0 b020 ............... trailing whitespace

https://review.coreboot.org/#/c/31944/6/pci1002%2C990b.rom.txt@2515 PS6, Line 2515: 00009d20: c580 7401 468b cbf3 a483 fb20 7407 b920 ..t.F...... t.. trailing whitespace

https://review.coreboot.org/#/c/31944/6/pci1002%2C990b.rom.txt@3339 PS6, Line 3339: 0000d0a0: ffff ff08 2000 0024 3088 8303 0406 0020 .... ..$0...... trailing whitespace

https://review.coreboot.org/#/c/31944/6/pci1002%2C990b.rom.txt@3474 PS6, Line 3474: 0000d910: ffff ff1e 2100 001e 2200 0320 2100 2620 ....!...".. !.& trailing whitespace

https://review.coreboot.org/#/c/31944/6/pci1002%2C990b.rom.txt@3522 PS6, Line 3522: 0000dc10: 3418 0251 0154 0034 1854 003b 185b 7a20 4..Q.T.4.T.;.[z trailing whitespace

https://review.coreboot.org/#/c/31944/6/pci1002%2C990b.rom.txt@3723 PS6, Line 3723: 0000e8a0: 0f62 4041 3703 0001 0a05 2040 0d25 0820 .b@A7..... @.%. trailing whitespace

https://review.coreboot.org/#/c/31944/6/pci1002%2C990b.rom.txt@3819 PS6, Line 3819: 0000eea0: 0840 1540 1540 1540 1509 2020 2020 2020 .@.@.@.@.. trailing whitespace

https://review.coreboot.org/#/c/31944/6/pci1002%2C990b.rom.txt@3825 PS6, Line 3825: 0000ef00: 0008 4015 4015 4015 4015 0920 2020 2020 ..@.@.@.@.. trailing whitespace

https://review.coreboot.org/#/c/31944/6/pci1002%2C990c.rom.txt File pci1002,990c.rom.txt:

https://review.coreboot.org/#/c/31944/6/pci1002%2C990c.rom.txt@13 PS6, Line 13: 000000c0: 2f20 2020 2020 2020 2020 2020 2020 2020 / trailing whitespace

https://review.coreboot.org/#/c/31944/6/pci1002%2C990c.rom.txt@14 PS6, Line 14: 000000d0: 2020 2020 2020 2020 2020 2020 2020 2020 trailing whitespace

https://review.coreboot.org/#/c/31944/6/pci1002%2C990c.rom.txt@15 PS6, Line 15: 000000e0: 2020 2020 2020 2020 2020 2020 2020 2020 trailing whitespace

https://review.coreboot.org/#/c/31944/6/pci1002%2C990c.rom.txt@23 PS6, Line 23: 00000160: 3636 2e31 0032 3532 3735 3620 2000 2020 66.1.252756 . trailing whitespace

https://review.coreboot.org/#/c/31944/6/pci1002%2C990c.rom.txt@29 PS6, Line 29: 000001c0: 0000 0003 7900 1f0f 0080 0000 414d 4420 ....y.......AMD trailing whitespace

https://review.coreboot.org/#/c/31944/6/pci1002%2C990c.rom.txt@434 PS6, Line 434: 00001b10: 2224 70c0 e804 8ae8 e85b ff59 5f5d c320 "$p......[.Y_]. trailing whitespace

https://review.coreboot.org/#/c/31944/6/pci1002%2C990c.rom.txt@638 PS6, Line 638: 000027d0: 032a fbc0 e303 8aeb 80fb 1872 0380 cd20 .*.........r... trailing whitespace

https://review.coreboot.org/#/c/31944/6/pci1002%2C990c.rom.txt@713 PS6, Line 713: 00002c80: ca40 8d9c 5803 e840 11a8 0274 0380 ca20 .@..X..@...t... trailing whitespace

https://review.coreboot.org/#/c/31944/6/pci1002%2C990c.rom.txt@907 PS6, Line 907: 000038a0: 0a66 83e8 20e8 effd 6689 4404 c744 0820 .f.. ...f.D..D. trailing whitespace

https://review.coreboot.org/#/c/31944/6/pci1002%2C990c.rom.txt@930 PS6, Line 930: 00003a10: 10eb 0480 4c28 20f6 4534 0175 05c7 4420 ....L( .E4.u..D trailing whitespace

https://review.coreboot.org/#/c/31944/6/pci1002%2C990c.rom.txt@945 PS6, Line 945: 00003b00: 0175 0333 ffc3 5653 33ff e86c fb8b 5c20 .u.3..VS3..l..\ trailing whitespace

https://review.coreboot.org/#/c/31944/6/pci1002%2C990c.rom.txt@1359 PS6, Line 1359: 000054e0: 1f8c 4f08 8c47 108c 4f18 8c4f 1c8c 4f20 ..O..G..O..O..O trailing whitespace

https://review.coreboot.org/#/c/31944/6/pci1002%2C990c.rom.txt@1514 PS6, Line 1514: 00005e90: 268a 6737 b540 6633 c0eb 0666 b820 0720 &.g7.@f3...f. . trailing whitespace

https://review.coreboot.org/#/c/31944/6/pci1002%2C990c.rom.txt@1607 PS6, Line 1607: 00006460: 282c 0c11 252a 141e 3236 0f13 272c 1b20 (,..%*..26..',. trailing whitespace

https://review.coreboot.org/#/c/31944/6/pci1002%2C990c.rom.txt@2230 PS6, Line 2230: 00008b50: f3a5 13c9 f3a4 8aca 2bf1 2bf9 81c6 0020 ........+.+.... trailing whitespace

https://review.coreboot.org/#/c/31944/6/pci1002%2C990c.rom.txt@2254 PS6, Line 2254: 00008cd0: 80d2 ecc3 e8f0 fcec c3e8 f8ff b2c0 b020 ............... trailing whitespace

https://review.coreboot.org/#/c/31944/6/pci1002%2C990c.rom.txt@2515 PS6, Line 2515: 00009d20: c580 7401 468b cbf3 a483 fb20 7407 b920 ..t.F...... t.. trailing whitespace

https://review.coreboot.org/#/c/31944/6/pci1002%2C990c.rom.txt@3339 PS6, Line 3339: 0000d0a0: ffff ff08 2000 0024 3088 8303 0406 0020 .... ..$0...... trailing whitespace

https://review.coreboot.org/#/c/31944/6/pci1002%2C990c.rom.txt@3474 PS6, Line 3474: 0000d910: ffff ff1e 2100 001e 2200 0320 2100 2620 ....!...".. !.& trailing whitespace

https://review.coreboot.org/#/c/31944/6/pci1002%2C990c.rom.txt@3522 PS6, Line 3522: 0000dc10: 3418 0251 0154 0034 1854 003b 185b 7a20 4..Q.T.4.T.;.[z trailing whitespace

https://review.coreboot.org/#/c/31944/6/pci1002%2C990c.rom.txt@3723 PS6, Line 3723: 0000e8a0: 0f62 4041 3703 0001 0a05 2040 0d25 0820 .b@A7..... @.%. trailing whitespace

https://review.coreboot.org/#/c/31944/6/pci1002%2C990c.rom.txt@3819 PS6, Line 3819: 0000eea0: 0840 1540 1540 1540 1509 2020 2020 2020 .@.@.@.@.. trailing whitespace

https://review.coreboot.org/#/c/31944/6/pci1002%2C990c.rom.txt@3825 PS6, Line 3825: 0000ef00: 0008 4015 4015 4015 4015 0920 2020 2020 ..@.@.@.@.. trailing whitespace

-- To view, visit https://review.coreboot.org/c/coreboot/+/31944 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I0cb38927e3f5ae0f0850ca8bc79be791c51ae503 Gerrit-Change-Number: 31944 Gerrit-PatchSet: 6 Gerrit-Owner: Mike Banon mikebdp2@gmail.com Gerrit-Reviewer: Mike Banon mikebdp2@gmail.com Gerrit-Reviewer: Patrick Rudolph siro@das-labor.org Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-Comment-Date: Mon, 10 Jun 2019 06:52:38 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

Mike Banon (Code Review)

29 Jun 29 Jun

8:48 a.m.

Mike Banon has abandoned this change. ( https://review.coreboot.org/c/coreboot/+/31944 )

Change subject: G505S AtomBIOS ROMs: known good binaries with a script to check their SHA256 ......................................................................

Abandoned

Too many changes, need a fresh start.

-- To view, visit https://review.coreboot.org/c/coreboot/+/31944 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I0cb38927e3f5ae0f0850ca8bc79be791c51ae503 Gerrit-Change-Number: 31944 Gerrit-PatchSet: 6 Gerrit-Owner: Mike Banon mikebdp2@gmail.com Gerrit-Reviewer: Mike Banon mikebdp2@gmail.com Gerrit-Reviewer: Patrick Rudolph siro@das-labor.org Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-MessageType: abandon

1967

days inactive

2071

days old

coreboot-gerrit@coreboot.org

13 comments

4 participants

tags (0)

participants (4)

build bot (Jenkins) (Code Review)
Mike Banon (Code Review)
mikeb mikeb (Code Review)
Patrick Rudolph (Code Review)