Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39502 )
Change subject: mb/google/deltaur: add deltaur mainboard initial support
......................................................................
Patch Set 14:
Patch Set 14:
Patch Set 14:
Patch Set 13:
Hi Bora.
Can we add support to read SKU ID from EC(get_board_sku) in mainboard.c ? This is required for mosys feature to work. Please refer to patch https://chrome-internal-review.googlesource.com/c/chromeos/third_party/coreb...
I need to check how to get this for Wilco EC since we are not using chromeec. I think we need sku_info skus[] in drallion but I don't have this info right now. Lets push a separate patch.
You can refer my previous patch :) For ST we can report fixed SKU ID, for Daltan I think only two sku, signed and unsigned. I will create an issue for discuss this.
Let's make that a separate patch.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/39502
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ib98f328df22f39e7d9d625a3292954881ee15b15
Gerrit-Change-Number: 39502
Gerrit-PatchSet: 14
Gerrit-Owner: Bora Guvendik
bora.guvendik@intel.com
Gerrit-Reviewer: Cliff Huang
cliff.huang@intel.com
Gerrit-Reviewer: Duncan Laurie
dlaurie@chromium.org
Gerrit-Reviewer: EricR Lai
ericr_lai@compal.corp-partner.google.com
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Kevin Chowski
chowski@google.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Selma Bensaid
selma.bensaid@intel.com
Gerrit-Reviewer: Subrata Banik
subrata.banik@intel.com
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Angel Pons
th3fanbus@gmail.com
Gerrit-CC: Anil Kumar K
anil.kumar.k@intel.com
Gerrit-CC: Bernardo Perez Priego
bernardo.perez.priego@intel.com
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-CC: Selma Bensaid
selma.bensaid@intel.corp-partner.google.com
Gerrit-CC: Varun Joshi
varun.joshi@intel.com
Gerrit-Comment-Date: Wed, 25 Mar 2020 16:11:42 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment