Attention is currently required from: Furquan Shaikh, Aseda Aboagye, Julius Werner, Karthik Ramasubramanian.
Raul Rangel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/56577 )
Change subject: lib/cbfs: Enable cbfs_cache for x86
......................................................................
Patch Set 5:
(1 comment)
Patchset:
PS3:
I'm not very familiar with x86, but it sounds bad? I assume cli is clear interrupts, but `lgdtl` is […]
That's not too bad, it's only ran on ramstage start so we should never execute that code again.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/56577
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I74434ef9250ff059e7587147b1456aeabbee33aa
Gerrit-Change-Number: 56577
Gerrit-PatchSet: 5
Gerrit-Owner: Raul Rangel
rrangel@chromium.org
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Julius Werner
jwerner@chromium.org
Gerrit-Reviewer: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Aseda Aboagye
aaboagye@google.com
Gerrit-CC: Felix Held
felix-coreboot@felixheld.de
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Furquan Shaikh
furquan@google.com
Gerrit-Attention: Aseda Aboagye
aaboagye@google.com
Gerrit-Attention: Julius Werner
jwerner@chromium.org
Gerrit-Attention: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Comment-Date: Thu, 21 Oct 2021 22:44:18 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Raul Rangel
rrangel@chromium.org
Comment-In-Reply-To: Aseda Aboagye
aaboagye@google.com
Comment-In-Reply-To: Julius Werner
jwerner@chromium.org
Gerrit-MessageType: comment