Attention is currently required from: Subrata Banik, Christian Walter, Julius Werner, Felix Held.
Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/61976 )
Change subject: drivers/tpm/spi: Convert static functions to enum cb_err return types
......................................................................
Patch Set 6:
(2 comments)
File src/drivers/spi/tpm/tpm.c:
https://review.coreboot.org/c/coreboot/+/61976/comment/b8d46c2a_fa628590
PS6, Line 656: int
enum cb_err can be used instead; the call site also needs to be adapted
Done
https://review.coreboot.org/c/coreboot/+/61976/comment/fa8576f3_db7342e7
PS6, Line 667: false
this doesn't match the return type
Done
--
To view, visit
https://review.coreboot.org/c/coreboot/+/61976
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ifb749c931fe008b16d42fcf157af820ec8fbf5ac
Gerrit-Change-Number: 61976
Gerrit-PatchSet: 6
Gerrit-Owner: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: Christian Walter
christian.walter@9elements.com
Gerrit-Reviewer: Julius Werner
jwerner@chromium.org
Gerrit-Reviewer: Subrata Banik
subratabanik@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Felix Held
felix-coreboot@felixheld.de
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Subrata Banik
subratabanik@google.com
Gerrit-Attention: Christian Walter
christian.walter@9elements.com
Gerrit-Attention: Julius Werner
jwerner@chromium.org
Gerrit-Attention: Felix Held
felix-coreboot@felixheld.de
Gerrit-Comment-Date: Mon, 28 Feb 2022 15:43:31 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Felix Held
felix-coreboot@felixheld.de
Gerrit-MessageType: comment