Attention is currently required from: Tarun Tuli, Subrata Banik, Dinesh Gehlot.
build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/74256 )
Change subject: soc/intel/: Store CSE firmware version into cbmem table
......................................................................
Patch Set 2: Verified-1
(1 comment)
File src/soc/intel/common/block/cse/cse_lite.c:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-173773):
https://review.coreboot.org/c/coreboot/+/74256/comment/8dc1c68c_6d00542b
PS2, Line 1087: if (!cse_get_bp_info(&cse_bp_info))
suspect code indent for conditional statements (8, 24)
--
To view, visit
https://review.coreboot.org/c/coreboot/+/74256
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I923049d2f1f589f87e1a29e1ac94af7f5fccc2c8
Gerrit-Change-Number: 74256
Gerrit-PatchSet: 2
Gerrit-Owner: Dinesh Gehlot
digehlot@google.com
Gerrit-Reviewer: Subrata Banik
subratabanik@google.com
Gerrit-Reviewer: Tarun Tuli
taruntuli@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Tarun Tuli
taruntuli@google.com
Gerrit-Attention: Subrata Banik
subratabanik@google.com
Gerrit-Attention: Dinesh Gehlot
digehlot@google.com
Gerrit-Comment-Date: Mon, 10 Apr 2023 08:58:24 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment