Attention is currently required from: Hung-Te Lin, Mengqi Zhang, Yidi Lin, Yu-Ping Wu.
Kiwi Liu has posted comments on this change by Kiwi Liu. ( https://review.coreboot.org/c/coreboot/+/84298?usp=email )
Change subject: UPSTREAM: soc/mediatek/common: Fix eMMC clock
......................................................................
Patch Set 3:
(3 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/84298/comment/a972f32a_009d2449?usp... :
PS1, Line 7: WIP:
Is this patch ready for review ?
Done
https://review.coreboot.org/c/coreboot/+/84298/comment/ea604c64_f56cf4cd?usp... :
PS1, Line 9: 2-3 MHz
MHz is used to describe the frequency not the interval.
Done
https://review.coreboot.org/c/coreboot/+/84298/comment/a27d24c0_ea0ec0a0?usp... :
PS1, Line 14: emerge-corsola coreboot
does it impact the boot time ?
Impact can be ignored, because only very few commands in coreboot.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/84298?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I9c8836b23fb21e9b0bdc80fbe85142ea0fa5e381
Gerrit-Change-Number: 84298
Gerrit-PatchSet: 3
Gerrit-Owner: Kiwi Liu
kiwi.liu@mediatek.corp-partner.google.com
Gerrit-Reviewer: Hung-Te Lin
hungte@chromium.org
Gerrit-Reviewer: Mengqi Zhang
mengqi.zhang@mediatek.corp-partner.google.com
Gerrit-Reviewer: Yidi Lin
yidilin@google.com
Gerrit-Reviewer: Yu-Ping Wu
yupingso@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Hung-Te Lin
hungte@chromium.org
Gerrit-Attention: Mengqi Zhang
mengqi.zhang@mediatek.corp-partner.google.com
Gerrit-Attention: Yidi Lin
yidilin@google.com
Gerrit-Attention: Yu-Ping Wu
yupingso@google.com
Gerrit-Comment-Date: Thu, 12 Sep 2024 00:52:19 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Yidi Lin
yidilin@google.com