Attention is currently required from: Hung-Te Lin, Kiwi Liu, Yu-Ping Wu.
Yidi Lin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/78801?usp=email )
Change subject: soc/mediatek/mt8188: Support loading BL32 image from rootfs
......................................................................
Patch Set 13:
(2 comments)
Patchset:
PS13:
Please resolve the comments
File src/soc/mediatek/mt8188/Makefile.inc:
https://review.coreboot.org/c/coreboot/+/78801/comment/2001eb94_3ab68064 :
PS13, Line 61: PLAT=mt8188 SPD=opteed OPTEE_ALLOW_SMC_LOAD=1 \
: PLAT_XLAT_TABLES_DYNAMIC=1 CROS_WIDEVINE_SMC=1
Is there any reason that the parameters should be in the same line ?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/78801?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Ic38c8beb59c090ae56c5be6821dd8625435609e9
Gerrit-Change-Number: 78801
Gerrit-PatchSet: 13
Gerrit-Owner: Kiwi Liu
kiwi.liu@mediatek.corp-partner.google.com
Gerrit-Reviewer: Hung-Te Lin
hungte@chromium.org
Gerrit-Reviewer: Yidi Lin
yidilin@google.com
Gerrit-Reviewer: Yu-Ping Wu
yupingso@google.com
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-CC: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Hung-Te Lin
hungte@chromium.org
Gerrit-Attention: Kiwi Liu
kiwi.liu@mediatek.corp-partner.google.com
Gerrit-Attention: Yu-Ping Wu
yupingso@google.com
Gerrit-Comment-Date: Fri, 03 Nov 2023 03:42:06 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment