Attention is currently required from: Sean Rhodes.
Michael Niewöhner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/72800 )
Change subject: soc/intel/{tgl,adl}: Hook up D3ColdEnable UPD to D3COLD_SUPPORT
......................................................................
Patch Set 8:
(1 comment)
File src/device/Kconfig:
https://review.coreboot.org/c/coreboot/+/72800/comment/75171c3a_9692ca83
PS4, Line 997: config NO_S0IX_SUPPORT
: bool "Don't support S0IX suspend"
: default n
: help
: Select if the board only supports S3 and/or S4 and not S0IX
:
: config D3COLD_SUPPORT
: bool "Don't support D3Cold"
: default n if NO_S0IX_SUPPORT
: default y
: help
: Select is any devices don't support D3Cold state
:
:
this change is doing more than just "hooking up", while the previous change, does not add these Kcon […]
sorry, I got confused by one of the older patch sets. ignore this one
--
To view, visit
https://review.coreboot.org/c/coreboot/+/72800
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I718952165daa6471f11e8025e745fe7c249d3b46
Gerrit-Change-Number: 72800
Gerrit-PatchSet: 8
Gerrit-Owner: Sean Rhodes
sean@starlabs.systems
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Christian Walter
christian.walter@9elements.com
Gerrit-Reviewer: Lean Sheng Tan
sheng.tan@9elements.com
Gerrit-Reviewer: Maximilian Brune
maximilian.brune@9elements.com
Gerrit-Reviewer: Subrata Banik
subratabanik@google.com
Gerrit-Reviewer: Tarun Tuli
taruntuli@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: 9elements QA
hardwaretestrobot@gmail.com
Gerrit-CC: Michael Niewöhner
foss@mniewoehner.de
Gerrit-Attention: Sean Rhodes
sean@starlabs.systems
Gerrit-Comment-Date: Fri, 07 Apr 2023 17:25:04 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Michael Niewöhner
foss@mniewoehner.de
Gerrit-MessageType: comment