Attention is currently required from: Maulik V Vaghela, Sugnan Prabhu S, Subrata Banik, Patrick Rudolph.
Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/59665 )
Change subject: drivers/intel/usb4/retimer: Add function to correct EC port mapping
......................................................................
Patch Set 6:
(2 comments)
File src/drivers/intel/usb4/retimer/retimer.h:
https://review.coreboot.org/c/coreboot/+/59665/comment/f1a2c2c9_aa75a14b
PS5, Line 42: map_physical_port_to_ec_port
I think keeping `retimer` in the name here is probably a good idea, just for context. I know it's already long... but WDYT about `retimer_get_index_for_type_c(uint8_t typec_port)`;
https://review.coreboot.org/c/coreboot/+/59665/comment/e624124d_a8aea3e5
PS5, Line 42: usb_port
since this really represents the Type-C ports, would naming this `typec_port` be more descriptive?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/59665
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ia7a5e63838e6529196bd211516e4d665b084f79e
Gerrit-Change-Number: 59665
Gerrit-PatchSet: 6
Gerrit-Owner: Maulik V Vaghela
maulik.v.vaghela@intel.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Subrata Banik
subrata.banik@intel.com
Gerrit-Reviewer: Sugnan Prabhu S
sugnan.prabhu.s@intel.com
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Maulik V Vaghela
maulik.v.vaghela@intel.com
Gerrit-Attention: Sugnan Prabhu S
sugnan.prabhu.s@intel.com
Gerrit-Attention: Subrata Banik
subrata.banik@intel.com
Gerrit-Attention: Patrick Rudolph
siro@das-labor.org
Gerrit-Comment-Date: Tue, 30 Nov 2021 23:21:44 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment