Matt DeVillier has submitted this change. ( https://review.coreboot.org/c/coreboot/+/86148?usp=email )
Change subject: util/crossgcc: Add missing printf variable ......................................................................
util/crossgcc: Add missing printf variable
Add the printing of the missing libstdcxx path in the warning string when the path check fails. Also resolve the use of the variable in the conditional statement by surrounding it with quotes.
BUG=None TEST=Build with invalid libstdcxx path
Change-Id: I195718e43ea842970f5fa986315c9e9f11395362 Signed-off-by: Jon Murphy jpmurphy@google.com Reviewed-on: https://review.coreboot.org/c/coreboot/+/86148 Reviewed-by: Karthik Ramasubramanian kramasub@google.com Tested-by: build bot (Jenkins) no-reply@coreboot.org --- M util/crossgcc/buildgcc 1 file changed, 2 insertions(+), 2 deletions(-)
Approvals: Karthik Ramasubramanian: Looks good to me, approved build bot (Jenkins): Verified
diff --git a/util/crossgcc/buildgcc b/util/crossgcc/buildgcc index 2d112eb..2ad98b8 100755 --- a/util/crossgcc/buildgcc +++ b/util/crossgcc/buildgcc @@ -856,9 +856,9 @@ }
build_LIBSTDCXX() { - if [ ! -e ${LIBSTDCXX_INCLUDE_PATH} ]; then + if [ ! -e "${LIBSTDCXX_INCLUDE_PATH}" ]; then touch .failed - printf "libstdcxx include path "%s" does not exist" + printf "libstdcxx include path "%s" does not exist" "${LIBSTDCXX_INCLUDE_PATH}" return fi configure_GCC \