Attention is currently required from: Jason Glenesk, Raul Rangel, Angel Pons, Fred Reitberger, Felix Held.
Robert Zieba has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/69917 )
Change subject: soc/amd/cezanne: Update XHCI GPE to use constant
......................................................................
Patch Set 5:
(2 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/69917/comment/5f828b26_8f93b3d9
PS3, Line 10: CL 67936
nit: use CB:67936 so that Gerrit highlights it as a link. […]
Done
File src/soc/amd/cezanne/xhci.c:
https://review.coreboot.org/c/coreboot/+/69917/comment/0757e441_e9fbaf9d
PS3, Line 14: GEVENT_31
Apparently it still needs to be defined because `XHCI_GEVENT` is defined as `GEVENT_31`: https://rev […]
Correct, `XHCI_GEVENT` is defined so it's easy to verify that the gpe is configured correctly in files like this. When using `GEVENT_31` it's less obvious if the configuration is correct.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/69917
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I9c2a44f7d2eb47422ae8c585e5e01ea0b420d461
Gerrit-Change-Number: 69917
Gerrit-PatchSet: 5
Gerrit-Owner: Robert Zieba
robertzieba@google.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: Fred Reitberger
reitbergerfred@gmail.com
Gerrit-Reviewer: Jason Glenesk
jason.glenesk@gmail.com
Gerrit-Reviewer: Matt DeVillier
matt.devillier@amd.corp-partner.google.com
Gerrit-Reviewer: Raul Rangel
rrangel@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Jason Glenesk
jason.glenesk@gmail.com
Gerrit-Attention: Raul Rangel
rrangel@chromium.org
Gerrit-Attention: Angel Pons
th3fanbus@gmail.com
Gerrit-Attention: Fred Reitberger
reitbergerfred@gmail.com
Gerrit-Attention: Felix Held
felix-coreboot@felixheld.de
Gerrit-Comment-Date: Mon, 28 Nov 2022 23:29:06 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Angel Pons
th3fanbus@gmail.com
Gerrit-MessageType: comment