Attention is currently required from: Nico Huber, Arthur Heymans, Patrick Rudolph. Hello Nico Huber, Arthur Heymans, Patrick Rudolph,
I'd like you to do a code review. Please visit
https://review.coreboot.org/c/coreboot/+/55482
to review the following change.
Change subject: soc/intel/broadwell: Include `pci_irqs.asl` from PCH ......................................................................
soc/intel/broadwell: Include `pci_irqs.asl` from PCH
Move the inclusion of `pci_irqs.asl` into PCH scope in order to allow deduplicating northbridge ACPI code.
Change-Id: I541913226b26662f3798ae9c25ab1ac33cf2ed45 Signed-off-by: Angel Pons th3fanbus@gmail.com --- M src/soc/intel/broadwell/acpi/hostbridge.asl M src/soc/intel/broadwell/pch/acpi/pch.asl R src/soc/intel/broadwell/pch/acpi/pci_irqs.asl 3 files changed, 3 insertions(+), 3 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/82/55482/1
diff --git a/src/soc/intel/broadwell/acpi/hostbridge.asl b/src/soc/intel/broadwell/acpi/hostbridge.asl index cf8a6ce..6235f39 100644 --- a/src/soc/intel/broadwell/acpi/hostbridge.asl +++ b/src/soc/intel/broadwell/acpi/hostbridge.asl @@ -193,9 +193,6 @@ } }
-/* PCI IRQ assignment */ -#include "pci_irqs.asl" - /* Configurable TDP */ #include <northbridge/intel/haswell/acpi/ctdp.asl>
diff --git a/src/soc/intel/broadwell/pch/acpi/pch.asl b/src/soc/intel/broadwell/pch/acpi/pch.asl index 0e90c95..fd23f89 100644 --- a/src/soc/intel/broadwell/pch/acpi/pch.asl +++ b/src/soc/intel/broadwell/pch/acpi/pch.asl @@ -2,6 +2,9 @@
#include <soc/iomap.h>
+/* PCI IRQ assignment */ +#include "pci_irqs.asl" + Scope () { // IO-Trap at 0x800. This is the ACPI->SMI communication interface. diff --git a/src/soc/intel/broadwell/acpi/pci_irqs.asl b/src/soc/intel/broadwell/pch/acpi/pci_irqs.asl similarity index 100% rename from src/soc/intel/broadwell/acpi/pci_irqs.asl rename to src/soc/intel/broadwell/pch/acpi/pci_irqs.asl