Attention is currently required from: Jamie Chen, Derek Huang, Stanley Wu, Marco Chen.
Eric Lai has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/69925 )
Change subject: mb/google/octopus/variants/phaser: Implement variant_memory_sku()
......................................................................
Patch Set 3:
(3 comments)
File src/mainboard/google/octopus/variants/phaser/memory.c:
https://review.coreboot.org/c/coreboot/+/69925/comment/d3c254a1_cd91287b
PS3, Line 17:
extra tab.
https://review.coreboot.org/c/coreboot/+/69925/comment/a0c22d6c_3ef7e841
PS3, Line 18: return (rt == 3) ? 1 : rt; // If RAM ID = 3, return 1
Thanks for the suggestion. But there don`t have specific board_id define for ram_id=3 case. […]
Since I can't access the issue, leave this to the SIE. I am fine here.
https://review.coreboot.org/c/coreboot/+/69925/comment/54ea374c_0108a4c8
PS3, Line 18:
extra tab
--
To view, visit
https://review.coreboot.org/c/coreboot/+/69925
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I36ec6bad7096e5de666ac6500c8419fc6e383ae1
Gerrit-Change-Number: 69925
Gerrit-PatchSet: 3
Gerrit-Owner: Stanley Wu
stanley1.wu@lcfc.corp-partner.google.com
Gerrit-Reviewer: Derek Huang
derekhuang@google.com
Gerrit-Reviewer: Jamie Chen
jamie.chen@intel.corp-partner.google.com
Gerrit-Reviewer: Marco Chen
marcochen@google.com
Gerrit-CC: Eric Lai
eric_lai@quanta.corp-partner.google.com
Gerrit-CC: Joey Peng
joey.peng@lcfc.corp-partner.google.com
Gerrit-CC: Leo Chou
leo.chou@lcfc.corp-partner.google.com
Gerrit-CC: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Jamie Chen
jamie.chen@intel.corp-partner.google.com
Gerrit-Attention: Derek Huang
derekhuang@google.com
Gerrit-Attention: Stanley Wu
stanley1.wu@lcfc.corp-partner.google.com
Gerrit-Attention: Marco Chen
marcochen@google.com
Gerrit-Comment-Date: Wed, 23 Nov 2022 15:52:29 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Derek Huang
derekhuang@google.com
Comment-In-Reply-To: Stanley Wu
stanley1.wu@lcfc.corp-partner.google.com
Comment-In-Reply-To: Eric Lai
eric_lai@quanta.corp-partner.google.com
Gerrit-MessageType: comment