Attention is currently required from: Paul Menzel, Alex1 Kao.
Karthik Ramasubramanian has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/56327 )
Change subject: mb/google/dedede/var/pirika: Add USB2 PHY parameters
......................................................................
Patch Set 5:
(2 comments)
File src/mainboard/google/dedede/variants/pirika/overridetree.cb:
https://review.coreboot.org/c/coreboot/+/56327/comment/4f7b9b07_207f5ca5
PS5, Line 43: 4,
What does 4 correspond to? Can you please add a macro for that value in src/soc/intel/jasperlake/include/soc/usb.h and then use that macro here?
https://review.coreboot.org/c/coreboot/+/56327/comment/72247966_b61b7c3d
PS5, Line 49: .ocpin = OC_SKIP,
No need to set/initialize tx_bias and tx_emp_enable fields?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/56327
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Icf9fb41cd0ae40728e4ec5bd72a15ec3c45c963b
Gerrit-Change-Number: 56327
Gerrit-PatchSet: 5
Gerrit-Owner: Alex1 Kao
alex1_kao@pegatron.corp-partner.google.com
Gerrit-Reviewer: Alex1 Kao
alex1_kao@pegatron.corp-partner.google.com
Gerrit-Reviewer: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Reviewer: Kirk Wang
kirk_wang@pegatron.corp-partner.google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-CC: Shou-Chieh Hsu
shouchieh@google.com
Gerrit-Attention: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Alex1 Kao
alex1_kao@pegatron.corp-partner.google.com
Gerrit-Comment-Date: Thu, 22 Jul 2021 06:45:00 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment