[coreboot-gerrit] Change in coreboot[master]: mb/google/dedede/var/pirika: Add USB2 PHY parameters

[Karthik Ramasubramanian (Code Review)]

Attention is currently required from: Paul Menzel, Alex1 Kao.
Karthik Ramasubramanian has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/56327 )

Change subject: mb/google/dedede/var/pirika: Add USB2 PHY parameters
......................................................................

Patch Set 5:

(2 comments)

File src/mainboard/google/dedede/variants/pirika/overridetree.cb:

https://review.coreboot.org/c/coreboot/+/56327/comment/4f7b9b07_207f5ca5 
PS5, Line 43: 4,
What does 4 correspond to? Can you please add a macro for that value in src/soc/intel/jasperlake/include/soc/usb.h and then use that macro here?

https://review.coreboot.org/c/coreboot/+/56327/comment/72247966_b61b7c3d 
PS5, Line 49: 		.ocpin = OC_SKIP,
No need to set/initialize tx_bias and tx_emp_enable fields?