Attention is currently required from: Jamie Chen, Stanley Wu, Marco Chen, Eric Lai.
Karthik Ramasubramanian has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/69925 )
Change subject: mb/google/octopus/variants/phaser: Implement variant_memory_sku()
......................................................................
Patch Set 5:
(1 comment)
File src/mainboard/google/octopus/variants/phaser/memory.c:
https://review.coreboot.org/c/coreboot/+/69925/comment/1c683ee5_7bb64af0
PS5, Line 15: rt = gpio_base2_value(pads, ARRAY_SIZE(pads));
I would recommend translating this only for the impacted SKU. For other SKUs, please assert RAM_ID != 3. That way we can ensure that RAM_ID 3 is not accidentally chosen.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/69925
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I36ec6bad7096e5de666ac6500c8419fc6e383ae1
Gerrit-Change-Number: 69925
Gerrit-PatchSet: 5
Gerrit-Owner: Stanley Wu
stanley1.wu@lcfc.corp-partner.google.com
Gerrit-Reviewer: Derek Huang
derekhuang@google.com
Gerrit-Reviewer: Jamie Chen
jamie.chen@intel.com
Gerrit-Reviewer: Jamie Chen
jamie.chen@intel.corp-partner.google.com
Gerrit-Reviewer: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Reviewer: Marco Chen
marcochen@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Eric Lai
eric_lai@quanta.corp-partner.google.com
Gerrit-CC: Joey Peng
joey.peng@lcfc.corp-partner.google.com
Gerrit-CC: Leo Chou
leo.chou@lcfc.corp-partner.google.com
Gerrit-Attention: Jamie Chen
jamie.chen@intel.corp-partner.google.com
Gerrit-Attention: Stanley Wu
stanley1.wu@lcfc.corp-partner.google.com
Gerrit-Attention: Marco Chen
marcochen@google.com
Gerrit-Attention: Eric Lai
eric_lai@quanta.corp-partner.google.com
Gerrit-Comment-Date: Mon, 28 Nov 2022 17:03:42 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment