Akash Asthana has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/29104 )
Change subject: sdm845: Port I2C driver
......................................................................
Patch Set 31:
(2 comments)
https://review.coreboot.org/#/c/29104/24/src/mainboard/google/cheza/mainboar...
File src/mainboard/google/cheza/mainboard.c:
https://review.coreboot.org/#/c/29104/24/src/mainboard/google/cheza/mainboar...
PS24, Line 42: i2c_init(12, 400 * KHz, 1);
Okay, but why don't they just #include qcom_qup_se.h in clock. […]
Sure!, in discussion with clock team for this comment.
https://review.coreboot.org/#/c/29104/24/src/soc/qualcomm/sdm845/i2c.c
File src/soc/qualcomm/sdm845/i2c.c:
https://review.coreboot.org/#/c/29104/24/src/soc/qualcomm/sdm845/i2c.c@101
PS24, Line 101: BITS_PER_WORD >> 4
Okay. […]
Done, I have already added comment for same in the definition of PACK_VECTORS.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/29104
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ifb76564d8a11427423dd14d8ba7c8c7d500ef346
Gerrit-Change-Number: 29104
Gerrit-PatchSet: 31
Gerrit-Owner: T.Michael Turney
tturne@codeaurora.org
Gerrit-Reviewer: Akash Asthana
akashast@qualcomm.corp-partner.google.com
Gerrit-Reviewer: Julius Werner
jwerner@chromium.org
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: T Michael Turney
mturney@codeaurora.org
Gerrit-Reviewer: T.Michael Turney
tturne@codeaurora.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Tue, 30 Apr 2019 14:50:05 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Akash Asthana
akashast@qualcomm.corp-partner.google.com
Comment-In-Reply-To: Julius Werner
jwerner@chromium.org
Gerrit-MessageType: comment