Patrick Georgi has submitted this change. ( https://review.coreboot.org/c/coreboot/+/59496 )
Change subject: libpayload/tests: Fix mocks __real_<func> symbol creation ......................................................................
libpayload/tests: Fix mocks __real_<func> symbol creation
There were escape backslashes around regular expression passed to grep. Because of that, grep was returning empty results as a consequence of pattern mismatch, and thus symbols pointing to original functions were not created correctly.
Change-Id: I751109735b6c56824df9a560ae989bf062a0e9a6 Signed-off-by: Jakub Czapiga jacz@semihalf.com Reviewed-on: https://review.coreboot.org/c/coreboot/+/59496 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Julius Werner jwerner@chromium.org --- M payloads/libpayload/tests/Makefile.inc 1 file changed, 1 insertion(+), 1 deletion(-)
Approvals: build bot (Jenkins): Verified Julius Werner: Looks good to me, approved
diff --git a/payloads/libpayload/tests/Makefile.inc b/payloads/libpayload/tests/Makefile.inc index e4babb1..ba465b0 100644 --- a/payloads/libpayload/tests/Makefile.inc +++ b/payloads/libpayload/tests/Makefile.inc @@ -140,7 +140,7 @@ objcopy_wrap_flags=''; \ for sym in $$($(1)-mocks); do \ sym_line="$$$$($(HOSTOBJDUMP) -t $$@.orig \ - | grep -E "[0-9a-fA-F]+\s+w\s+F\s+.*\s$$$$sym$$$$")"; \ + | grep -E "[0-9a-fA-F]+\s+w\s+F\s+.*\s+$$$$sym$$$$")"; \ if [ ! -z "$$$$sym_line" ] ; then \ addr="$$$$(echo "$$$$sym_line" | awk '{ print $$$$1 }')"; \ section="$$$$(echo "$$$$sym_line" | awk '{ print $$$$(NF - 2) }')"; \
1 is the latest approved patch-set. No files were changed between the latest approved patch-set and the submitted one.