Nico Huber has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/48940 )
Change subject: nvramcui: Unexport COREBOOT_EXPORTS ......................................................................
nvramcui: Unexport COREBOOT_EXPORTS
coreboot's Makefile exports a lot of variables that influence make sub- processes (e.g. for Kconfig). We don't want these variables leak into sub-processes for (lib)payload builds, hence unexport them.
Change-Id: I8da2d8db6238d456723b9c22bee80c62e97027b0 Signed-off-by: Nico Huber nico.h@gmx.de --- M payloads/nvramcui/Makefile 1 file changed, 2 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/40/48940/1
diff --git a/payloads/nvramcui/Makefile b/payloads/nvramcui/Makefile index 269d558..ebc48de 100644 --- a/payloads/nvramcui/Makefile +++ b/payloads/nvramcui/Makefile @@ -1,3 +1,5 @@ +unexport $(COREBOOT_EXPORTS) + LIBPAYLOAD_DIR=$(CURDIR)/libpayload XCOMPILE=$(LIBPAYLOAD_DIR)/libpayload.xcompile # build libpayload and put .config file in $(CURDIR) instead of ../libpayload
Felix Singer has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/48940 )
Change subject: nvramcui: Unexport COREBOOT_EXPORTS ......................................................................
Patch Set 1: Code-Review+1
Attention is currently required from: Nico Huber. Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/48940 )
Change subject: nvramcui: Unexport COREBOOT_EXPORTS ......................................................................
Patch Set 1: Code-Review+1
Attention is currently required from: Nico Huber. Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/48940 )
Change subject: nvramcui: Unexport COREBOOT_EXPORTS ......................................................................
Patch Set 2: Code-Review+2
Nico Huber has submitted this change. ( https://review.coreboot.org/c/coreboot/+/48940 )
Change subject: nvramcui: Unexport COREBOOT_EXPORTS ......................................................................
nvramcui: Unexport COREBOOT_EXPORTS
coreboot's Makefile exports a lot of variables that influence make sub- processes (e.g. for Kconfig). We don't want these variables leak into sub-processes for (lib)payload builds, hence unexport them.
Change-Id: I8da2d8db6238d456723b9c22bee80c62e97027b0 Signed-off-by: Nico Huber nico.h@gmx.de Reviewed-on: https://review.coreboot.org/c/coreboot/+/48940 Reviewed-by: Angel Pons th3fanbus@gmail.com Reviewed-by: Felix Singer felixsinger@posteo.net Tested-by: build bot (Jenkins) no-reply@coreboot.org --- M payloads/nvramcui/Makefile 1 file changed, 2 insertions(+), 0 deletions(-)
Approvals: build bot (Jenkins): Verified Felix Singer: Looks good to me, but someone else must approve Angel Pons: Looks good to me, approved
diff --git a/payloads/nvramcui/Makefile b/payloads/nvramcui/Makefile index 269d558..ebc48de 100644 --- a/payloads/nvramcui/Makefile +++ b/payloads/nvramcui/Makefile @@ -1,3 +1,5 @@ +unexport $(COREBOOT_EXPORTS) + LIBPAYLOAD_DIR=$(CURDIR)/libpayload XCOMPILE=$(LIBPAYLOAD_DIR)/libpayload.xcompile # build libpayload and put .config file in $(CURDIR) instead of ../libpayload
-
Angel Pons (Code Review) -
Felix Singer (Code Review)
-
Nico Huber (Code Review)