Change in coreboot[master]: pci_mmio_cfg: Move guard around pci_s_* functions to x86 - coreboot-gerrit

7 Nov 2021


      Attention is currently required from: Shelley Chen, Furquan Shaikh, Tim Wawrzynczak.
Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/58331 )
Change subject: pci_mmio_cfg: Move guard around pci_s_* functions to x86
......................................................................
Patch Set 4:
(1 comment)
File src/arch/x86/include/arch/pci_ops.h:
https://review.coreboot.org/c/coreboot/+/58331/comment/5d10ede9_ab70a950 
PS2, Line 7: MMCONF_SUPPORT
...
Ok.  I would assume that we need to rename MMCONF_BASE_ADDRESS and MMCONF_LENGTH to MMCONF_ECAM... […]
Sounds good, maybe not patch set 1 exactly, but something like that.
-- 
To view, visit https://review.coreboot.org/c/coreboot/+/58331
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Iaeed6ab43ad61b7c0e14572b12bf4ec06b6a26af
Gerrit-Change-Number: 58331
Gerrit-PatchSet: 4
Gerrit-Owner: Nico Huber nico.h@gmx.de
Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com
Gerrit-Reviewer: Furquan Shaikh furquan.m.shaikh@gmail.com
Gerrit-Reviewer: Kyösti Mälkki kyosti.malkki@gmail.com
Gerrit-Reviewer: Shelley Chen shchen@google.com
Gerrit-Reviewer: Tim Wawrzynczak twawrzynczak@chromium.org
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-CC: Paul Menzel paulepanter@mailbox.org
Gerrit-Attention: Shelley Chen shchen@google.com
Gerrit-Attention: Furquan Shaikh furquan.m.shaikh@gmail.com
Gerrit-Attention: Tim Wawrzynczak twawrzynczak@chromium.org
Gerrit-Attention: Furquan Shaikh furquan.m.shaikh@gmail.com
Gerrit-Comment-Date: Sun, 07 Nov 2021 16:00:33 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Shelley Chen shchen@google.com
Comment-In-Reply-To: Nico Huber nico.h@gmx.de
Gerrit-MessageType: comment