Riku Viitanen has posted comments on this change by Riku Viitanen. ( https://review.coreboot.org/c/coreboot/+/79583?usp=email )
Change subject: mb/hp/snb_ivb_desktops: Add 8200 USDT variant
......................................................................
Patch Set 5:
(1 comment)
File src/mainboard/hp/snb_ivb_desktops/variants/compaq_8200_elite_usdt/early_init.c:
https://review.coreboot.org/c/coreboot/+/79583/comment/b53d237f_4314007c?usp... :
PS5, Line 6: #include <southbridge/intel/bd82x6x/pch.h>
if I'm not wrong, southbridge/Intel/... […]
it really isn't. i uploaded a follow-up commit to remove it (CB:85815).
--
To view, visit
https://review.coreboot.org/c/coreboot/+/79583?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I1cba7a5e664758eba7ea2ab8a55658b307d1d173
Gerrit-Change-Number: 79583
Gerrit-PatchSet: 5
Gerrit-Owner: Riku Viitanen
riku.viitanen@protonmail.com
Gerrit-Reviewer: Felix Singer
service+coreboot-gerrit@felixsinger.de
Gerrit-Reviewer: Matt DeVillier
matt.devillier@gmail.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: 9elements QA
hardwaretestrobot@gmail.com
Gerrit-CC: Elyes Haouas
ehaouas@noos.fr
Gerrit-CC: Keith Hui
buurin@gmail.com
Gerrit-Comment-Date: Mon, 30 Dec 2024 22:44:53 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Elyes Haouas
ehaouas@noos.fr