Patrick Georgi has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/29827 )
Change subject: security/vboot: Add VB2_LIB to romstage sources without dependencies
......................................................................
Patch Set 2:
I guess the main downside is that this creates another build of libvboot, no matter if it's used later-on or not. Reminds me that I wanted to look into deduplicating them ;-)
--
To view, visit
https://review.coreboot.org/c/coreboot/+/29827
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I8126c21b8fbe8dd65d95af49cbe2ad776b8ef605
Gerrit-Change-Number: 29827
Gerrit-PatchSet: 2
Gerrit-Owner: Werner Zeh
werner.zeh@siemens.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Philipp Deppenwiese
zaolin.daisuki@gmail.com
Gerrit-Reviewer: Werner Zeh
werner.zeh@siemens.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Mon, 26 Nov 2018 09:53:49 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment