Change in coreboot[master]: mb/google/dedede/variants/waddledoo: Adjust I2Cs CLK to meet spec

[John Su (Code Review)]

John Su has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/42187 )

Change subject: mb/google/dedede/variants/waddledoo: Adjust I2Cs CLK to meet spec
......................................................................

mb/google/dedede/variants/waddledoo: Adjust I2Cs CLK to meet spec

After adjustment on waddledoo
Touch Pad CLK: 392.9 KHz
Touch Screen CLK: 387.4 KHz
Audio CLK: 350.9 KHz

BUG=b:151302522
BRANCH=master
TEST=emerge-dedede coreboot chromeos-bootimage
     measure by scope with waddledoo.

Signed-off-by: John Su 
Change-Id: Iec02a751f1effdbefbb2969db2fd57f27ecdd033
---
M src/mainboard/google/dedede/variants/waddledoo/overridetree.cb
1 file changed, 6 insertions(+), 4 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/87/42187/1

diff --git a/src/mainboard/google/dedede/variants/waddledoo/overridetree.cb b/src/mainboard/google/dedede/variants/waddledoo/overridetree.cb
index 4546c9f..b8be926 100644
--- a/src/mainboard/google/dedede/variants/waddledoo/overridetree.cb
+++ b/src/mainboard/google/dedede/variants/waddledoo/overridetree.cb
@@ -24,8 +24,8 @@
    	},
    	.i2c[0] = {
    		.speed = I2C_SPEED_FAST,
-			.rise_time_ns = 66,
-			.fall_time_ns = 90,
+			.rise_time_ns = 270,
+			.fall_time_ns = 270,
    		.data_hold_time_ns = 350,
    	},
    	.i2c[1] = {
@@ -33,6 +33,8 @@
    	},
    	.i2c[2] = {
    		.speed = I2C_SPEED_FAST,
+			.rise_time_ns = 200,
+			.fall_time_ns = 200,
    	},
    	.i2c[3] = {
    		.speed = I2C_SPEED_FAST,
@@ -41,8 +43,8 @@
    		.speed = I2C_SPEED_FAST,
    		.speed_config[0] = {
    			.speed = I2C_SPEED_FAST,
-				.scl_lcnt = 176,
-				.scl_hcnt = 95,
+				.scl_lcnt = 200,
+				.scl_hcnt = 120,
    			.sda_hold = 36,
    		}
    	},

[John Su (Code Review)]

John Su has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42187 )

Change subject: mb/google/dedede/variants/waddledoo: Adjust I2Cs CLK to meet spec
......................................................................

Patch Set 1: Code-Review+1

[Justin TerAvest (Code Review)]

Justin TerAvest has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42187 )

Change subject: mb/google/dedede/variants/waddledoo: Adjust I2Cs CLK to meet spec
......................................................................

Patch Set 1: Code-Review+2

[Karthik Ramasubramanian (Code Review)]

Karthik Ramasubramanian has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42187 )

Change subject: mb/google/dedede/variants/waddledoo: Adjust I2Cs CLK to meet spec
......................................................................

Patch Set 1: Code-Review+2

[Paul Menzel (Code Review)]

Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42187 )

Change subject: mb/google/dedede/variants/waddledoo: Adjust I2Cs CLK to meet spec
......................................................................

Patch Set 1:

(2 comments)

https://review.coreboot.org/c/coreboot/+/42187/1//COMMIT_MSG 
Commit Message:

https://review.coreboot.org/c/coreboot/+/42187/1//COMMIT_MSG@7 
PS1, Line 7: spec
What spec exactly?

https://review.coreboot.org/c/coreboot/+/42187/1//COMMIT_MSG@12 
PS1, Line 12: Audio CLK: 350.9 KHz
What were the values before?

[John Su (Code Review)]

John Su has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42187 )

Change subject: mb/google/dedede/variants/waddledoo: Adjust I2Cs CLK to meet spec
......................................................................

Patch Set 1:

(2 comments)

https://review.coreboot.org/c/coreboot/+/42187/1//COMMIT_MSG 
Commit Message:

https://review.coreboot.org/c/coreboot/+/42187/1//COMMIT_MSG@7 
PS1, Line 7: spec
> What spec exactly?

I2C clock under 400 kHZ.
Follow b:151302522 comment#5.

https://review.coreboot.org/c/coreboot/+/42187/1//COMMIT_MSG@12 
PS1, Line 12: Audio CLK: 350.9 KHz
> What were the values before?

The values are over 400 kHZ before.

[John Su (Code Review)]

John Su has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42187 )

Change subject: mb/google/dedede/variants/waddledoo: Adjust I2Cs CLK to meet spec
......................................................................

Patch Set 1:

(2 comments)

https://review.coreboot.org/c/coreboot/+/42187/1//COMMIT_MSG 
Commit Message:

https://review.coreboot.org/c/coreboot/+/42187/1//COMMIT_MSG@7 
PS1, Line 7: spec
> I2C clock under 400 kHZ. […]

Ack

https://review.coreboot.org/c/coreboot/+/42187/1//COMMIT_MSG@12 
PS1, Line 12: Audio CLK: 350.9 KHz
> The values are over 400 kHZ before.

Ack

[Patrick Georgi (Code Review)]

Patrick Georgi has submitted this change. ( https://review.coreboot.org/c/coreboot/+/42187 )

Change subject: mb/google/dedede/variants/waddledoo: Adjust I2Cs CLK to meet spec
......................................................................

mb/google/dedede/variants/waddledoo: Adjust I2Cs CLK to meet spec

After adjustment on waddledoo
Touch Pad CLK: 392.9 KHz
Touch Screen CLK: 387.4 KHz
Audio CLK: 350.9 KHz

BUG=b:151302522
BRANCH=master
TEST=emerge-dedede coreboot chromeos-bootimage
     measure by scope with waddledoo.

Signed-off-by: John Su 
Change-Id: Iec02a751f1effdbefbb2969db2fd57f27ecdd033
Reviewed-on: https://review.coreboot.org/c/coreboot/+/42187
Reviewed-by: Justin TerAvest 
Reviewed-by: Karthik Ramasubramanian 
Tested-by: build bot (Jenkins) 
---
M src/mainboard/google/dedede/variants/waddledoo/overridetree.cb
1 file changed, 6 insertions(+), 4 deletions(-)

Approvals:
  build bot (Jenkins): Verified
  Justin TerAvest: Looks good to me, approved
  John Su: Looks good to me, but someone else must approve
  Karthik Ramasubramanian: Looks good to me, approved

diff --git a/src/mainboard/google/dedede/variants/waddledoo/overridetree.cb b/src/mainboard/google/dedede/variants/waddledoo/overridetree.cb
index 4546c9f..b8be926 100644
--- a/src/mainboard/google/dedede/variants/waddledoo/overridetree.cb
+++ b/src/mainboard/google/dedede/variants/waddledoo/overridetree.cb
@@ -24,8 +24,8 @@
    	},
    	.i2c[0] = {
    		.speed = I2C_SPEED_FAST,
-			.rise_time_ns = 66,
-			.fall_time_ns = 90,
+			.rise_time_ns = 270,
+			.fall_time_ns = 270,
    		.data_hold_time_ns = 350,
    	},
    	.i2c[1] = {
@@ -33,6 +33,8 @@
    	},
    	.i2c[2] = {
    		.speed = I2C_SPEED_FAST,
+			.rise_time_ns = 200,
+			.fall_time_ns = 200,
    	},
    	.i2c[3] = {
    		.speed = I2C_SPEED_FAST,
@@ -41,8 +43,8 @@
    		.speed = I2C_SPEED_FAST,
    		.speed_config[0] = {
    			.speed = I2C_SPEED_FAST,
-				.scl_lcnt = 176,
-				.scl_hcnt = 95,
+				.scl_lcnt = 200,
+				.scl_hcnt = 120,
    			.sda_hold = 36,
    		}
    	},