Iru Cai has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/58558 )
Change subject: arch/x86: fix commit 04a40379b
......................................................................
Patch Set 1:
(1 comment)
File src/arch/x86/ioapic.c:
https://review.coreboot.org/c/coreboot/+/58558/comment/f00db3d0_cacaeb7e
PS1, Line 60: 0xff
Need to check if this should be 0xffff too.
Hmm, it's 0xff since count is 8 bits.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/58558
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ifda7bb61a431dbf9c2df2f738aa806dd6d8097b8
Gerrit-Change-Number: 58558
Gerrit-PatchSet: 1
Gerrit-Owner: Iru Cai
mytbk920423@gmail.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Comment-Date: Sat, 23 Oct 2021 14:14:46 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Iru Cai
mytbk920423@gmail.com
Gerrit-MessageType: comment