HAOUAS Elyes has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32329 )
Change subject: ACPI: Clarify serial bus revision and specific revision ......................................................................
Patch Set 1:
(1 comment)
https://review.coreboot.org/#/c/32329/1/src/arch/x86/include/arch/acpi_devic... File src/arch/x86/include/arch/acpi_device.h:
https://review.coreboot.org/#/c/32329/1/src/arch/x86/include/arch/acpi_devic... PS1, Line 317: #define ACPI_SPI_SPECIFIC_REVISION_ID
TYPE_REVISION_ID will be better?
Thank you for the review. "Type Specific Revision ID" is indeed used as Field Name, but this name is used for i2c, spi and uart. in the description/definition inside ACPI specification, they use "Indicates the revision of the I2C-specific Serial Bus". and "SPI-specific" ... to make a difference between them. so if you want we can use : ACPI_I2C_TYPE_SPECIFIC_REVISION_ID for i2c and ACPI_SPI_TYPE_SPECIFIC_REVISION_ID for spi.
Please let me know your thought.