Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/48868 )
Change subject: mb/google/kukui: enable Eotp feature for anx7625 ......................................................................
Patch Set 8:
(4 comments)
https://review.coreboot.org/c/coreboot/+/48868/8//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/48868/8//COMMIT_MSG@7 PS8, Line 7: enable Enable
https://review.coreboot.org/c/coreboot/+/48868/8//COMMIT_MSG@9 PS8, Line 9: Enable Eotp feature for anx7625. What does EOTP do?
https://review.coreboot.org/c/coreboot/+/48868/8//COMMIT_MSG@13 PS8, Line 13: TEST=Boots correctly on Kukui What changed? How do you verify EOTP works? As new print statements are added, maybe also paste that.
https://review.coreboot.org/c/coreboot/+/48868/8/src/mainboard/google/kukui/... File src/mainboard/google/kukui/mainboard.c:
https://review.coreboot.org/c/coreboot/+/48868/8/src/mainboard/google/kukui/... PS8, Line 170: printk(BIOS_INFO, "%s: dsi_flags=%#x\n", __func__, mipi_dsi_flags); Looks more like debug information. Otherwise, please rephrase to be better understandable.