Change in coreboot[master]: src/mainboard/google: enable Eotp feature

List overview All Threads
Download

newer

older

Change in coreboot[master]:...

Shaoming Chen (Code Review)

23 Dec 2020 23 Dec '20

3:52 a.m.

Shaoming Chen has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/48868 )

Change subject: src/mainboard/google: enable Eotp feature ......................................................................

src/mainboard/google: enable Eotp feature

enable Eotp feature for anx7625

BUG=none BRANCH=kukui TEST=Boots correctly on Kukui

Signed-off-by: Shaoming Chen shaoming.chen@mediatek.corp-partner.google.com Change-Id: Ifadd0def13cc264e9d39ab9c981fbdc996396bfa --- M src/mainboard/google/kukui/mainboard.c 1 file changed, 5 insertions(+), 1 deletion(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/68/48868/1

diff --git a/src/mainboard/google/kukui/mainboard.c b/src/mainboard/google/kukui/mainboard.c index 4220810d..e6fac84 100644 --- a/src/mainboard/google/kukui/mainboard.c +++ b/src/mainboard/google/kukui/mainboard.c @@ -160,8 +160,12 @@ u32 mipi_dsi_flags = (MIPI_DSI_MODE_VIDEO | MIPI_DSI_MODE_VIDEO_SYNC_PULSE | MIPI_DSI_MODE_LPM); - if (CONFIG(DRIVER_ANALOGIX_ANX7625)) +/* if (CONFIG(DRIVER_ANALOGIX_ANX7625)) mipi_dsi_flags |= MIPI_DSI_MODE_EOT_PACKET; +*/ + /* if bit9 = 1, then disable EoT packets, other enable EoT pachets in HS mode */ + printk(BIOS_INFO, "mipi_dsi_flags = 0x%x \n", mipi_dsi_flags); + if (mtk_dsi_init(mipi_dsi_flags, MIPI_DSI_FMT_RGB888, 4, edid, panel->s->init) < 0) { printk(BIOS_ERR, "%s: Failed in DSI init.\n", __func__);

Attachments:

attachment.htm (text/html — 3.1 KB)

Show replies by date

build bot (Jenkins) (Code Review)

23 Dec 23 Dec

3:57 a.m.

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/48868 )

Change subject: src/mainboard/google: enable Eotp feature ......................................................................

Patch Set 1:

(1 comment)

https://review.coreboot.org/c/coreboot/+/48868/1/src/mainboard/google/kukui/... File src/mainboard/google/kukui/mainboard.c:

https://review.coreboot.org/c/coreboot/+/48868/1/src/mainboard/google/kukui/... PS1, Line 167: printk(BIOS_INFO, "mipi_dsi_flags = 0x%x \n", mipi_dsi_flags); unnecessary whitespace before a quoted newline

Shaoming Chen (Code Review)

24 Dec 24 Dec

2:30 a.m.

Hello build bot (Jenkins), Chen-Tsung Hsieh, Jitao Shi, Nicolas Boichat,

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/48868

to look at the new patch set (#2).

Change subject: src/mainboard/google: enable Eotp feature ......................................................................

src/mainboard/google: enable Eotp feature

enable Eotp feature for anx7625

BUG=none BRANCH=kukui TEST=Boots correctly on Kukui

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/68/48868/2

build bot (Jenkins) (Code Review)

2:48 a.m.

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/48868 )

Change subject: src/mainboard/google: enable Eotp feature ......................................................................

Patch Set 2:

(1 comment)

https://review.coreboot.org/c/coreboot/+/48868/2/src/mainboard/google/kukui/... File src/mainboard/google/kukui/mainboard.c:

https://review.coreboot.org/c/coreboot/+/48868/2/src/mainboard/google/kukui/... PS2, Line 168: printk(BIOS_INFO, "mipi_dsi_flags = 0x%x \n", mipi_dsi_flags); unnecessary whitespace before a quoted newline

Shaoming Chen (Code Review)

3:03 a.m.

Hello build bot (Jenkins), Chen-Tsung Hsieh, Jitao Shi, Nicolas Boichat,

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/48868

to look at the new patch set (#3).

Change subject: src/mainboard/google: enable Eotp feature ......................................................................

src/mainboard/google: enable Eotp feature

enable Eotp feature for anx7625

BUG=none BRANCH=kukui TEST=Boots correctly on Kukui

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/68/48868/3

Shaoming Chen (Code Review)

4:12 a.m.

Hello build bot (Jenkins), Chen-Tsung Hsieh, Jitao Shi, Nicolas Boichat,

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/48868

to look at the new patch set (#4).

Change subject: src/mainboard/google: enable Eotp feature ......................................................................

src/mainboard/google: enable Eotp feature

enable Eotp feature for anx7625

BUG=none BRANCH=kukui TEST=Boots correctly on Kukui

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/68/48868/4

Yidi Lin (Code Review)

4:20 a.m.

Yidi Lin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/48868 )

Change subject: src/mainboard/google: enable Eotp feature ......................................................................

Patch Set 4:

(4 comments)

Please rebase this patch.

https://review.coreboot.org/c/coreboot/+/48868/4//COMMIT_MSG Commit Message:

https://review.coreboot.org/c/coreboot/+/48868/4//COMMIT_MSG@7 PS4, Line 7: src/mainboard/google mb/google/kukui: enable Eotp feature for anx7625

https://review.coreboot.org/c/coreboot/+/48868/4//COMMIT_MSG@9 PS4, Line 9: enable Eotp feature for anx7625 Enable Eotp feature for anx7625.

https://review.coreboot.org/c/coreboot/+/48868/4//COMMIT_MSG@11 PS4, Line 11: none please attach bug ID.

https://review.coreboot.org/c/coreboot/+/48868/4/src/mainboard/google/kukui/... File src/mainboard/google/kukui/mainboard.c:

https://review.coreboot.org/c/coreboot/+/48868/4/src/mainboard/google/kukui/... PS4, Line 170: 0x%x %#x

Yidi Lin (Code Review)

5:41 a.m.

Yidi Lin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/48868 )

Change subject: src/mainboard/google: enable Eotp feature ......................................................................

Patch Set 5:

This flag was added for screen scrolling issue. (CB:41161) Will it introduce screen scrolling issue again if you remove the flag ?

Wentao Qin (Code Review)

6:03 a.m.

Wentao Qin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/48868 )

Change subject: src/mainboard/google: enable Eotp feature ......................................................................

Patch Set 5:

...

Patch Set 5:

This flag was added for screen scrolling issue. (CB:41161) Will it introduce screen scrolling issue again if you remove the flag ?

Yes, there is a probability, so we also need to modify the dsi.c

diff --git a/src/soc/mediatek/common/dsi.c b/src/soc/mediatek/common/dsi.c index 73dacef33b..ab24ca4865 100644 --- a/src/soc/mediatek/common/dsi.c +++ b/src/soc/mediatek/common/dsi.c @@ -202,7 +202,7 @@ static void mtk_dsi_config_vdo_timing(u32 mode_flags, u32 format, u32 lanes, data_phy_cycles = phy_timing->lpx + phy_timing->da_hs_prepare + phy_timing->da_hs_zero + phy_timing->da_hs_exit + 3;

- u32 delta = 12; + u32 delta = 14; if (mode_flags & MIPI_DSI_MODE_VIDEO_BURST) delta += 6;

-- To view, visit https://review.coreboot.org/c/coreboot/+/48868 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ifadd0def13cc264e9d39ab9c981fbdc996396bfa Gerrit-Change-Number: 48868 Gerrit-PatchSet: 5 Gerrit-Owner: Shaoming Chen shaoming.chen@mediatek.corp-partner.google.com Gerrit-Reviewer: Chen-Tsung Hsieh chentsung@google.com Gerrit-Reviewer: Jitao Shi jitao.shi@mediatek.corp-partner.google.com Gerrit-Reviewer: Nicolas Boichat drinkcat@google.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Wentao Qin qinwentao@huaqin.corp-partner.google.com Gerrit-CC: Yidi Lin yidi.lin@mediatek.com Gerrit-Comment-Date: Thu, 24 Dec 2020 06:03:05 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment

Shaoming Chen (Code Review)

6:06 a.m.

New subject: Change in coreboot[master]: mb/google/kukui: enable Eotp feature for anx7625

Hello build bot (Jenkins), Chen-Tsung Hsieh, Jitao Shi, Nicolas Boichat,

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/48868

to look at the new patch set (#6).

Change subject: mb/google/kukui: enable Eotp feature for anx7625 ......................................................................

mb/google/kukui: enable Eotp feature for anx7625

Enable Eotp feature for anx7625.

BUG=b:168728787 BRANCH=kukui TEST=Boots correctly on Kukui

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/68/48868/6

Yidi Lin (Code Review)

6:13 a.m.

New subject: Change in coreboot[master]: mb/google/kukui: enable Eotp feature for anx7625

Yidi Lin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/48868 )

Change subject: mb/google/kukui: enable Eotp feature for anx7625 ......................................................................

Patch Set 6:

(1 comment)

https://review.coreboot.org/c/coreboot/+/48868/6/src/mainboard/google/kukui/... File src/mainboard/google/kukui/mainboard.c:

https://review.coreboot.org/c/coreboot/+/48868/6/src/mainboard/google/kukui/... PS6, Line 170: 0x%#x just %#x

-- To view, visit https://review.coreboot.org/c/coreboot/+/48868 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ifadd0def13cc264e9d39ab9c981fbdc996396bfa Gerrit-Change-Number: 48868 Gerrit-PatchSet: 6 Gerrit-Owner: Shaoming Chen shaoming.chen@mediatek.corp-partner.google.com Gerrit-Reviewer: Chen-Tsung Hsieh chentsung@google.com Gerrit-Reviewer: Jitao Shi jitao.shi@mediatek.corp-partner.google.com Gerrit-Reviewer: Nicolas Boichat drinkcat@google.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Wentao Qin qinwentao@huaqin.corp-partner.google.com Gerrit-CC: Yidi Lin yidi.lin@mediatek.com Gerrit-Comment-Date: Thu, 24 Dec 2020 06:13:37 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

Shaoming Chen (Code Review)

6:37 a.m.

New subject: Change in coreboot[master]: mb/google/kukui: enable Eotp feature for anx7625

Hello build bot (Jenkins), Chen-Tsung Hsieh, Jitao Shi, Nicolas Boichat,

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/48868

to look at the new patch set (#7).

Change subject: mb/google/kukui: enable Eotp feature for anx7625 ......................................................................

mb/google/kukui: enable Eotp feature for anx7625

Enable Eotp feature for anx7625.

BUG=b:168728787 BRANCH=kukui TEST=Boots correctly on Kukui

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/68/48868/7

Chen-Tsung Hsieh (Code Review)

28 Dec 28 Dec

6:07 a.m.

New subject: Change in coreboot[master]: mb/google/kukui: enable Eotp feature for anx7625

Chen-Tsung Hsieh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/48868 )

Change subject: mb/google/kukui: enable Eotp feature for anx7625 ......................................................................

Patch Set 8:

(1 comment)

https://review.coreboot.org/c/coreboot/+/48868/8/src/mainboard/google/kukui/... File src/mainboard/google/kukui/mainboard.c:

https://review.coreboot.org/c/coreboot/+/48868/8/src/mainboard/google/kukui/... PS8, Line 163: if (CONFIG(DRIVER_ANALOGIX_ANX7625)) : mipi_dsi_flags |= MIPI_DSI_MODE_EOT_PACKET; please refer to https://chromium-review.googlesource.com/c/chromiumos/third_party/coreboot/+...

it looks like disabling EOTP, not enabling.

-- To view, visit https://review.coreboot.org/c/coreboot/+/48868 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ifadd0def13cc264e9d39ab9c981fbdc996396bfa Gerrit-Change-Number: 48868 Gerrit-PatchSet: 8 Gerrit-Owner: Shaoming Chen shaoming.chen@mediatek.corp-partner.google.com Gerrit-Reviewer: Chen-Tsung Hsieh chentsung@google.com Gerrit-Reviewer: Hung-Te Lin hungte@chromium.org Gerrit-Reviewer: Jitao Shi jitao.shi@mediatek.corp-partner.google.com Gerrit-Reviewer: Nicolas Boichat drinkcat@google.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Wentao Qin qinwentao@huaqin.corp-partner.google.com Gerrit-CC: Yidi Lin yidi.lin@mediatek.com Gerrit-Comment-Date: Mon, 28 Dec 2020 06:07:37 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

Paul Menzel (Code Review)

10:13 a.m.

New subject: Change in coreboot[master]: mb/google/kukui: enable Eotp feature for anx7625

Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/48868 )

Change subject: mb/google/kukui: enable Eotp feature for anx7625 ......................................................................

Patch Set 8:

(4 comments)

https://review.coreboot.org/c/coreboot/+/48868/8//COMMIT_MSG Commit Message:

https://review.coreboot.org/c/coreboot/+/48868/8//COMMIT_MSG@7 PS8, Line 7: enable Enable

https://review.coreboot.org/c/coreboot/+/48868/8//COMMIT_MSG@9 PS8, Line 9: Enable Eotp feature for anx7625. What does EOTP do?

https://review.coreboot.org/c/coreboot/+/48868/8//COMMIT_MSG@13 PS8, Line 13: TEST=Boots correctly on Kukui What changed? How do you verify EOTP works? As new print statements are added, maybe also paste that.

https://review.coreboot.org/c/coreboot/+/48868/8/src/mainboard/google/kukui/... File src/mainboard/google/kukui/mainboard.c:

https://review.coreboot.org/c/coreboot/+/48868/8/src/mainboard/google/kukui/... PS8, Line 170: printk(BIOS_INFO, "%s: dsi_flags=%#x\n", __func__, mipi_dsi_flags); Looks more like debug information. Otherwise, please rephrase to be better understandable.

-- To view, visit https://review.coreboot.org/c/coreboot/+/48868 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ifadd0def13cc264e9d39ab9c981fbdc996396bfa Gerrit-Change-Number: 48868 Gerrit-PatchSet: 8 Gerrit-Owner: Shaoming Chen shaoming.chen@mediatek.corp-partner.google.com Gerrit-Reviewer: Chen-Tsung Hsieh chentsung@google.com Gerrit-Reviewer: Hung-Te Lin hungte@chromium.org Gerrit-Reviewer: Jitao Shi jitao.shi@mediatek.corp-partner.google.com Gerrit-Reviewer: Nicolas Boichat drinkcat@google.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-CC: Wentao Qin qinwentao@huaqin.corp-partner.google.com Gerrit-CC: Yidi Lin yidi.lin@mediatek.com Gerrit-Comment-Date: Mon, 28 Dec 2020 10:13:59 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

Jitao Shi (Code Review)

30 Dec 30 Dec

8:59 a.m.

New subject: Change in coreboot[master]: mb/google/kukui: Enable Eotp feature for anx7625

Jitao Shi has uploaded a new patch set (#9) to the change originally created by Shaoming Chen. ( https://review.coreboot.org/c/coreboot/+/48868 )

Change subject: mb/google/kukui: Enable Eotp feature for anx7625 ......................................................................

mb/google/kukui: Enable Eotp feature for anx7625

Enable Eotp feature for anx7625.

BUG=b:168728787 BRANCH=kukui TEST=Boots correctly on Kukui

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/68/48868/9

-- To view, visit https://review.coreboot.org/c/coreboot/+/48868 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ifadd0def13cc264e9d39ab9c981fbdc996396bfa Gerrit-Change-Number: 48868 Gerrit-PatchSet: 9 Gerrit-Owner: Shaoming Chen shaoming.chen@mediatek.corp-partner.google.com Gerrit-Reviewer: Chen-Tsung Hsieh chentsung@google.com Gerrit-Reviewer: Hung-Te Lin hungte@chromium.org Gerrit-Reviewer: Jitao Shi jitao.shi@mediatek.corp-partner.google.com Gerrit-Reviewer: Nicolas Boichat drinkcat@google.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-CC: Wentao Qin qinwentao@huaqin.corp-partner.google.com Gerrit-CC: Yidi Lin yidi.lin@mediatek.com Gerrit-MessageType: newpatchset

Jitao Shi (Code Review)

11:29 a.m.

New subject: Change in coreboot[master]: mb/google/kukui: Enable Eotp feature for anx7625

Jitao Shi has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/48868 )

Change subject: mb/google/kukui: Enable Eotp feature for anx7625 ......................................................................

Patch Set 9:

(5 comments)

https://review.coreboot.org/c/coreboot/+/48868/8//COMMIT_MSG Commit Message:

https://review.coreboot.org/c/coreboot/+/48868/8//COMMIT_MSG@7 PS8, Line 7: enable

...

Enable

Will fix next version.

https://review.coreboot.org/c/coreboot/+/48868/8//COMMIT_MSG@9 PS8, Line 9: Enable Eotp feature for anx7625.

...

What does EOTP do?

EoTp is End of Transmission packet (EoTp) defined in dsi spec.

https://review.coreboot.org/c/coreboot/+/48868/8//COMMIT_MSG@13 PS8, Line 13: TEST=Boots correctly on Kukui

...

What changed? How do you verify EOTP works? As new print statements are added, maybe also paste that […]

We test it with dsi protocol tool. The protocol tool can receiver the EoTp packet.

https://review.coreboot.org/c/coreboot/+/48868/8/src/mainboard/google/kukui/... File src/mainboard/google/kukui/mainboard.c:

https://review.coreboot.org/c/coreboot/+/48868/8/src/mainboard/google/kukui/... PS8, Line 163: if (CONFIG(DRIVER_ANALOGIX_ANX7625)) : mipi_dsi_flags |= MIPI_DSI_MODE_EOT_PACKET;

...

please refer to https://chromium-review.googlesource. […]

Yes, you are right.

The comment lets me misunderstood the "MIPI_DSI_MODE_EOT_PACKET". /* disable EoT packets in HS mode */ MIPI_DSI_MODE_EOT_PACKET = BIT(9),

I'll correct the wrong setting in soc dsi.

https://review.coreboot.org/c/coreboot/+/48868/8/src/mainboard/google/kukui/... PS8, Line 170: printk(BIOS_INFO, "%s: dsi_flags=%#x\n", __func__, mipi_dsi_flags);

...

Looks more like debug information. Otherwise, please rephrase to be better understandable.

Yes, this is debug info.

I'll remove next patchset.

-- To view, visit https://review.coreboot.org/c/coreboot/+/48868 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ifadd0def13cc264e9d39ab9c981fbdc996396bfa Gerrit-Change-Number: 48868 Gerrit-PatchSet: 9 Gerrit-Owner: Shaoming Chen shaoming.chen@mediatek.corp-partner.google.com Gerrit-Reviewer: Chen-Tsung Hsieh chentsung@google.com Gerrit-Reviewer: Hung-Te Lin hungte@chromium.org Gerrit-Reviewer: Jitao Shi jitao.shi@mediatek.corp-partner.google.com Gerrit-Reviewer: Nicolas Boichat drinkcat@google.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-CC: Wentao Qin qinwentao@huaqin.corp-partner.google.com Gerrit-CC: Yidi Lin yidi.lin@mediatek.com Gerrit-Comment-Date: Wed, 30 Dec 2020 11:29:22 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Chen-Tsung Hsieh chentsung@google.com Comment-In-Reply-To: Paul Menzel paulepanter@users.sourceforge.net Gerrit-MessageType: comment

jitao shi (Code Review)

11:46 a.m.

New subject: Change in coreboot[master]: soc/mediatek: dsi: Fix EoTp flag

jitao shi has uploaded a new patch set (#10) to the change originally created by Shaoming Chen. ( https://review.coreboot.org/c/coreboot/+/48868 )

Change subject: soc/mediatek: dsi: Fix EoTp flag ......................................................................

soc/mediatek: dsi: Fix EoTp flag

Soc will transmit the EoTp(End of Transmission packet) when MIPI_DSI_MODE_EOT_PACKET flag is setup.

BUG=b:168728787 BRANCH=kukui TEST=Boots correctly on Kukui

Signed-off-by: Shaoming Chen shaoming.chen@mediatek.corp-partner.google.com Change-Id: Ifadd0def13cc264e9d39ab9c981fbdc996396bfa --- M src/soc/mediatek/common/dsi.c M src/soc/mediatek/common/include/soc/dsi_common.h 2 files changed, 7 insertions(+), 1 deletion(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/68/48868/10

-- To view, visit https://review.coreboot.org/c/coreboot/+/48868 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ifadd0def13cc264e9d39ab9c981fbdc996396bfa Gerrit-Change-Number: 48868 Gerrit-PatchSet: 10 Gerrit-Owner: Shaoming Chen shaoming.chen@mediatek.corp-partner.google.com Gerrit-Reviewer: Chen-Tsung Hsieh chentsung@google.com Gerrit-Reviewer: Hung-Te Lin hungte@chromium.org Gerrit-Reviewer: Jitao Shi jitao.shi@mediatek.corp-partner.google.com Gerrit-Reviewer: Nicolas Boichat drinkcat@google.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-Reviewer: jitao shi jitao.shi@mediatek.com Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-CC: Wentao Qin qinwentao@huaqin.corp-partner.google.com Gerrit-CC: Yidi Lin yidi.lin@mediatek.com Gerrit-MessageType: newpatchset

Jitao Shi (Code Review)

11:49 a.m.

New subject: Change in coreboot[master]: soc/mediatek: dsi: Fix EoTp flag

Jitao Shi has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/48868 )

Change subject: soc/mediatek: dsi: Fix EoTp flag ......................................................................

Patch Set 10:

(3 comments)

https://review.coreboot.org/c/coreboot/+/48868/8//COMMIT_MSG Commit Message:

https://review.coreboot.org/c/coreboot/+/48868/8//COMMIT_MSG@7 PS8, Line 7: enable

...

Will fix next version.

Done

https://review.coreboot.org/c/coreboot/+/48868/8//COMMIT_MSG@9 PS8, Line 9: Enable Eotp feature for anx7625.

...

EoTp is End of Transmission packet (EoTp) defined in dsi spec.

Done

https://review.coreboot.org/c/coreboot/+/48868/8//COMMIT_MSG@13 PS8, Line 13: TEST=Boots correctly on Kukui

...

We test it with dsi protocol tool. The protocol tool can receiver the EoTp packet.

Done

-- To view, visit https://review.coreboot.org/c/coreboot/+/48868 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ifadd0def13cc264e9d39ab9c981fbdc996396bfa Gerrit-Change-Number: 48868 Gerrit-PatchSet: 10 Gerrit-Owner: Shaoming Chen shaoming.chen@mediatek.corp-partner.google.com Gerrit-Reviewer: Chen-Tsung Hsieh chentsung@google.com Gerrit-Reviewer: Hung-Te Lin hungte@chromium.org Gerrit-Reviewer: Jitao Shi jitao.shi@mediatek.corp-partner.google.com Gerrit-Reviewer: Nicolas Boichat drinkcat@google.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-Reviewer: jitao shi jitao.shi@mediatek.com Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-CC: Wentao Qin qinwentao@huaqin.corp-partner.google.com Gerrit-CC: Yidi Lin yidi.lin@mediatek.com Gerrit-Comment-Date: Wed, 30 Dec 2020 11:49:53 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Paul Menzel paulepanter@users.sourceforge.net Comment-In-Reply-To: Jitao Shi jitao.shi@mediatek.corp-partner.google.com Gerrit-MessageType: comment

Jitao Shi (Code Review)

11:50 a.m.

New subject: Change in coreboot[master]: soc/mediatek: dsi: Fix EoTp flag

Jitao Shi has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/48868 )

Change subject: soc/mediatek: dsi: Fix EoTp flag ......................................................................

Patch Set 10:

(2 comments)

https://review.coreboot.org/c/coreboot/+/48868/8/src/mainboard/google/kukui/... File src/mainboard/google/kukui/mainboard.c:

https://review.coreboot.org/c/coreboot/+/48868/8/src/mainboard/google/kukui/... PS8, Line 163: if (CONFIG(DRIVER_ANALOGIX_ANX7625)) : mipi_dsi_flags |= MIPI_DSI_MODE_EOT_PACKET;

...

Yes, you are right. […]

Done

https://review.coreboot.org/c/coreboot/+/48868/8/src/mainboard/google/kukui/... PS8, Line 170: printk(BIOS_INFO, "%s: dsi_flags=%#x\n", __func__, mipi_dsi_flags);

...

Yes, this is debug info. […]

Done

-- To view, visit https://review.coreboot.org/c/coreboot/+/48868 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ifadd0def13cc264e9d39ab9c981fbdc996396bfa Gerrit-Change-Number: 48868 Gerrit-PatchSet: 10 Gerrit-Owner: Shaoming Chen shaoming.chen@mediatek.corp-partner.google.com Gerrit-Reviewer: Chen-Tsung Hsieh chentsung@google.com Gerrit-Reviewer: Hung-Te Lin hungte@chromium.org Gerrit-Reviewer: Jitao Shi jitao.shi@mediatek.corp-partner.google.com Gerrit-Reviewer: Nicolas Boichat drinkcat@google.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-Reviewer: jitao shi jitao.shi@mediatek.com Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-CC: Wentao Qin qinwentao@huaqin.corp-partner.google.com Gerrit-CC: Yidi Lin yidi.lin@mediatek.com Gerrit-Comment-Date: Wed, 30 Dec 2020 11:50:42 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Chen-Tsung Hsieh chentsung@google.com Comment-In-Reply-To: Paul Menzel paulepanter@users.sourceforge.net Comment-In-Reply-To: Jitao Shi jitao.shi@mediatek.corp-partner.google.com Gerrit-MessageType: comment

Yidi Lin (Code Review)

11:52 a.m.

New subject: Change in coreboot[master]: soc/mediatek: dsi: Fix EoTp flag

Yidi Lin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/48868 )

Change subject: soc/mediatek: dsi: Fix EoTp flag ......................................................................

Patch Set 10:

(5 comments)

https://review.coreboot.org/c/coreboot/+/48868/4//COMMIT_MSG Commit Message:

https://review.coreboot.org/c/coreboot/+/48868/4//COMMIT_MSG@7 PS4, Line 7: src/mainboard/google

...

mb/google/kukui: enable Eotp feature for anx7625

Done

https://review.coreboot.org/c/coreboot/+/48868/4//COMMIT_MSG@9 PS4, Line 9: enable Eotp feature for anx7625

...

Enable Eotp feature for anx7625.

Done

https://review.coreboot.org/c/coreboot/+/48868/4//COMMIT_MSG@11 PS4, Line 11: none

...

please attach bug ID.

Done

https://review.coreboot.org/c/coreboot/+/48868/4/src/mainboard/google/kukui/... File src/mainboard/google/kukui/mainboard.c:

https://review.coreboot.org/c/coreboot/+/48868/4/src/mainboard/google/kukui/... PS4, Line 170: 0x%x

...

%#x

Done

https://review.coreboot.org/c/coreboot/+/48868/6/src/mainboard/google/kukui/... File src/mainboard/google/kukui/mainboard.c:

https://review.coreboot.org/c/coreboot/+/48868/6/src/mainboard/google/kukui/... PS6, Line 170: 0x%#x

...

just %#x

Done

-- To view, visit https://review.coreboot.org/c/coreboot/+/48868 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ifadd0def13cc264e9d39ab9c981fbdc996396bfa Gerrit-Change-Number: 48868 Gerrit-PatchSet: 10 Gerrit-Owner: Shaoming Chen shaoming.chen@mediatek.corp-partner.google.com Gerrit-Reviewer: Chen-Tsung Hsieh chentsung@google.com Gerrit-Reviewer: Hung-Te Lin hungte@chromium.org Gerrit-Reviewer: Jitao Shi jitao.shi@mediatek.corp-partner.google.com Gerrit-Reviewer: Nicolas Boichat drinkcat@google.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-Reviewer: jitao shi jitao.shi@mediatek.com Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-CC: Wentao Qin qinwentao@huaqin.corp-partner.google.com Gerrit-CC: Yidi Lin yidi.lin@mediatek.com Gerrit-Comment-Date: Wed, 30 Dec 2020 11:52:34 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Yidi Lin yidi.lin@mediatek.com Gerrit-MessageType: comment

Wentao Qin (Code Review)

1:26 p.m.

New subject: Change in coreboot[master]: soc/mediatek: dsi: Fix EoTp flag

Wentao Qin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/48868 )

Change subject: soc/mediatek: dsi: Fix EoTp flag ......................................................................

Patch Set 11:

Hi Hung，May need your help to review again

-- To view, visit https://review.coreboot.org/c/coreboot/+/48868 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ifadd0def13cc264e9d39ab9c981fbdc996396bfa Gerrit-Change-Number: 48868 Gerrit-PatchSet: 11 Gerrit-Owner: Shaoming Chen shaoming.chen@mediatek.corp-partner.google.com Gerrit-Reviewer: Chen-Tsung Hsieh chentsung@google.com Gerrit-Reviewer: Hung-Te Lin hungte@chromium.org Gerrit-Reviewer: Jitao Shi jitao.shi@mediatek.corp-partner.google.com Gerrit-Reviewer: Nicolas Boichat drinkcat@google.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-Reviewer: jitao shi jitao.shi@mediatek.com Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-CC: Wentao Qin qinwentao@huaqin.corp-partner.google.com Gerrit-CC: Xuxin Xiong xuxinxiong@huaqin.corp-partner.google.com Gerrit-CC: Yidi Lin yidi.lin@mediatek.com Gerrit-Comment-Date: Wed, 30 Dec 2020 13:26:28 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment

Yu-Ping Wu (Code Review)

31 Dec 31 Dec

3:04 a.m.

New subject: Change in coreboot[master]: soc/mediatek: dsi: Fix EoTp flag

Yu-Ping Wu has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/48868 )

Change subject: soc/mediatek: dsi: Fix EoTp flag ......................................................................

Patch Set 11:

(5 comments)

https://review.coreboot.org/c/coreboot/+/48868/11//COMMIT_MSG Commit Message:

https://review.coreboot.org/c/coreboot/+/48868/11//COMMIT_MSG@9 PS11, Line 9: Soc SoC

https://review.coreboot.org/c/coreboot/+/48868/11//COMMIT_MSG@9 PS11, Line 9: ( One space before "("

https://review.coreboot.org/c/coreboot/+/48868/11//COMMIT_MSG@10 PS11, Line 10: setup set

https://review.coreboot.org/c/coreboot/+/48868/11//COMMIT_MSG@14 PS11, Line 14: Boots correctly on Kukui Something else related to b/168728787 should be tested. For example,

TEST=Display is normal on Kukui

https://review.coreboot.org/c/coreboot/+/48868/11/src/soc/mediatek/common/ds... File src/soc/mediatek/common/dsi.c:

https://review.coreboot.org/c/coreboot/+/48868/11/src/soc/mediatek/common/ds... PS11, Line 157: tmp_reg |= (mode_flags & MIPI_DSI_CLOCK_NON_CONTINUOUS) << 6; Let's also rewrite this to

if (mode_flags & MIPI_DSI_CLOCK_NON_CONTINUOUS) tmp_reg |= SOMETHING;

where SOMETHING should be BIT(16).

-- To view, visit https://review.coreboot.org/c/coreboot/+/48868 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ifadd0def13cc264e9d39ab9c981fbdc996396bfa Gerrit-Change-Number: 48868 Gerrit-PatchSet: 11 Gerrit-Owner: Shaoming Chen shaoming.chen@mediatek.corp-partner.google.com Gerrit-Reviewer: Chen-Tsung Hsieh chentsung@google.com Gerrit-Reviewer: Hung-Te Lin hungte@chromium.org Gerrit-Reviewer: Jitao Shi jitao.shi@mediatek.corp-partner.google.com Gerrit-Reviewer: Nicolas Boichat drinkcat@google.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-Reviewer: jitao shi jitao.shi@mediatek.com Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-CC: Wentao Qin qinwentao@huaqin.corp-partner.google.com Gerrit-CC: Xuxin Xiong xuxinxiong@huaqin.corp-partner.google.com Gerrit-CC: Yidi Lin yidi.lin@mediatek.com Gerrit-CC: Yu-Ping Wu yupingso@google.com Gerrit-Comment-Date: Thu, 31 Dec 2020 03:04:45 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

jitao shi (Code Review)

3:43 a.m.

New subject: Change in coreboot[master]: soc/mediatek: dsi: Fix EoTp flag

jitao shi has uploaded a new patch set (#12) to the change originally created by Shaoming Chen. ( https://review.coreboot.org/c/coreboot/+/48868 )

Change subject: soc/mediatek: dsi: Fix EoTp flag ......................................................................

soc/mediatek: dsi: Fix EoTp flag

SoC will transmit the EoTp (End of Transmission packet) when MIPI_DSI_MODE_EOT_PACKET flag is set.

Enabling EoTp will make the line time larger, so the hfp and hbp should be reduced to keep line time.

BUG=b:168728787

BRANCH=kukui TEST=Display is normal on Kukui

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/68/48868/12

-- To view, visit https://review.coreboot.org/c/coreboot/+/48868 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ifadd0def13cc264e9d39ab9c981fbdc996396bfa Gerrit-Change-Number: 48868 Gerrit-PatchSet: 12 Gerrit-Owner: Shaoming Chen shaoming.chen@mediatek.corp-partner.google.com Gerrit-Reviewer: Chen-Tsung Hsieh chentsung@google.com Gerrit-Reviewer: Hung-Te Lin hungte@chromium.org Gerrit-Reviewer: Jitao Shi jitao.shi@mediatek.corp-partner.google.com Gerrit-Reviewer: Nicolas Boichat drinkcat@google.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-Reviewer: jitao shi jitao.shi@mediatek.com Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-CC: Wentao Qin qinwentao@huaqin.corp-partner.google.com Gerrit-CC: Xuxin Xiong xuxinxiong@huaqin.corp-partner.google.com Gerrit-CC: Yidi Lin yidi.lin@mediatek.com Gerrit-CC: Yu-Ping Wu yupingso@google.com Gerrit-MessageType: newpatchset

jitao shi (Code Review)

3:55 a.m.

New subject: Change in coreboot[master]: soc/mediatek: dsi: Fix EoTp flag

jitao shi has uploaded a new patch set (#13) to the change originally created by Shaoming Chen. ( https://review.coreboot.org/c/coreboot/+/48868 )

Change subject: soc/mediatek: dsi: Fix EoTp flag ......................................................................

soc/mediatek: dsi: Fix EoTp flag

SoC will transmit the EoTp (End of Transmission packet) when MIPI_DSI_MODE_EOT_PACKET flag is set.

Enabling EoTp will make the line time larger, so the hfp and hbp should be reduced to keep line time.

BUG=b:168728787

BRANCH=kukui TEST=Display is normal on Kukui

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/68/48868/13

-- To view, visit https://review.coreboot.org/c/coreboot/+/48868 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ifadd0def13cc264e9d39ab9c981fbdc996396bfa Gerrit-Change-Number: 48868 Gerrit-PatchSet: 13 Gerrit-Owner: Shaoming Chen shaoming.chen@mediatek.corp-partner.google.com Gerrit-Reviewer: Chen-Tsung Hsieh chentsung@google.com Gerrit-Reviewer: Hung-Te Lin hungte@chromium.org Gerrit-Reviewer: Jitao Shi jitao.shi@mediatek.corp-partner.google.com Gerrit-Reviewer: Nicolas Boichat drinkcat@google.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-Reviewer: jitao shi jitao.shi@mediatek.com Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-CC: Wentao Qin qinwentao@huaqin.corp-partner.google.com Gerrit-CC: Xuxin Xiong xuxinxiong@huaqin.corp-partner.google.com Gerrit-CC: Yidi Lin yidi.lin@mediatek.com Gerrit-CC: Yu-Ping Wu yupingso@google.com Gerrit-MessageType: newpatchset

Jitao Shi (Code Review)

4:08 a.m.

New subject: Change in coreboot[master]: soc/mediatek: dsi: Fix EoTp flag

Jitao Shi has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/48868 )

Change subject: soc/mediatek: dsi: Fix EoTp flag ......................................................................

Patch Set 13:

(5 comments)

https://review.coreboot.org/c/coreboot/+/48868/11//COMMIT_MSG Commit Message:

https://review.coreboot.org/c/coreboot/+/48868/11//COMMIT_MSG@9 PS11, Line 9: (

...

One space before "("

Done

https://review.coreboot.org/c/coreboot/+/48868/11//COMMIT_MSG@9 PS11, Line 9: Soc

...

SoC

Done

https://review.coreboot.org/c/coreboot/+/48868/11//COMMIT_MSG@10 PS11, Line 10: setup

...

set

Done

https://review.coreboot.org/c/coreboot/+/48868/11//COMMIT_MSG@14 PS11, Line 14: Boots correctly on Kukui

...

Something else related to b/168728787 should be tested. For example, […]

Done

https://review.coreboot.org/c/coreboot/+/48868/11/src/soc/mediatek/common/ds... File src/soc/mediatek/common/dsi.c:

https://review.coreboot.org/c/coreboot/+/48868/11/src/soc/mediatek/common/ds... PS11, Line 157: tmp_reg |= (mode_flags & MIPI_DSI_CLOCK_NON_CONTINUOUS) << 6;

...

Let's also rewrite this to […]

Done

-- To view, visit https://review.coreboot.org/c/coreboot/+/48868 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ifadd0def13cc264e9d39ab9c981fbdc996396bfa Gerrit-Change-Number: 48868 Gerrit-PatchSet: 13 Gerrit-Owner: Shaoming Chen shaoming.chen@mediatek.corp-partner.google.com Gerrit-Reviewer: Chen-Tsung Hsieh chentsung@google.com Gerrit-Reviewer: Hung-Te Lin hungte@chromium.org Gerrit-Reviewer: Jitao Shi jitao.shi@mediatek.corp-partner.google.com Gerrit-Reviewer: Nicolas Boichat drinkcat@google.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-Reviewer: jitao shi jitao.shi@mediatek.com Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-CC: Wentao Qin qinwentao@huaqin.corp-partner.google.com Gerrit-CC: Xuxin Xiong xuxinxiong@huaqin.corp-partner.google.com Gerrit-CC: Yidi Lin yidi.lin@mediatek.com Gerrit-CC: Yu-Ping Wu yupingso@google.com Gerrit-Comment-Date: Thu, 31 Dec 2020 04:08:58 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Yu-Ping Wu yupingso@google.com Gerrit-MessageType: comment

Yu-Ping Wu (Code Review)

8:17 a.m.

New subject: Change in coreboot[master]: soc/mediatek: dsi: Fix EoTp flag

Yu-Ping Wu has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/48868 )

Change subject: soc/mediatek: dsi: Fix EoTp flag ......................................................................

Patch Set 13:

(1 comment)

https://review.coreboot.org/c/coreboot/+/48868/13//COMMIT_MSG Commit Message:

https://review.coreboot.org/c/coreboot/+/48868/13//COMMIT_MSG@16 PS13, Line 16: No blank line here.

-- To view, visit https://review.coreboot.org/c/coreboot/+/48868 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ifadd0def13cc264e9d39ab9c981fbdc996396bfa Gerrit-Change-Number: 48868 Gerrit-PatchSet: 13 Gerrit-Owner: Shaoming Chen shaoming.chen@mediatek.corp-partner.google.com Gerrit-Reviewer: Chen-Tsung Hsieh chentsung@google.com Gerrit-Reviewer: Hung-Te Lin hungte@chromium.org Gerrit-Reviewer: Jitao Shi jitao.shi@mediatek.corp-partner.google.com Gerrit-Reviewer: Nicolas Boichat drinkcat@google.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-Reviewer: jitao shi jitao.shi@mediatek.com Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-CC: Wentao Qin qinwentao@huaqin.corp-partner.google.com Gerrit-CC: Xuxin Xiong xuxinxiong@huaqin.corp-partner.google.com Gerrit-CC: Yidi Lin yidi.lin@mediatek.com Gerrit-CC: Yu-Ping Wu yupingso@google.com Gerrit-Comment-Date: Thu, 31 Dec 2020 08:17:59 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

jitao shi (Code Review)

8:28 a.m.

New subject: Change in coreboot[master]: soc/mediatek: dsi: Fix EoTp flag

jitao shi has uploaded a new patch set (#14) to the change originally created by Shaoming Chen. ( https://review.coreboot.org/c/coreboot/+/48868 )

Change subject: soc/mediatek: dsi: Fix EoTp flag ......................................................................

soc/mediatek: dsi: Fix EoTp flag

SoC will transmit the EoTp (End of Transmission packet) when MIPI_DSI_MODE_EOT_PACKET flag is set.

Enabling EoTp will make the line time larger, so the hfp and hbp should be reduced to keep line time.

BUG=b:168728787 BRANCH=kukui TEST=Display is normal on Kukui

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/68/48868/14

-- To view, visit https://review.coreboot.org/c/coreboot/+/48868 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ifadd0def13cc264e9d39ab9c981fbdc996396bfa Gerrit-Change-Number: 48868 Gerrit-PatchSet: 14 Gerrit-Owner: Shaoming Chen shaoming.chen@mediatek.corp-partner.google.com Gerrit-Reviewer: Chen-Tsung Hsieh chentsung@google.com Gerrit-Reviewer: Hung-Te Lin hungte@chromium.org Gerrit-Reviewer: Jitao Shi jitao.shi@mediatek.corp-partner.google.com Gerrit-Reviewer: Nicolas Boichat drinkcat@google.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-Reviewer: jitao shi jitao.shi@mediatek.com Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-CC: Wentao Qin qinwentao@huaqin.corp-partner.google.com Gerrit-CC: Xuxin Xiong xuxinxiong@huaqin.corp-partner.google.com Gerrit-CC: Yidi Lin yidi.lin@mediatek.com Gerrit-CC: Yu-Ping Wu yupingso@google.com Gerrit-MessageType: newpatchset

jitao shi (Code Review)

8:32 a.m.

New subject: Change in coreboot[master]: soc/mediatek: dsi: Fix EoTp flag

jitao shi has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/48868 )

Change subject: soc/mediatek: dsi: Fix EoTp flag ......................................................................

Patch Set 14:

(1 comment)

https://review.coreboot.org/c/coreboot/+/48868/13//COMMIT_MSG Commit Message:

https://review.coreboot.org/c/coreboot/+/48868/13//COMMIT_MSG@16 PS13, Line 16:

...

No blank line here.

Done

-- To view, visit https://review.coreboot.org/c/coreboot/+/48868 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ifadd0def13cc264e9d39ab9c981fbdc996396bfa Gerrit-Change-Number: 48868 Gerrit-PatchSet: 14 Gerrit-Owner: Shaoming Chen shaoming.chen@mediatek.corp-partner.google.com Gerrit-Reviewer: Chen-Tsung Hsieh chentsung@google.com Gerrit-Reviewer: Hung-Te Lin hungte@chromium.org Gerrit-Reviewer: Jitao Shi jitao.shi@mediatek.corp-partner.google.com Gerrit-Reviewer: Nicolas Boichat drinkcat@google.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-Reviewer: jitao shi jitao.shi@mediatek.com Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-CC: Wentao Qin qinwentao@huaqin.corp-partner.google.com Gerrit-CC: Xuxin Xiong xuxinxiong@huaqin.corp-partner.google.com Gerrit-CC: Yidi Lin yidi.lin@mediatek.com Gerrit-CC: Yu-Ping Wu yupingso@google.com Gerrit-Comment-Date: Thu, 31 Dec 2020 08:32:50 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Yu-Ping Wu yupingso@google.com Gerrit-MessageType: comment

Yu-Ping Wu (Code Review)

8:38 a.m.

New subject: Change in coreboot[master]: soc/mediatek: dsi: Fix EoTp flag

Yu-Ping Wu has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/48868 )

Change subject: soc/mediatek: dsi: Fix EoTp flag ......................................................................

Patch Set 14: Code-Review+2

-- To view, visit https://review.coreboot.org/c/coreboot/+/48868 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ifadd0def13cc264e9d39ab9c981fbdc996396bfa Gerrit-Change-Number: 48868 Gerrit-PatchSet: 14 Gerrit-Owner: Shaoming Chen shaoming.chen@mediatek.corp-partner.google.com Gerrit-Reviewer: Chen-Tsung Hsieh chentsung@google.com Gerrit-Reviewer: Hung-Te Lin hungte@chromium.org Gerrit-Reviewer: Jitao Shi jitao.shi@mediatek.corp-partner.google.com Gerrit-Reviewer: Nicolas Boichat drinkcat@google.com Gerrit-Reviewer: Yu-Ping Wu yupingso@google.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-Reviewer: jitao shi jitao.shi@mediatek.com Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-CC: Wentao Qin qinwentao@huaqin.corp-partner.google.com Gerrit-CC: Xuxin Xiong xuxinxiong@huaqin.corp-partner.google.com Gerrit-CC: Yidi Lin yidi.lin@mediatek.com Gerrit-Comment-Date: Thu, 31 Dec 2020 08:38:06 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

Hung-Te Lin (Code Review)

1 Jan 1 Jan

2:58 a.m.

New subject: Change in coreboot[master]: soc/mediatek: dsi: Fix EoTp flag

Hung-Te Lin has submitted this change. ( https://review.coreboot.org/c/coreboot/+/48868 )

Change subject: soc/mediatek: dsi: Fix EoTp flag ......................................................................

soc/mediatek: dsi: Fix EoTp flag

SoC will transmit the EoTp (End of Transmission packet) when MIPI_DSI_MODE_EOT_PACKET flag is set.

Enabling EoTp will make the line time larger, so the hfp and hbp should be reduced to keep line time.

BUG=b:168728787 BRANCH=kukui TEST=Display is normal on Kukui

Signed-off-by: Shaoming Chen shaoming.chen@mediatek.corp-partner.google.com Change-Id: Ifadd0def13cc264e9d39ab9c981fbdc996396bfa Reviewed-on: https://review.coreboot.org/c/coreboot/+/48868 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Yu-Ping Wu yupingso@google.com --- M src/soc/mediatek/common/dsi.c M src/soc/mediatek/common/include/soc/dsi_common.h 2 files changed, 15 insertions(+), 2 deletions(-)

Approvals: build bot (Jenkins): Verified Yu-Ping Wu: Looks good to me, approved

diff --git a/src/soc/mediatek/common/dsi.c b/src/soc/mediatek/common/dsi.c index 2505bbc..8254dc5 100644 --- a/src/soc/mediatek/common/dsi.c +++ b/src/soc/mediatek/common/dsi.c @@ -154,8 +154,11 @@ break; }

- tmp_reg |= (mode_flags & MIPI_DSI_CLOCK_NON_CONTINUOUS) << 6; - tmp_reg |= (mode_flags & MIPI_DSI_MODE_EOT_PACKET) >> 3; + if (mode_flags & MIPI_DSI_CLOCK_NON_CONTINUOUS) + tmp_reg |= NON_CONTINUOUS_CLK; + + if (!(mode_flags & MIPI_DSI_MODE_EOT_PACKET)) + tmp_reg |= EOTP_DISABLE;

write32(&dsi0->dsi_txrx_ctrl, tmp_reg); } @@ -202,6 +205,10 @@ phy_timing->da_hs_zero + phy_timing->da_hs_exit + 3;

u32 delta = 12; + + if (mode_flags & MIPI_DSI_MODE_EOT_PACKET) + delta += 2; + if (mode_flags & MIPI_DSI_MODE_VIDEO_BURST) delta += 6;

diff --git a/src/soc/mediatek/common/include/soc/dsi_common.h b/src/soc/mediatek/common/include/soc/dsi_common.h index 7bacec1..aebe62a 100644 --- a/src/soc/mediatek/common/include/soc/dsi_common.h +++ b/src/soc/mediatek/common/include/soc/dsi_common.h @@ -118,6 +118,12 @@ MIX_MODE = BIT(17) };

+/* DSI_TXRX_CTRL */ +enum { + EOTP_DISABLE = BIT(6), + NON_CONTINUOUS_CLK = BIT(16), +}; + /* DSI_PSCTRL */ enum { DSI_PS_WC = 0x3fff,

-- To view, visit https://review.coreboot.org/c/coreboot/+/48868 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ifadd0def13cc264e9d39ab9c981fbdc996396bfa Gerrit-Change-Number: 48868 Gerrit-PatchSet: 15 Gerrit-Owner: Shaoming Chen shaoming.chen@mediatek.corp-partner.google.com Gerrit-Reviewer: Chen-Tsung Hsieh chentsung@google.com Gerrit-Reviewer: Hung-Te Lin hungte@chromium.org Gerrit-Reviewer: Jitao Shi jitao.shi@mediatek.corp-partner.google.com Gerrit-Reviewer: Nicolas Boichat drinkcat@google.com Gerrit-Reviewer: Yu-Ping Wu yupingso@google.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-Reviewer: jitao shi jitao.shi@mediatek.com Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-CC: Wentao Qin qinwentao@huaqin.corp-partner.google.com Gerrit-CC: Xuxin Xiong xuxinxiong@huaqin.corp-partner.google.com Gerrit-CC: Yidi Lin yidi.lin@mediatek.com Gerrit-MessageType: merged

1228

days inactive

1237

days old

coreboot-gerrit@coreboot.org

29 comments

10 participants

tags (0)

participants (10)

build bot (Jenkins) (Code Review)
Chen-Tsung Hsieh (Code Review)
Hung-Te Lin (Code Review)
Jitao Shi (Code Review)
jitao shi (Code Review)
Paul Menzel (Code Review)
Shaoming Chen (Code Review)
Wentao Qin (Code Review)
Yidi Lin (Code Review)
Yu-Ping Wu (Code Review)