Patrick Rudolph has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33738 )
Change subject: device/Kconfig: Add HAVE_EXT_GFX kconfig ......................................................................
Patch Set 8:
(1 comment)
I guess the main issue is that you are mixing two unrelated graphic options here. 1. Preferred GPU in a (multi) GPU system 2. Preferred graphic initialisation method
To resolve that I propose a new Kconfig choice "Preferred GPU configuration" instead of a single Kconfig: * Disable all GPUs * Enable IGD only in multi GPU setup * Enable PEG only in multi GPU setup (default) * Enable all GPUs in multi GPU setup
It does not depend on graphic initialisation, but graphic initialisation would depend on it. For example you would never run GOP / libgfxinit in case of "Enable PEG only in multi GPU setup".
FSP would make use of the new choice to properly configure all graphic devices.
https://review.coreboot.org/c/coreboot/+/33738/6/src/device/Kconfig File src/device/Kconfig:
https://review.coreboot.org/c/coreboot/+/33738/6/src/device/Kconfig@133 PS6, Line 133: graphics card and selecting this Kconfig will ask FSP to make IGD disable.
This is not the case in the current patch or one of the following. […]
Such a policy does not exist (yet). It's possible to use IGD and dGPU on some coreboot enabled platforms.