Attention is currently required from: Bao Zheng, Zheng Bao.
Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/69043 )
Change subject: amdfwtool: Add support for 32M image size ......................................................................
Patch Set 1:
(1 comment)
File util/amdfwtool/amdfwtool.c:
https://review.coreboot.org/c/coreboot/+/69043/comment/5f21300c_a0e9988c PS1, Line 2302: case 0xFFFA0000: /* Fall through */ : case 0xFFF20000: /* Fall through */ : case 0xFFE20000: /* Fall through */ : case 0xFFC20000: /* Fall through */ : case 0xFF820000: /* Fall through */ : case 0xFF020000: /* Fall through */ Note that this is just not correct. The EFS is checked at SPI flash offsets, not x86 memory mapped ones.
•1st Address checked (recommended)0xFA0000 •2nd Address checked 0xF20000 •3rd Address checked 0xE20000 •4th Address checked 0xC20000 •5th Address checked 0x820000 •6th Address checked 0x20000