build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/48340 )
Change subject: soc/intel/alderlake: Revise PCIE port config ......................................................................
Patch Set 3:
(5 comments)
https://review.coreboot.org/c/coreboot/+/48340/3/src/soc/intel/alderlake/rom... File src/soc/intel/alderlake/romstage/fsp_params.c:
https://review.coreboot.org/c/coreboot/+/48340/3/src/soc/intel/alderlake/rom... PS3, Line 47: config->PcieClkSrcClkReq[config->PcieRp[i].clkreq] = config->PcieRp[i].clksrc; line over 96 characters
https://review.coreboot.org/c/coreboot/+/48340/3/src/soc/intel/alderlake/rom... PS3, Line 48: config->PcieClkSrcUsage[config->PcieRp[i].clksrc] = if(config->PcieRp[i].clkusage) ? config->PcieRp[i].clkusage : i ; line over 96 characters
https://review.coreboot.org/c/coreboot/+/48340/3/src/soc/intel/alderlake/rom... PS3, Line 48: config->PcieClkSrcUsage[config->PcieRp[i].clksrc] = if(config->PcieRp[i].clkusage) ? config->PcieRp[i].clkusage : i ; space prohibited before semicolon
https://review.coreboot.org/c/coreboot/+/48340/3/src/soc/intel/alderlake/rom... PS3, Line 48: config->PcieClkSrcUsage[config->PcieRp[i].clksrc] = if(config->PcieRp[i].clkusage) ? config->PcieRp[i].clkusage : i ; space required before the open parenthesis '('
https://review.coreboot.org/c/coreboot/+/48340/3/src/soc/intel/alderlake/rom... PS3, Line 48: config->PcieClkSrcUsage[config->PcieRp[i].clksrc] = if(config->PcieRp[i].clkusage) ? config->PcieRp[i].clkusage : i ; trailing statements should be on next line