Tristan Hsieh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/30330 )
Change subject: mediatek/mt8183: Move some initialization to verstage if possible
......................................................................
Patch Set 5:
(1 comment)
https://review.coreboot.org/#/c/30330/5/src/soc/mediatek/mt8183/early_init.c
File src/soc/mediatek/mt8183/early_init.c:
https://review.coreboot.org/#/c/30330/5/src/soc/mediatek/mt8183/early_init.c...
PS5, Line 22: mt_pll_init();
Are you sure that this can safely move into verstage? The SPI peripheral is parented on MAINPLL whic […]
I didn't get the reply from SPI experts yet, but I guess it's not safe to change PLL after SPI init.
Can we still init pll here and move others (wdt / gpio) to later stage?
Init PLL in earlier stage also improves performance.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/30330
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I7d482f06a8cc97be0c390ed863aa3ac05d4a3459
Gerrit-Change-Number: 30330
Gerrit-PatchSet: 5
Gerrit-Owner: You-Cheng Syu
youcheng@google.com
Gerrit-Reviewer: Chun-ta Lin
itspeter@google.com
Gerrit-Reviewer: Hung-Te Lin
hungte@chromium.org
Gerrit-Reviewer: Julius Werner
jwerner@chromium.org
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Tristan Hsieh
tristan.shieh@mediatek.com
Gerrit-Reviewer: You-Cheng Syu
youcheng@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Aaron Durbin
adurbin@chromium.org
Gerrit-CC: Patrick Rudolph
patrick.rudolph@9elements.com
Gerrit-Comment-Date: Thu, 17 Jan 2019 08:43:13 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Julius Werner
jwerner@chromium.org
Gerrit-MessageType: comment