Change in ...coreboot[master]: mediatek/mt8183: Move some initialization to verstage if possible
Tristan Hsieh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/30330 )
Change subject: mediatek/mt8183: Move some initialization to verstage if possible ......................................................................
Patch Set 5:
(1 comment)
https://review.coreboot.org/#/c/30330/5/src/soc/mediatek/mt8183/early_init.c File src/soc/mediatek/mt8183/early_init.c:
https://review.coreboot.org/#/c/30330/5/src/soc/mediatek/mt8183/early_init.c... PS5, Line 22: mt_pll_init();
Are you sure that this can safely move into verstage? The SPI peripheral is parented on MAINPLL whic […]
I didn't get the reply from SPI experts yet, but I guess it's not safe to change PLL after SPI init. Can we still init pll here and move others (wdt / gpio) to later stage? Init PLL in earlier stage also improves performance.
-
Tristan Hsieh (Code Review)