Sajida Bhanu has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38542 )
Change subject: sc7180: QSIP SPI NOR addressing mode ......................................................................
Patch Set 12:
(7 comments)
https://review.coreboot.org/c/coreboot/+/38542/6/src/drivers/spi/spi_flash.c File src/drivers/spi/spi_flash.c:
https://review.coreboot.org/c/coreboot/+/38542/6/src/drivers/spi/spi_flash.c... PS6, Line 499: if (reg8 & 0x1 ) {
braces {} are not necessary for single statement blocks
Done
https://review.coreboot.org/c/coreboot/+/38542/6/src/drivers/spi/spi_flash.c... PS6, Line 499: if (reg8 & 0x1 ) {
space prohibited before that close parenthesis ')'
Done
https://review.coreboot.org/c/coreboot/+/38542/6/src/drivers/spi/spi_flash.c... PS6, Line 500: printk(BIOS_WARNING, "4 byte adressing mode set:%02x\n. Falling back to 3 byte addressing mode\n", reg8);
line over 96 characters
sure
https://review.coreboot.org/c/coreboot/+/38542/6/src/drivers/spi/spi_flash.c... PS6, Line 505: if (reg8 & 0x1 ) {
space prohibited before that close parenthesis ')'
Done
https://review.coreboot.org/c/coreboot/+/38542/6/src/drivers/spi/spi_flash.c... PS6, Line 506: printk(BIOS_WARNING, "4 byte adressing mode set:%02x\n. Exiting 4 byte mode not working . Looping here\n ", reg8);
line over 96 characters
sure
https://review.coreboot.org/c/coreboot/+/38542/6/src/drivers/spi/spi_flash.c... PS6, Line 507: while(1);
space required before the open parenthesis '('
Done
https://review.coreboot.org/c/coreboot/+/38542/6/src/drivers/spi/spi_flash.c... PS6, Line 507: while(1);
trailing statements should be on next line
Done