Attention is currently required from: David Hendricks.
Idwer Vollering has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/49310 )
Change subject: util/board_status/board_status.sh: build the cbmem binary when absent
......................................................................
Patch Set 8:
(1 comment)
File util/board_status/board_status.sh:
https://review.coreboot.org/c/coreboot/+/49310/comment/0fcb6f51_e924a0da
PS7, Line 416: [ ! -x util/cbmem/cbmem ]; then
Should these changes to in the 'else' clause? '-n' tests if the string is not empty, in which case t […]
Should the built cbmem binary be removed afterwards?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/49310
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ia6442e8ba5e789fc5eab89b6796ec45635f1e923
Gerrit-Change-Number: 49310
Gerrit-PatchSet: 8
Gerrit-Owner: Idwer Vollering
vidwer@gmail.com
Gerrit-Reviewer: David Hendricks
david.hendricks@gmail.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: David Hendricks
david.hendricks@gmail.com
Gerrit-Comment-Date: Tue, 02 Feb 2021 20:40:40 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: David Hendricks
david.hendricks@gmail.com
Gerrit-MessageType: comment