Julius Werner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35023 )
Change subject: libpayload/usb: add USB 3.1 GEN2 support
......................................................................
Patch Set 5:
(1 comment)
https://review.coreboot.org/c/coreboot/+/35023/5/payloads/libpayload/drivers...
File payloads/libpayload/drivers/usb/usb.c:
https://review.coreboot.org/c/coreboot/+/35023/5/payloads/libpayload/drivers...
PS5, Line 666: ultra
Sorry for being too late with my comments... but what is "ultra"? Is that an actual term used in the USB specs somewhere? We should be using the official names here (e.g. "super-plus-" or "super+" or something), not make something up. (Technically it's only super+x1, but it doesn't seem like any system really uses the x2 ones so I guess we can ignore them.)
--
To view, visit
https://review.coreboot.org/c/coreboot/+/35023
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ia0ef12b2f0d91bf0d0db766bbc9019de1614a4f4
Gerrit-Change-Number: 35023
Gerrit-PatchSet: 5
Gerrit-Owner: EricR Lai
ericr_lai@compal.corp-partner.google.com
Gerrit-Reviewer: Duncan Laurie
dlaurie@chromium.org
Gerrit-Reviewer: EricR Lai
ericr_lai@compal.corp-partner.google.com
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Julius Werner
jwerner@chromium.org
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Frank Wu
frank_wu@compal.corp-partner.google.com
Gerrit-CC: Ivy Jian
ivy_jian@compal.corp-partner.google.com
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Tue, 27 Aug 2019 21:32:38 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
