cedarhouse1@comcast.net has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/38820 )
Change subject: cpu/x86: Remove unnecessary guard. ......................................................................
cpu/x86: Remove unnecessary guard.
The is_smm_enabled is not necessary because it is done previously in this code path.
Signed-off-by: Eugene D. Myers edmyers@tycho.nsa.gov Change-Id: I20d50acbea891cb56ad49edc128df25d21c5f1ca --- M src/cpu/x86/mp_init.c 1 file changed, 7 insertions(+), 12 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/20/38820/1
diff --git a/src/cpu/x86/mp_init.c b/src/cpu/x86/mp_init.c index 5169861..6082df9 100644 --- a/src/cpu/x86/mp_init.c +++ b/src/cpu/x86/mp_init.c @@ -747,20 +747,15 @@ mp_state.ops.relocation_handler(cpu, curr_smbase, perm_smbase);
if (CONFIG(STM)) { - if (is_smm_enabled()) { - uintptr_t mseg; + uintptr_t mseg;
- mseg = mp_state.perm_smbase + - (mp_state.perm_smsize - CONFIG_MSEG_SIZE); + mseg = mp_state.perm_smbase + + (mp_state.perm_smsize - CONFIG_MSEG_SIZE);
- stm_setup(mseg, p->cpu, runtime->num_cpus, - perm_smbase, - mp_state.perm_smbase, - runtime->start32_offset); - } else { - printk(BIOS_DEBUG, - "STM not loaded because SMM is not enabled!\n"); - } + stm_setup(mseg, p->cpu, runtime->num_cpus, + perm_smbase, + mp_state.perm_smbase, + runtime->start32_offset); } }