Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/30890 )
Change subject: autoport: Add support for Haswell-LynxPoint platform
......................................................................
Patch Set 13:
(2 comments)
https://review.coreboot.org/c/coreboot/+/30890/13/util/autoport/lynxpoint.go
File util/autoport/lynxpoint.go:
https://review.coreboot.org/c/coreboot/+/30890/13/util/autoport/lynxpoint.go...
PS13, Line 278: romstage.c
I've changed the format of this file substantially with topic:haswell-pei-data-noises. Most of the pei_data stuff is now handled either automatically or through other mechanisms
https://review.coreboot.org/c/coreboot/+/30890/13/util/autoport/lynxpoint.go...
PS13, Line 326: 1
if b. […]
Not a problem anymore, it's determined automatically at runtime based on PCI IDs. But this needs to be changed quite a bit
--
To view, visit
https://review.coreboot.org/c/coreboot/+/30890
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I4f6e8c97b5122101de2f36bba8ba9f8ddd5b813a
Gerrit-Change-Number: 30890
Gerrit-PatchSet: 13
Gerrit-Owner: Iru Cai (vimacs)
mytbk920423@gmail.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Daniel Maslowski
info@orangecms.org
Gerrit-Reviewer: Iru Cai (vimacs)
mytbk920423@gmail.com
Gerrit-Reviewer: Iru Cai
mytbk920423@gmail.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Arthur Heymans
arthur@aheymans.xyz
Gerrit-CC: Christoph Pomaska
github@slrie.de
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-CC: Tristan Corrick
tristan@corrick.kiwi
Gerrit-Comment-Date: Fri, 17 Jul 2020 08:26:17 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Angel Pons
th3fanbus@gmail.com
Gerrit-MessageType: comment
