Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40379 )
Change subject: soc/intel: Update SA common code based on CONFIG_PCI_SEGMENT_GROUPS ......................................................................
Patch Set 3:
(3 comments)
https://review.coreboot.org/c/coreboot/+/40379/3/src/soc/intel/apollolake/sy... File src/soc/intel/apollolake/systemagent.c:
https://review.coreboot.org/c/coreboot/+/40379/3/src/soc/intel/apollolake/sy... PS3, Line 35: "PCIEXBAR" }, Nit, while we are touching this, we could make it a single line (96 chars are allowed now).
https://review.coreboot.org/c/coreboot/+/40379/3/src/soc/intel/common/block/... File src/soc/intel/common/block/systemagent/Kconfig:
https://review.coreboot.org/c/coreboot/+/40379/3/src/soc/intel/common/block/... PS3, Line 13: int Nit, no need to specify the type for a default override, IIRC.
https://review.coreboot.org/c/coreboot/+/40379/3/src/soc/intel/common/block/... PS3, Line 12: config PCI_SEGMENT_GROUPS : int : default 2 if TCSS_PCIE_SEGMENT Please add this later in the patch series, around CB:41011 for instance.