Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45623 )
Change subject: ec/kontron: Fix control flow DEADCODE issue
......................................................................
Patch Set 8: Code-Review-1
I strongly advice against using assert() like this. If we know,
event want, that the check is done at build time, we should use
_Static_assertion(). Beside being clear to the reader it also
allows us to specify a proper error message.
Do we even know if using assert() (which only does the build-
time check with our custom implementation) will calm Coverity?
iow. is it smart enough to detect that this is no usual assert()?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/45623
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ic002e708636961358969b2c1eaec0fee5bbcb73a
Gerrit-Change-Number: 45623
Gerrit-PatchSet: 8
Gerrit-Owner: John Zhao
john.zhao@intel.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Maxim Polyakov
max.senia.poliak@gmail.com
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Thu, 24 Sep 2020 19:35:56 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment