Attention is currently required from: Krystian Hebel, Michał Żygowski, Patrick Rudolph, Paul Menzel, Tim Crawford.
Michał Kopeć has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/73981?usp=email )
Change subject: drivers/smmstore/ramstage.c: retry smmstore init up 5 times
......................................................................
Patch Set 2:
(2 comments)
Patchset:
PS2:
Thanks for the review guys, I am finally getting around to addressing review under my CLs.
Rebased and switched to calling `call_smm` instead of open-coding the SMM call. Removed the delay as per Tim's suggestion.
File src/drivers/smmstore/ramstage.c:
https://review.coreboot.org/c/coreboot/+/73981/comment/7aa2fa0b_32a7c686 :
PS1, Line 79: } while (retry--);
The assembly code and the loop as implemented is fine. […]
@Paul I added info on how many retries were done to the error message.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/73981?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I8929af25c4f69873bbdd835fde5cb60fc324b6ab
Gerrit-Change-Number: 73981
Gerrit-PatchSet: 2
Gerrit-Owner: Michał Kopeć
michal.kopec@3mdeb.com
Gerrit-Reviewer: Krystian Hebel
krystian.hebel@3mdeb.com
Gerrit-Reviewer: Michał Żygowski
michal.zygowski@3mdeb.com
Gerrit-Reviewer: Patrick Rudolph
patrick.rudolph@9elements.com
Gerrit-Reviewer: Sean Rhodes
sean@starlabs.systems
Gerrit-Reviewer: Tim Crawford
tcrawford@system76.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Arthur Heymans
arthur@aheymans.xyz
Gerrit-CC: Matt DeVillier
matt.devillier@gmail.com
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-CC: Stefan Reinauer
stefan.reinauer@coreboot.org
Gerrit-Attention: Tim Crawford
tcrawford@system76.com
Gerrit-Attention: Michał Żygowski
michal.zygowski@3mdeb.com
Gerrit-Attention: Patrick Rudolph
patrick.rudolph@9elements.com
Gerrit-Attention: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Krystian Hebel
krystian.hebel@3mdeb.com
Gerrit-Comment-Date: Thu, 04 Apr 2024 12:36:28 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Tim Crawford
tcrawford@system76.com
Comment-In-Reply-To: Patrick Rudolph
patrick.rudolph@9elements.com
Comment-In-Reply-To: Paul Menzel
paulepanter@mailbox.org
Comment-In-Reply-To: Krystian Hebel
krystian.hebel@3mdeb.com
Comment-In-Reply-To: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-MessageType: comment