Yidi Lin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/47008 )
Change subject: mb/google/asurada: Configure pins mode for SD ......................................................................
Patch Set 2:
(3 comments)
https://review.coreboot.org/c/coreboot/+/47008/1//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/47008/1//COMMIT_MSG@11 PS1, Line 11: Enable VCC and VCCQ power supply for SD.
Either start a new paragraph (by adding a blank line before this), or merge into the previous line.
Ack
https://review.coreboot.org/c/coreboot/+/47008/1/src/mainboard/google/asurad... File src/mainboard/google/asurada/mainboard.c:
https://review.coreboot.org/c/coreboot/+/47008/1/src/mainboard/google/asurad... PS1, Line 11: #include <soc/regulator.h>
Please sort these.
Ack
https://review.coreboot.org/c/coreboot/+/47008/1/src/mainboard/google/asurad... PS1, Line 101: if (!mainboard_regulator_is_enabled(MTK_REGULATOR_VCC)) : mainboard_enable_requlator(MTK_REGULATOR_VCC, enable); : if (!mainboard_regulator_is_enabled(MTK_REGULATOR_VCCQ)) : mainboard_enable_requlator(MTK_REGULATOR_VCCQ, enable);
will there be problems if we just call mainboard_enable_regulator without checking if it's already e […]
Done. CB:46687