Daniel Kurtz has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31082 )
Change subject: amd/stoneyridge: Disable GPIO MASK STATUS ......................................................................
Patch Set 1: Code-Review+1
(3 comments)
https://review.coreboot.org/#/c/31082/1/src/soc/amd/stoneyridge/gpio.c File src/soc/amd/stoneyridge/gpio.c:
https://review.coreboot.org/#/c/31082/1/src/soc/amd/stoneyridge/gpio.c@267 PS1, Line 267: Per https://www.coreboot.org/Developer_Manual (which may be of date?), coreboot uses linux kernel style for which the the preferred style for long (multi-line) comments is:
/* * This is the preferred style for multi-line * comments in the Linux kernel source code. * Please use it consistently. * * Description: A column of asterisks on the left side, * with beginning and ending almost-blank lines. */
https://review.coreboot.org/#/c/31082/1/src/soc/amd/stoneyridge/gpio.c@344 PS1, Line 344: will s/will/may
https://review.coreboot.org/#/c/31082/1/src/soc/amd/stoneyridge/include/soc/... File src/soc/amd/stoneyridge/include/soc/gpio.h:
https://review.coreboot.org/#/c/31082/1/src/soc/amd/stoneyridge/include/soc/... PS1, Line 45: #define MASK_STATUS_SHIFT 28 Hmm, perhaps stick closer to the BKDG names?
#define GPIO_INTERRUPT_EN BIT(30) #define GPIO_MASK_STS_EN BIT(28)
and then in the .c: mem_read_write32(inter_master, GPIO_INTERRUPT_EN | GPIO_MASK_STS_EN, 0); ... mem_read_write32(inter_master, GPIO_INTERRUPT_EN, GPIO_INTERRUPT_EN);