Aaron Durbin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39982 )
Change subject: mb/google/glados: drop VR config from devicetree
......................................................................
Patch Set 1:
(1 comment)
https://review.coreboot.org/c/coreboot/+/39982/1//COMMIT_MSG
Commit Message:
https://review.coreboot.org/c/coreboot/+/39982/1//COMMIT_MSG@10
PS1, Line 10: (SKL-U or SKL-Y), so drop them from the variant devicetrees.
defaults for each domain are defined soc/intel/skylake/vr_config. […]
Perfect. Could you please leave a synopsis of that diligence in the commit description? And make sure this patch officially has a dependency on CB:39980.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/39982
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I4307f6e19ae6f99d4f5e475b181fd66c5b92f28c
Gerrit-Change-Number: 39982
Gerrit-PatchSet: 1
Gerrit-Owner: Matt DeVillier
matt.devillier@gmail.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Aaron Durbin
adurbin@chromium.org
Gerrit-Comment-Date: Tue, 31 Mar 2020 20:05:37 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Matt DeVillier
matt.devillier@gmail.com
Comment-In-Reply-To: Aaron Durbin
adurbin@chromium.org
Gerrit-MessageType: comment