6 Jul
2020
6 Jul
'20
1:29 p.m.
Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/43045 )
Change subject: chromeec: fix error path return value ......................................................................
Patch Set 1:
(1 comment)
https://review.coreboot.org/c/coreboot/+/43045/1/src/ec/google/chromeec/ec_l... File src/ec/google/chromeec/ec_lpc.c:
https://review.coreboot.org/c/coreboot/+/43045/1/src/ec/google/chromeec/ec_l... PS1, Line 247: 1 There are an awful lot of calls to google_chromeec_command() in this codebase.... but I tend to agree, returning -sizeof(rq) when the EC returned an error code seems very odd. If it was -cec_comand->cmd_code I could see that. git blame shows that Duncan wrote this, wdyt Duncan?
--
To view, visit https://review.coreboot.org/c/coreboot/+/43045
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I6bf8d74229f4ac2bf87f9ee83e0c88c3c94de765
Gerrit-Change-Number: 43045
Gerrit-PatchSet: 1
Gerrit-Owner: Caveh Jalali caveh@chromium.org
Gerrit-Reviewer: Duncan Laurie dlaurie@chromium.org
Gerrit-Reviewer: Nick Vaccaro nvaccaro@google.com
Gerrit-Reviewer: Paul Menzel paulepanter@users.sourceforge.net
Gerrit-Reviewer: Tim Wawrzynczak twawrzynczak@chromium.org
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-Comment-Date: Mon, 06 Jul 2020 20:29:59 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment