[coreboot-gerrit] Change in ...coreboot[master]: soc/intel: Provide SPD manufacturer ID and module type to SMBIOS

[HAOUAS Elyes (Code Review)]

HAOUAS Elyes has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33379 )

Change subject: soc/intel: Provide SPD manufacturer ID and module type to SMBIOS
......................................................................

Patch Set 1:

(1 comment)

https://review.coreboot.org/#/c/33379/1/src/soc/intel/common/smbios.c 
File src/soc/intel/common/smbios.c:

https://review.coreboot.org/#/c/33379/1/src/soc/intel/common/smbios.c@29 
PS1, Line 29: dimm->mod_id = mod_id;
            : 	/* Translate to DDR2 module type field that SMBIOS code expects. */
            : 	switch (mod_type) {
            : 	case SPD_DIMM_TYPE_SO_DIMM:
            : 		dimm->mod_type = SPD_SODIMM;
            : 		break;
            : 	case SPD_DIMM_TYPE_72B_SO_CDIMM:
            : 		dimm->mod_type = SPD_72B_SO_CDIMM;
            : 		break;
            : 	case SPD_DIMM_TYPE_72B_SO_RDIMM:
            : 		dimm->mod_type = SPD_72B_SO_RDIMM;
            : 		break;
            : 	case SPD_DIMM_TYPE_UDIMM:
            : 		dimm->mod_type = SPD_UDIMM;
            : 		break;
            : 	case SPD_DIMM_TYPE_RDIMM:
            : 		dimm->mod_type = SPD_RDIMM;
            : 		break;
            : 	case SPD_DIMM_TYPE_UNDEFINED:
            : 	default:
            : 		dimm->mod_type = SPD_UNDEFINED;
            : 		break;
            : 	}
why it is not inhere: src/arch/x86/smbios.c for exmple ?
is it specific to common intel soc?