Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42242 )
Change subject: drivers/ocp/ipmi: Add ipmi set processor information ......................................................................
Patch Set 8: Code-Review+1
(3 comments)
https://review.coreboot.org/c/coreboot/+/42242/8/src/drivers/ocp/ipmi/Kconfi... File src/drivers/ocp/ipmi/Kconfig:
https://review.coreboot.org/c/coreboot/+/42242/8/src/drivers/ocp/ipmi/Kconfi... PS8, Line 5: MANU_ID IPMI_OCP_MANU_ID maybe?
https://review.coreboot.org/c/coreboot/+/42242/8/src/drivers/ocp/ipmi/ipmi_o... File src/drivers/ocp/ipmi/ipmi_ocp.h:
https://review.coreboot.org/c/coreboot/+/42242/8/src/drivers/ocp/ipmi/ipmi_o... PS8, Line 8: #include "drivers/ipmi/ipmi_kcs.h" Add an empty line between the #include and the #define
https://review.coreboot.org/c/coreboot/+/42242/8/src/drivers/ocp/ipmi/ipmi_o... File src/drivers/ocp/ipmi/ipmi_ocp.c:
https://review.coreboot.org/c/coreboot/+/42242/8/src/drivers/ocp/ipmi/ipmi_o... PS8, Line 127: 0xa nit: 0x0a